[PATCH 1/2] test: Ignore files created during emacs testing.

[PATCH 1/2] test: Ignore files created during emacs testing.

[David Edmondson]

---
 test/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/test/.gitignore b/test/.gitignore
index b34778f..42a6647 100644
--- a/test/.gitignore
+++ b/test/.gitignore
@@ -1,3 +1,4 @@
 test-results
 corpus.mail
 smtp-dummy
+tmp.emacs
-- 
1.7.2.3

[PATCH 2/2] emacs: Use truenames for Fcc paths.

[David Edmondson]

Appease the test suite by using the true name for the Fcc directory
path, otherwise a value for `notmuch-database-path' which includes
symbolic links causes test suite failures.
---
 emacs/notmuch-maildir-fcc.el |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index e5e0549..3f1c124 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -110,11 +110,12 @@ will NOT be removed or replaced."
     (when subdir
       (message-add-header
        (concat "Fcc: "
-	       ;; If the resulting directory is not an absolute path,
-	       ;; prepend the standard notmuch database path.
-	       (if (= (elt subdir 0) ?/)
-		   subdir
-		 (concat (notmuch-database-path) "/" subdir))))
+	       (file-truename
+		;; If the resulting directory is not an absolute path,
+		;; prepend the standard notmuch database path.
+		(if (= (elt subdir 0) ?/)
+		    subdir
+		  (concat (notmuch-database-path) "/" subdir)))))
       
       ;; finally test if fcc points to a valid maildir
       (let ((fcc-header (message-fetch-field "Fcc")))
-- 
1.7.2.3

Re: [PATCH 2/2] emacs: Use truenames for Fcc paths.

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On Fri, 12 Nov 2010 08:07:02 +0000, David Edmondson <dme@dme.org> wrote:
> Appease the test suite by using the true name for the Fcc directory
> path, otherwise a value for `notmuch-database-path' which includes
> symbolic links causes test suite failures.

Thanks David,

This is committed now.

I also pushed the previous .gitignore change, but expanded it from
tmp.emacs to tmp.*, (the tmp.<testname> directory getting left behind
isn't anything specific to emacs---those directories are left behind by
any test-suite failure to help you investigate the problem).

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]