[PATCH] Move notmuch-fcc-header-setup to message-header-setup-hook.

[PATCH] Move notmuch-fcc-header-setup to message-header-setup-hook.

[Rob Browning]

Here's a small patch to move notmuch-fcc-header-setup from
message-send-hook to message-header-setup-hook.  This is nice because
it allows you to see what's going to happen and make adjustments if
you like.

Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

[PATCH] Move notmuch-fcc-header-setup to message-header-setup-hook.

[Rob Browning]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]


Call notmuch-fcc-header-setup from message-header-setup-hook rather
than message-send-hook.  This allows you to see what's going to
happen, and to make manual adjustments if desired.  Gnus does
something similar.

Signed-off-by: Rob Browning <rlb@defaultvalue.org>
---
 emacs/notmuch-maildir-fcc.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Move-notmuch-fcc-header-setup-to-message-header-setu.patch --]
[-- Type: text/x-patch; name="0001-Move-notmuch-fcc-header-setup-to-message-header-setu.patch", Size: 590 bytes --]

diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index 8bb41a8..32e7d0d 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -67,7 +67,7 @@
           '(lambda (destdir)
              (notmuch-maildir-fcc-write-buffer-to-maildir destdir t)))
     ;;add a hook to actually insert the Fcc header when sending
-    (add-hook 'message-send-hook 'notmuch-fcc-header-setup))
+    (add-hook 'message-header-setup-hook 'notmuch-fcc-header-setup))
 
 (defun notmuch-fcc-header-setup ()
   "Adds an appropriate fcc header to the current mail buffer

Re: [PATCH] Move notmuch-fcc-header-setup to message-header-setup-hook.

[Jameson Rollins]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

On Sun, 12 Sep 2010 15:23:38 -0500, Rob Browning <rlb@defaultvalue.org> wrote:
> Call notmuch-fcc-header-setup from message-header-setup-hook rather
> than message-send-hook.  This allows you to see what's going to
> happen, and to make manual adjustments if desired.  Gnus does
> something similar.

I just tested this patch and it works as advertised.  The Fcc: field
appears, properly filled in, when the message buffer is initial created.

This will probably be good in conjunction with the patch to remove the
automatic Bcc:.

Signed-off-by: Jameson Rollins <jrollins@finestructure.net>

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] Move notmuch-fcc-header-setup to message-header-setup-hook.

[Sebastian Spaeth]

On 2010-09-12, Rob Browning wrote:
> 
> Call notmuch-fcc-header-setup from message-header-setup-hook rather
> than message-send-hook.  This allows you to see what's going to
> happen, and to make manual adjustments if desired.  Gnus does
> something similar.

I don't object to filling in the fcc stuff at a different point in time,
but personally, I don't want to see it in my outgoing mails (it is
always the same for me). So someone should make a decision on what we
want to show to the user and what not (and add fcc to the hidden headers
if we don't want to see it by default).

Sebastian

Re: [PATCH] Move notmuch-fcc-header-setup to message-header-setup-hook.

[Jameson Rollins]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On Tue, 14 Sep 2010 20:58:09 +0200, Sebastian Spaeth <Sebastian@SSpaeth.de> wrote:
> On 2010-09-12, Rob Browning wrote:
> > 
> > Call notmuch-fcc-header-setup from message-header-setup-hook rather
> > than message-send-hook.  This allows you to see what's going to
> > happen, and to make manual adjustments if desired.  Gnus does
> > something similar.
> 
> I don't object to filling in the fcc stuff at a different point in time,
> but personally, I don't want to see it in my outgoing mails (it is
> always the same for me). So someone should make a decision on what we
> want to show to the user and what not (and add fcc to the hidden headers
> if we don't want to see it by default).

I think if you don't want to see it you can just add it to
message-hidden-headers.  I don't see any problem with have it shown by
default.

Fcc is also automatically removed when the mail is actually sent.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

keybindings

[Daniel Goldin]

Non-programmer would like to simplify removing tags by using a single
key to remove the index label from messages when run in emacs. Is there
way to do this for this tag as well as other tags: I'm looking for
something similar to "d" key in sup.

-- 
Daniel Goldin
626.817.2462
www.danielgoldinpractice.com

Re: keybindings

[Jameson Rollins]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

On Tue, 14 Sep 2010 11:06:39 -0700, Daniel Goldin <danielgoldin@gmail.com> wrote:
> Non-programmer would like to simplify removing tags by using a single
> key to remove the index label from messages when run in emacs. Is there
> way to do this for this tag as well as other tags: I'm looking for
> something similar to "d" key in sup.

Hi, Daniel.  See the emacstips section of the wiki:

http://notmuchmail.org/emacstips/

specifically:

http://notmuchmail.org/emacstips/#custom_keybinding

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] Move notmuch-fcc-header-setup to message-header-setup-hook.

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

On Sun, 12 Sep 2010 15:23:37 -0500, Rob Browning <rlb@defaultvalue.org> wrote:
> Here's a small patch to move notmuch-fcc-header-setup from
> message-send-hook to message-header-setup-hook.  This is nice because
> it allows you to see what's going to happen and make adjustments if
> you like.

This is great. I do like the assurance of seeing the Fcc header there.

I've applied this patch now, (was only waiting for the recent work I
just completed to turn on Fcc by default and remove the Bcc from
"notmuch reply").

As mentioned before, anyone who doesn't want to see the Fcc header when
composing messages can set the message-hidden-headers variable.

It might also be nice for someone to add a notmuch-hidden-headers
variable. I think I'm inclined to allow people to customize the most
common settings within the notmuch customization, (without having to
hunt through message-mode customization as well).

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]