From: Felipe Contreras <felipe.contreras@gmail.com>
To: notmuch@notmuchmail.org
Cc: Bart Trojanowski <bart@jukie.net>
Subject: [PATCH 1/9] thread: really clean authors
Date: Sat, 5 Jun 2010 14:12:34 +0300 [thread overview]
Message-ID: <1275736362-22771-2-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1275736362-22771-1-git-send-email-felipe.contreras@gmail.com>
To show the thread, usually 'foo' is enough from "Foo Bar
<foo.bar@mail.com>", specially since the authors field is too small
anyway.
Gmail does something similar: "Foo (2), John (3)".
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
lib/thread.cc | 38 +++++---------------------------------
1 files changed, 5 insertions(+), 33 deletions(-)
diff --git a/lib/thread.cc b/lib/thread.cc
index 13872d4..6a445b5 100644
--- a/lib/thread.cc
+++ b/lib/thread.cc
@@ -151,44 +151,16 @@ char *
_thread_cleanup_author (notmuch_thread_t *thread,
const char *author, const char *from)
{
- char *clean_author,*test_author;
- const char *comma;
- char *blank;
- int fname,lname;
+ char *clean_author;
+ const char *begin,*end;
if (author == NULL)
return NULL;
- clean_author = talloc_strdup(thread, author);
+ begin = strchr (from, '<') + 1;
+ end = strchr (begin, '>');
+ clean_author = talloc_strndup (thread, begin, end - begin);
if (clean_author == NULL)
return NULL;
- /* check if there's a comma in the name and that there's a
- * component of the name behind it (so the name doesn't end with
- * the comma - in which case the string that strchr finds is just
- * one character long ",\0").
- * Otherwise just return the copy of the original author name that
- * we just made*/
- comma = strchr(author,',');
- if (comma && strlen(comma) > 1) {
- /* let's assemble what we think is the correct name */
- lname = comma - author;
- fname = strlen(author) - lname - 2;
- strncpy(clean_author, comma + 2, fname);
- *(clean_author+fname) = ' ';
- strncpy(clean_author + fname + 1, author, lname);
- *(clean_author+fname+1+lname) = '\0';
- /* make a temporary copy and see if it matches the email */
- test_author = talloc_strdup(thread,clean_author);
-
- blank=strchr(test_author,' ');
- while (blank != NULL) {
- *blank = '.';
- blank=strchr(test_author,' ');
- }
- if (strcasestr(from, test_author) == NULL)
- /* we didn't identify this as part of the email address
- * so let's punt and return the original author */
- strcpy (clean_author, author);
- }
return clean_author;
}
--
1.7.1
next prev parent reply other threads:[~2010-06-05 11:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 11:12 [PATCH 0/9] vim improvements Felipe Contreras
2010-06-05 11:12 ` Felipe Contreras [this message]
2010-06-05 11:12 ` [PATCH 2/9] vim: add archive support from 'show' Felipe Contreras
2010-06-05 11:12 ` [PATCH 3/9] vim: cleanup search buffer Felipe Contreras
2010-06-05 11:12 ` [PATCH 4/9] vim: cleanup search syntax Felipe Contreras
2010-06-05 11:12 ` [PATCH 5/9] vim: remove add_remove_tags_on_screen() Felipe Contreras
2010-06-05 11:12 ` [PATCH 6/9] vim: add option to mark as read + archive Felipe Contreras
2010-06-05 11:12 ` [PATCH 7/9] vim: use mailx for sending Felipe Contreras
2010-06-16 18:28 ` Felipe Contreras
2010-06-05 11:12 ` [PATCH 8/9] vim: run(): optimize non-debug path Felipe Contreras
2010-06-05 11:12 ` [PATCH 9/9] vim: include own improved git-diff syntax Felipe Contreras
2010-11-08 17:57 ` [PATCH 0/9] vim improvements Carl Worth
2010-11-08 18:04 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275736362-22771-2-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=bart@jukie.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).