[PATCH] json: Replace `date_unix' with `timestamp' in show output

[PATCH] json: Replace `date_unix' with `timestamp' in show output

[David Edmondson]

Search output was already using `timestamp' for a very similar field,
so follow that.
---
 notmuch-show.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/notmuch-show.c b/notmuch-show.c
index 76873a1..26449fa 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -145,7 +145,7 @@ format_message_json (const void *ctx, notmuch_message_t *message, unused (int in
     date = notmuch_message_get_date (message);
     relative_date = notmuch_time_relative_date (ctx, date);
 
-    printf ("\"id\": %s, \"match\": %s, \"filename\": %s, \"date_unix\": %ld, \"date_relative\": \"%s\", \"tags\": [",
+    printf ("\"id\": %s, \"match\": %s, \"filename\": %s, \"timestamp\": %ld, \"date_relative\": \"%s\", \"tags\": [",
 	    json_quote_str (ctx_quote, notmuch_message_get_message_id (message)),
 	    notmuch_message_get_flag (message, NOTMUCH_MESSAGE_FLAG_MATCH) ? "true" : "false",
 	    json_quote_str (ctx_quote, notmuch_message_get_filename (message)),
-- 
1.7.0

[PATCH] json: Replace `date_unix' with `timestamp' in show output

[David Edmondson]

Search output was already using `timestamp' for a very similar field,
so follow that.
---
 notmuch-show.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/notmuch-show.c b/notmuch-show.c
index 76873a1..26449fa 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -145,7 +145,7 @@ format_message_json (const void *ctx, notmuch_message_t *message, unused (int in
     date = notmuch_message_get_date (message);
     relative_date = notmuch_time_relative_date (ctx, date);
 
-    printf ("\"id\": %s, \"match\": %s, \"filename\": %s, \"date_unix\": %ld, \"date_relative\": \"%s\", \"tags\": [",
+    printf ("\"id\": %s, \"match\": %s, \"filename\": %s, \"timestamp\": %ld, \"date_relative\": \"%s\", \"tags\": [",
 	    json_quote_str (ctx_quote, notmuch_message_get_message_id (message)),
 	    notmuch_message_get_flag (message, NOTMUCH_MESSAGE_FLAG_MATCH) ? "true" : "false",
 	    json_quote_str (ctx_quote, notmuch_message_get_filename (message)),
-- 
1.7.0

Re: [PATCH] json: Replace `date_unix' with `timestamp' in show output

[David Edmondson]

On Fri, 16 Apr 2010 12:47:49 +0100, David Edmondson <dme@dme.org> wrote:
> Search output was already using `timestamp' for a very similar field,
> so follow that.

Carl, this seems low-risk and easy to include for 0.3.

dme.
-- 
David Edmondson, http://dme.org

Re: [PATCH] json: Replace `date_unix' with `timestamp' in show output

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

On Fri, 16 Apr 2010 12:47:49 +0100, David Edmondson <dme@dme.org> wrote:
> Search output was already using `timestamp' for a very similar field,
> so follow that.

Thanks. I've just pushed this. I didn't find any other occurrence of
date_unix in the notmuch repository (or else I would have updated them).

Do we have any external code that is interpreting JSON output from
notmuch? I think some web frontends do, for example. That code will need
to be updated. And I give my encouragement for the authors of such code
to consider contributing them to be maintained within the notmuch
repository itself.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]