* [PATCH] configure: Fix syntax error (spaces in assignment).
@ 2010-04-15 9:51 Gregor Hoffleit
2010-04-16 2:47 ` Carl Worth
0 siblings, 1 reply; 2+ messages in thread
From: Gregor Hoffleit @ 2010-04-15 9:51 UTC (permalink / raw
To: notmuch
Before and after the assignment operator, no spaces are allowed.
I don't know if there are any /bin/sh which allow spaces, but at least
in bash, csh and zsh, the former code was no valid assigment.
---
configure | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index eebe075..7f5ca7d 100755
--- a/configure
+++ b/configure
@@ -238,11 +238,11 @@ printf "Checking for Mac OS X (for shared library)... "
if [ `uname` = "Darwin" ] ; then
printf "Yes.\n"
mac_os_x=1
- linker_resolves_library_dependencies = 0
+ linker_resolves_library_dependencies=0
else
printf "No.\n"
mac_os_x=0
- linker_resolves_library_dependencies = 1
+ linker_resolves_library_dependencies=1
fi
if [ $errors -gt 0 ]; then
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configure: Fix syntax error (spaces in assignment).
2010-04-15 9:51 [PATCH] configure: Fix syntax error (spaces in assignment) Gregor Hoffleit
@ 2010-04-16 2:47 ` Carl Worth
0 siblings, 0 replies; 2+ messages in thread
From: Carl Worth @ 2010-04-16 2:47 UTC (permalink / raw
To: Gregor Hoffleit, notmuch
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
On Thu, 15 Apr 2010 11:51:47 +0200, Gregor Hoffleit <gregor@hoffleit.de> wrote:
> Before and after the assignment operator, no spaces are allowed.
> I don't know if there are any /bin/sh which allow spaces, but at least
> in bash, csh and zsh, the former code was no valid assigment.
Thanks, Gregor.
I went through all the work to try to make the over-linking conditional,
and then only tested carefully on OS X, (not noticing that I'd broken
the Linux case just as much as if I had accepted the unconditional
version).
This is pushed now.
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-16 2:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-15 9:51 [PATCH] configure: Fix syntax error (spaces in assignment) Gregor Hoffleit
2010-04-16 2:47 ` Carl Worth
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).