unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Michal Sojka <sojkam1@fel.cvut.cz>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/4] Mailstore abstraction v4
Date: Thu,  8 Apr 2010 16:42:42 +0200	[thread overview]
Message-ID: <1270737766-29237-1-git-send-email-sojkam1@fel.cvut.cz> (raw)

Hi all,

this is the fourth version of my mailstore abstraction series. I split
it into two parts, with the first part being sent here. I think that
this part becomes mostly ready for merging.

From the user's point of view, it adds only the 'cat' subcommand and
modifies the .el to use it. Thanks to this change it is easy to use
Emacs client with the database accessed remotely over SSH. The only
additional patch that must be applied is
id:m1my03gsmu.fsf@watt.gilman.jhu.edu. The rebased version is at
http://rtime.felk.cvut.cz/gitweb/notmuch.git/shortlog/refs/heads/jr/quote-args-in-notmuch-show
and can be pulled by 'git pull git://rtime.felk.cvut.cz/notmuch.git
jr/quote-args-in-notmuch-show').

More importantly, there are bigger changes for developers. Since it
might be quite painful to rebase these patches to quickly changing
master (as of the last few days) I'd like to have these merged ASAP.

So the patches here are the following:

Michal Sojka (4):
  Mailstore abstraction interface
  Conversion to mailstore abstraction
  Access messages through mail store interface
  Add 'cat' subcommand

My biggest question relates to the first patch, which does an
incompatible change to libnotmuch API. After reading RELEASING file, I
found that this change is probably not what Carl wants to merge (and I
understand that) so I'd like to get some feedback on my suggestion in
that patch.

The subsequent patches are quite straightforward and the comments
there should describe what these patches do.

These patches are also located at git://rtime.felk.cvut.cz/notmuch.git
and tagged by mailstore-abstraction-v4-part1.

This is the overall diffstat:
 NEWS                                   |    3 +
 emacs/notmuch-show.el                  |   11 +-
 lib/Makefile.local                     |    2 +
 lib/database-private.h                 |    1 +
 lib/database.cc                        |   29 +-
 lib/index.cc                           |    8 +-
 notmuch-new.c => lib/mailstore-files.c |  418 +++++----------------
 lib/mailstore-private.h                |   59 +++
 lib/mailstore.c                        |   80 ++++
 lib/message-file.c                     |    8 +-
 lib/message.cc                         |   46 ++-
 lib/notmuch-private.h                  |    6 +-
 lib/notmuch.h                          |   98 +++++-
 lib/sha1.c                             |    6 +-
 notmuch-client.h                       |   12 +-
 notmuch-config.c                       |   34 ++
 notmuch-count.c                        |    3 +-
 notmuch-dump.c                         |    3 +-
 notmuch-new.c                          |  658 +++-----------------------------
 notmuch-reply.c                        |   13 +-
 notmuch-restore.c                      |    3 +-
 notmuch-search-tags.c                  |    3 +-
 notmuch-search.c                       |    3 +-
 notmuch-show.c                         |   82 ++++-
 notmuch-tag.c                          |    3 +-
 notmuch.c                              |    4 +
 show-message.c                         |   14 +-
 27 files changed, 621 insertions(+), 989 deletions(-)
 copy notmuch-new.c => lib/mailstore-files.c (61%)
 create mode 100644 lib/mailstore-private.h
 create mode 100644 lib/mailstore.c

             reply	other threads:[~2010-04-08 14:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 14:42 Michal Sojka [this message]
2010-04-08 14:42 ` [PATCH 1/4] Mailstore abstraction interface Michal Sojka
2010-04-13 17:53   ` Carl Worth
2010-04-13 21:49     ` Stewart Smith
2010-04-14  8:50     ` Michal Sojka
2010-04-08 14:42 ` [PATCH 2/4] Conversion to mailstore abstraction Michal Sojka
2010-04-08 14:42 ` [PATCH 3/4] Access messages through mail store interface Michal Sojka
2010-04-08 14:42 ` [PATCH 4/4] Add 'cat' subcommand Michal Sojka
2010-04-13 18:43 ` [PATCH 0/4] Mailstore abstraction v4 Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270737766-29237-1-git-send-email-sojkam1@fel.cvut.cz \
    --to=sojkam1@fel.cvut.cz \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).