From: Geo Carncross <geocar-notmuch@internetconnection.net>
To: notmuch@notmuchmail.org
Subject: [PATCH] GCC3.5 fix
Date: Thu, 21 Jan 2010 15:31:44 -0500 [thread overview]
Message-ID: <1264105904.3941.121.camel@dwarf> (raw)
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
I have reason to need GCC 3.5 which doesn't process the unused(x) macro
correctly. This is probably a bug in 3.5, nevertheless the patch is
simple and corrects the build.
GCC 3.5 also does not understand -Wextra but Makefile is bound to change
less frequently, so I did not include a patch for that.
[-- Attachment #2: notmuch_gcc_35.patch --]
[-- Type: text/x-patch, Size: 951 bytes --]
diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
index c7fb0ef..ad6dcd8 100644
--- a/lib/notmuch-private.h
+++ b/lib/notmuch-private.h
@@ -74,7 +74,7 @@ _internal_error (const char *format, ...) PRINTF_ATTRIBUTE (1, 2);
_internal_error (format " (%s).\n", \
##__VA_ARGS__, __location__)
-#define unused(x) x __attribute__ ((unused))
+#define unused(x) x __attribute__((unused))
/* Thanks to Andrew Tridgell's (SAMBA's) talloc for this definition of
* unlikely. The talloc source code comes to us via the GNU LGPL v. 3.
diff --git a/notmuch-client.h b/notmuch-client.h
index 77766de..87e599a 100644
--- a/notmuch-client.h
+++ b/notmuch-client.h
@@ -49,7 +49,7 @@
#include <talloc.h>
-#define unused(x) x __attribute__ ((unused))
+#define unused(x) x __attribute__((unused))
/* There's no point in continuing when we've detected that we've done
* something wrong internally (as opposed to the user passing in a
reply other threads:[~2010-01-21 20:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264105904.3941.121.camel@dwarf \
--to=geocar-notmuch@internetconnection.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).