From: david@tethera.net
To: notmuch@notmuchmail.org
Cc: David Bremner <bremner@unb.ca>
Subject: [PATCH 1/3] rename option to select output format to --format from --output.
Date: Sat, 19 Dec 2009 10:55:22 -0400 [thread overview]
Message-ID: <1261234524-25522-2-git-send-email-david@tethera.net> (raw)
In-Reply-To: <1261234524-25522-1-git-send-email-david@tethera.net>
From: David Bremner <bremner@unb.ca>
---
notmuch-search.c | 6 +++---
notmuch-show.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/notmuch-search.c b/notmuch-search.c
index e243747..482c6e8 100644
--- a/notmuch-search.c
+++ b/notmuch-search.c
@@ -221,14 +221,14 @@ notmuch_search_command (void *ctx, int argc, char *argv[])
fprintf (stderr, "Invalid value for --sort: %s\n", opt);
return 1;
}
- } else if (STRNCMP_LITERAL (argv[i], "--output=") == 0) {
- opt = argv[i] + sizeof ("--output=") - 1;
+ } else if (STRNCMP_LITERAL (argv[i], "--format=") == 0) {
+ opt = argv[i] + sizeof ("--format=") - 1;
if (strcmp (opt, "text") == 0) {
format = &format_text;
} else if (strcmp (opt, "json") == 0) {
format = &format_json;
} else {
- fprintf (stderr, "Invalid value for --output: %s\n", opt);
+ fprintf (stderr, "Invalid value for --format: %s\n", opt);
return 1;
}
} else {
diff --git a/notmuch-show.c b/notmuch-show.c
index b5b3eba..b6e3f44 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -406,15 +406,15 @@ notmuch_show_command (void *ctx, unused (int argc), unused (char *argv[]))
i++;
break;
}
- if (STRNCMP_LITERAL (argv[i], "--output=") == 0) {
- opt = argv[i] + sizeof ("--output=") - 1;
+ if (STRNCMP_LITERAL (argv[i], "--format=") == 0) {
+ opt = argv[i] + sizeof ("--format=") - 1;
if (strcmp (opt, "text") == 0) {
format = &format_text;
} else if (strcmp (opt, "json") == 0) {
format = &format_json;
entire_thread = 1;
} else {
- fprintf (stderr, "Invalid value for --output: %s\n", opt);
+ fprintf (stderr, "Invalid value for --format: %s\n", opt);
return 1;
}
} else if (STRNCMP_LITERAL (argv[i], "--entire-thread") == 0) {
--
1.6.5.3
next prev parent reply other threads:[~2009-12-19 14:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 23:21 RFC: output json from notmuch? David Bremner
2009-12-13 23:26 ` David Bremner
2009-12-14 0:05 ` Scott Robinson
2009-12-14 0:42 ` David Bremner
2009-12-14 22:41 ` Carl Worth
2009-12-14 22:34 ` Carl Worth
2009-12-14 0:07 ` Marten Veldthuis
2009-12-14 22:30 ` Carl Worth
2009-12-14 23:10 ` David Bremner
2009-12-18 5:33 ` [PATCH] JSON output for notmuch-search and notmuch-show Scott Robinson
2009-12-18 12:59 ` [PATCH] Add an "--output=(json|text|)" command-line option to both " david
2009-12-18 17:33 ` Carl Worth
2009-12-18 18:45 ` Scott Robinson
2009-12-19 0:36 ` David Bremner
2009-12-23 5:58 ` Carl Worth
2009-12-19 14:55 ` Prototype of --show option to control what is shown david
2009-12-19 14:55 ` david [this message]
2009-12-19 14:55 ` [PATCH 2/3] notmuch-show.c: make calls to format functions conditional david
2009-12-19 14:55 ` [PATCH 3/3] notmuch-show.c: prototype tabular output format, with output control david
2010-03-09 19:51 ` Carl Worth
2010-03-09 20:19 ` David Bremner
2010-03-10 9:25 ` Carl Worth
2010-03-10 15:34 ` David Bremner
2009-12-20 20:31 ` [PATCH] notmuch-query.el: new file to support access to the notmuch database david
2009-12-21 17:21 ` Carl Worth
2009-12-21 18:01 ` David Bremner
2010-02-24 12:52 ` [PATCH v2] " david
2010-04-05 16:46 ` [PATCH v3] " david
2010-04-05 16:59 ` David Edmondson
2010-04-05 18:13 ` Carl Worth
2010-02-23 19:56 ` [PATCH] Add an "--output=(json|text|)" command-line option to both notmuch-search and notmuch-show Carl Worth
2010-02-23 21:00 ` JSON output as default [was: Re: [PATCH] Add an "--output=(json|text|)" command-line option...] Jameson Rollins
2010-02-23 23:35 ` Carl Worth
2010-02-24 13:54 ` Sebastian Spaeth
2009-12-18 17:31 ` [PATCH] JSON output for notmuch-search and notmuch-show Carl Worth
2009-12-18 18:47 ` Scott Robinson
2009-12-23 5:48 ` Carl Worth
2009-12-31 8:54 ` Scott Robinson
2009-12-31 12:49 ` David Bremner
2009-12-25 12:53 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261234524-25522-2-git-send-email-david@tethera.net \
--to=david@tethera.net \
--cc=bremner@unb.ca \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).