From: Ingmar Vanhassel <ingmar@exherbo.org>
To: notmuch <notmuch@notmuchmail.org>
Subject: Re: [patch] Trivial fix for non-root install
Date: Mon, 23 Nov 2009 16:41:23 +0100 [thread overview]
Message-ID: <1258990831-sup-2789@cannonball> (raw)
In-Reply-To: <46263c600911230731i529f2db5rec11bed02f84ef13@mail.gmail.com>
Excerpts from Brett Viren's message of Mon Nov 23 16:31:47 +0100 2009:
> Installing as a normal user fails because the bash completion config
> files try to install into /etc. This trivial patch fixes this.
NAK
Your patch breaks the more common case of installing as root user. It
now installs into /usr/etc where bash completions most likely won't be
found.
> diff --git a/Makefile.config b/Makefile.config
> index ddc7436..c04d57a 100644
> --- a/Makefile.config
> +++ b/Makefile.config
> @@ -1,3 +1,2 @@
> -prefix = /usr/local
> -bash_completion_dir = /etc/bash_completion.d
> +bash_completion_dir = $(prefix)/etc/bash_completion.d
> CFLAGS += -DHAVE_VALGRIND
>
>
> -Brett.
--
Exherbo KDE, X.org maintainer
next prev parent reply other threads:[~2009-11-23 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 15:31 [patch] Trivial fix for non-root install Brett Viren
2009-11-23 15:41 ` Ingmar Vanhassel [this message]
2009-11-23 15:45 ` Jameson Rollins
2009-12-01 18:18 ` Carl Worth
2009-11-23 18:21 ` Alec Berryman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258990831-sup-2789@cannonball \
--to=ingmar@exherbo.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).