From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6E5E3431FBC for ; Thu, 19 Nov 2009 03:11:14 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1t0SaCmcIKYE for ; Thu, 19 Nov 2009 03:11:10 -0800 (PST) Received: from bach.exherbo.org (bach.exherbo.org [78.47.197.147]) by olra.theworths.org (Postfix) with ESMTP id 88D4E431FAE for ; Thu, 19 Nov 2009 03:11:10 -0800 (PST) Received: from [83.101.72.69] (helo=localhost) by bach.exherbo.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1NB4ur-0006rh-J6 for notmuch@notmuchmail.org; Thu, 19 Nov 2009 11:11:09 +0000 Content-Type: text/plain; charset=utf8 From: Ingmar Vanhassel To: notmuch In-reply-to: <1258611530-20719-1-git-send-email-jeff@ocjtech.us> References: <1258611530-20719-1-git-send-email-jeff@ocjtech.us> Date: Thu, 19 Nov 2009 12:11:08 +0100 Message-Id: <1258628956-sup-8884@cannonball> User-Agent: Sup/git Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] notmuch: improve installation of emacs mode X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2009 11:11:14 -0000 Excerpts from Jeffrey C. Ollie's message of Thu Nov 19 07:18:50 +0100 2009: > 1) Don't hardcode the installation directory, instead use emacs' > pkg-config module. > > 2) Install a byte compiled version of the emacs mode. > > 3) Install the emacs mode in emacs' site-start directory so that it > gets loaded automatically. Your patch makes emacs required to do make install, which is a no-go imo. Notmuch can be used without emacs. Shouldn't installing the emac mode be a seperate target? -- Exherbo KDE, X.org maintainer