unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Ingmar Vanhassel <ingmar@exherbo.org>
To: notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] notmuch: improve installation of emacs mode
Date: Thu, 19 Nov 2009 12:11:08 +0100	[thread overview]
Message-ID: <1258628956-sup-8884@cannonball> (raw)
In-Reply-To: <1258611530-20719-1-git-send-email-jeff@ocjtech.us>

Excerpts from Jeffrey C. Ollie's message of Thu Nov 19 07:18:50 +0100 2009:
> 1) Don't hardcode the installation directory, instead use emacs'
>    pkg-config module.
> 
> 2) Install a byte compiled version of the emacs mode.
> 
> 3) Install the emacs mode in emacs' site-start directory so that it
>    gets loaded automatically.

Your patch makes emacs required to do make install, which is a no-go
imo. Notmuch can be used without emacs. Shouldn't installing the emac
mode be a seperate target?

-- 
Exherbo KDE, X.org maintainer

  reply	other threads:[~2009-11-19 11:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19  6:18 [PATCH] notmuch: improve installation of emacs mode Jeffrey C. Ollie
2009-11-19 11:11 ` Ingmar Vanhassel [this message]
2009-11-19 13:12   ` Jeffrey C. Ollie
2009-11-19 13:18     ` Ingmar Vanhassel
2009-11-19 14:27       ` Jeffrey C. Ollie
2009-11-19 19:32         ` Ingmar Vanhassel
2009-11-19 19:25 ` Keith Packard
2009-11-19 21:20   ` [PATCH 1/2] Improve " Jeffrey C. Ollie
2009-11-19 21:20     ` [PATCH 2/2] Add a .desktop file entry Jeffrey C. Ollie
2009-11-20  9:35     ` [PATCH 1/2] Improve installation of emacs mode Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258628956-sup-8884@cannonball \
    --to=ingmar@exherbo.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).