unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Keith Packard <keithp@keithp.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] Filter out carriage-returns in show and reply output.
Date: Wed, 18 Nov 2009 11:56:13 -0800	[thread overview]
Message-ID: <1258574173-19911-1-git-send-email-keithp@keithp.com> (raw)

Thanks, windows mail clients.

Signed-off-by: Keith Packard <keithp@keithp.com>
---
 gmime-filter-reply.c |    7 ++++---
 notmuch-show.c       |   21 +++++++++++++++------
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/gmime-filter-reply.c b/gmime-filter-reply.c
index 3e298e1..b269db4 100644
--- a/gmime-filter-reply.c
+++ b/gmime-filter-reply.c
@@ -130,8 +130,9 @@ filter_filter (GMimeFilter *filter, char *inbuf, size_t inlen, size_t prespace,
 				reply->saw_nl = TRUE;
 			else
 				reply->saw_nl = FALSE;
-
-			*outptr++ = *inptr++;
+			if (*inptr != '\r')
+				*outptr++ = *inptr;
+			inptr++;
 		}
 	} else {
 		g_mime_filter_set_size (filter, inlen + 1, FALSE);
@@ -150,7 +151,7 @@ filter_filter (GMimeFilter *filter, char *inbuf, size_t inlen, size_t prespace,
 				else
 					*outptr++ = *inptr;
 				reply->saw_angle = FALSE;
-			} else {
+			} else if (*inptr != '\r') {
 				if (*inptr == '\n')
 					reply->saw_nl = TRUE;
 				*outptr++ = *inptr;
diff --git a/notmuch-show.c b/notmuch-show.c
index 7749dbc..4c377e1 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -99,14 +99,23 @@ show_part (GMimeObject *part, int *part_count)
     if (g_mime_content_type_is_type (content_type, "text", "*") &&
 	!g_mime_content_type_is_type (content_type, "text", "html"))
     {
-	GMimeStream *stream = g_mime_stream_file_new (stdout);
-	g_mime_stream_file_set_owner (GMIME_STREAM_FILE (stream), FALSE);
+	GMimeStream *stream_stdout = g_mime_stream_file_new (stdout);
+	GMimeStream *stream_filter = NULL;
+	
+	if (stream_stdout) {
+	    g_mime_stream_file_set_owner (GMIME_STREAM_FILE (stream_stdout), FALSE);
+	    stream_filter = g_mime_stream_filter_new(stream_stdout);
+	    g_mime_stream_filter_add(GMIME_STREAM_FILTER(stream_filter),
+				     g_mime_filter_crlf_new(FALSE, FALSE));
+	}
 
 	wrapper = g_mime_part_get_content_object (GMIME_PART (part));
-	if (wrapper && stream)
-	    g_mime_data_wrapper_write_to_stream (wrapper, stream);
-	if (stream)
-	    g_object_unref(stream);
+	if (wrapper && stream_filter)
+	    g_mime_data_wrapper_write_to_stream (wrapper, stream_filter);
+	if (stream_filter)
+	    g_object_unref(stream_filter);
+	if (stream_stdout)
+	    g_object_unref(stream_stdout);
     }
     else
     {
-- 
1.6.5.2

             reply	other threads:[~2009-11-18 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18 19:56 Keith Packard [this message]
2009-11-19  0:31 ` [PATCH] Filter out carriage-returns in show and reply output Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258574173-19911-1-git-send-email-keithp@keithp.com \
    --to=keithp@keithp.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).