* [PATCH] Older versions of install do not support -C.
@ 2009-11-17 22:18 Jan Janak
2009-11-18 10:43 ` Carl Worth
0 siblings, 1 reply; 2+ messages in thread
From: Jan Janak @ 2009-11-17 22:18 UTC (permalink / raw)
To: notmuch
Do not use -C cmdline option of install, older versions, commonly found in
distributions like Debian, do not seem to support it. Running make install
on such systems (tested on Debian Lenny) fails.
Signed-off-by: Jan Janak <jan@ryngle.com>
---
Makefile.local | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Makefile.local b/Makefile.local
index f824bed..f51f1d1 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -27,11 +27,11 @@ install: all notmuch.1.gz
for d in $(DESTDIR)$(prefix)/bin/ $(DESTDIR)$(prefix)/share/man/man1 \
$(DESTDIR)/etc/bash_completion.d/ ; \
do \
- install -C -d $$d ; \
+ install -d $$d ; \
done ;
- install -C notmuch $(DESTDIR)$(prefix)/bin/
- install -C -m0644 notmuch.1.gz $(DESTDIR)$(prefix)/share/man/man1/
- install -C notmuch-completion.bash \
+ install notmuch $(DESTDIR)$(prefix)/bin/
+ install -m0644 notmuch.1.gz $(DESTDIR)$(prefix)/share/man/man1/
+ install notmuch-completion.bash \
$(DESTDIR)/etc/bash_completion.d/notmuch
SRCS := $(SRCS) $(notmuch_client_srcs)
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Older versions of install do not support -C.
2009-11-17 22:18 [PATCH] Older versions of install do not support -C Jan Janak
@ 2009-11-18 10:43 ` Carl Worth
0 siblings, 0 replies; 2+ messages in thread
From: Carl Worth @ 2009-11-18 10:43 UTC (permalink / raw)
To: Jan Janak, notmuch
On Tue, 17 Nov 2009 23:18:47 +0100, Jan Janak <jan@ryngle.com> wrote:
> Do not use -C cmdline option of install, older versions, commonly found in
> distributions like Debian, do not seem to support it. Running make install
> on such systems (tested on Debian Lenny) fails.
>
> Signed-off-by: Jan Janak <jan@ryngle.com>
Thanks, Jan. This is pushed now.
And did I say welcome to notmuch yet? (It's easy to lose track with all
the newcomers---which I'm not complaining about---especially since so
many are sharing code.)
-Carl
PS. I actually really like the behavior of -C (especially when
installing a low-level library to avoid big waterfalls of needless
recompiles). But since we're *not* actually installing a library (yet)
I'm happy with this patch rather than writing code in configure to check
if "install -C" works or not.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-18 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-17 22:18 [PATCH] Older versions of install do not support -C Jan Janak
2009-11-18 10:43 ` Carl Worth
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).