unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Blake Jones <blakej@foo.net>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 00/10] Solaris support 
Date: Mon, 05 Nov 2012 10:36:08 -0800	[thread overview]
Message-ID: <10909.1352140568@foo.net> (raw)
In-Reply-To: Your message of "Mon, 05 Nov 2012 19:43:08 +0200." <m2fw4oeyj7.fsf@guru.guru-group.fi>

> Just now I don't have more time to comment and review more, but in the
> first 2/3 patches when I tried to compile I got problem NULL not
> defined.

Oh!  Yes, I should include <stdio.h> to pull in the definition of NULL.
I'll fix that.

> Another thing: you have this
> 
>  +# Whether the asctime_r function is standards-compliant
>  +# (if not, then notmuch will compile with -D_POSIX_PTHREAD_SEMANTICS
>  +# to enable the standards-compliant version -- needed for Solaris)
> 
> which is not exactly so.. you added the following lines in compat.h
> 
>  +#if !STD_GETPWUID
>  +#define _POSIX_PTHREAD_SEMANTICS
>  +#endif
> 
> which is slightly different as -D_POSIX_PTHREAD_SEMANTICS is equivalent to 
> #define _POSIX_PTHREAD_SEMANTICS 1
> 
> (you probably knew this and your comments have drifted from actual
> implementation but just to make sure)

I'll make the code and comment line up better.

Thanks for your comments.

Blake

       reply	other threads:[~2012-11-05 18:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m2fw4oeyj7.fsf@guru.guru-group.fi>
2012-11-05 18:36 ` Blake Jones [this message]
2012-11-04  3:15 [PATCH 00/10] Solaris support Blake Jones
2012-11-04 21:35 ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10909.1352140568@foo.net \
    --to=blakej@foo.net \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).