unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Cc: jani@nikula.org, David Bremner <david@tethera.net>,
	Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Subject: [PATCH v2 03/15] test: add boolean argument to arg-test
Date: Sun,  1 Oct 2017 23:53:12 +0300	[thread overview]
Message-ID: <0dd6fe2caf3d4f72f79eb2b1ad675291489c415d.1506890421.git.jani@nikula.org> (raw)
In-Reply-To: <cover.1506890421.git.jani@nikula.org>
In-Reply-To: <cover.1506890421.git.jani@nikula.org>

Surprisingly it's not there.
---
 test/T410-argument-parsing.sh | 3 ++-
 test/arg-test.c               | 5 +++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/test/T410-argument-parsing.sh b/test/T410-argument-parsing.sh
index fad134e305c5..4505c58301ea 100755
--- a/test/T410-argument-parsing.sh
+++ b/test/T410-argument-parsing.sh
@@ -3,8 +3,9 @@ test_description="argument parsing"
 . ./test-lib.sh || exit 1
 
 test_begin_subtest "sanity check"
-$TEST_DIRECTORY/arg-test  pos1  --keyword=one --string=foo pos2 --int=7 --flag=one --flag=three > OUTPUT
+$TEST_DIRECTORY/arg-test  pos1  --keyword=one --boolean --string=foo pos2 --int=7 --flag=one --flag=three > OUTPUT
 cat <<EOF > EXPECTED
+boolean 1
 keyword 1
 flags 5
 int 7
diff --git a/test/arg-test.c b/test/arg-test.c
index 10dc06834513..9d13618bd17c 100644
--- a/test/arg-test.c
+++ b/test/arg-test.c
@@ -12,8 +12,10 @@ int main(int argc, char **argv){
     const char *pos_arg1=NULL;
     const char *pos_arg2=NULL;
     const char *string_val=NULL;
+    notmuch_bool_t bool_val = FALSE;
 
     notmuch_opt_desc_t options[] = {
+	{ .opt_bool = &bool_val, .name = "boolean" },
 	{ .opt_keyword = &kw_val, .name = "keyword", .keywords =
 	  (notmuch_keyword_t []){ { "one", 1 },
 				  { "two", 2 },
@@ -35,6 +37,9 @@ int main(int argc, char **argv){
     if (opt_index < 0)
 	return 1;
 
+    if (bool_val)
+	printf("boolean %d\n", bool_val);
+
     if (kw_val)
 	printf("keyword %d\n", kw_val);
 
-- 
2.11.0

  parent reply	other threads:[~2017-10-01 20:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-01 20:53 [PATCH v2 00/15] cli: argument parsing changes Jani Nikula
2017-10-01 20:53 ` [PATCH v2 01/15] cli: strip trailing "/" from the final maildir path in notmuch insert Jani Nikula
2017-10-01 20:53 ` [PATCH v2 02/15] cli: use designated initializers for opt desc Jani Nikula
2017-10-01 20:53 ` Jani Nikula [this message]
2017-10-01 20:53 ` [PATCH v2 04/15] test: add opt_inherit to arg-test Jani Nikula
2017-10-01 20:53 ` [PATCH v2 05/15] cli: add .present field to opt desc to check if the arg was present Jani Nikula
2017-10-01 20:53 ` [PATCH v2 06/15] test: expand argument parsing tests Jani Nikula
2017-10-01 20:53 ` [PATCH v2 07/15] cli: use the arg parser .present feature to handle show --entire-thread Jani Nikula
2017-10-01 20:53 ` [PATCH v2 08/15] hex-xcode: use notmuch_bool_t for boolean arguments Jani Nikula
2017-10-01 20:53 ` [PATCH v2 09/15] cli: use notmuch_bool_t for boolean argument in show Jani Nikula
2017-10-01 20:53 ` [PATCH v2 10/15] cli: refactor boolean argument processing Jani Nikula
2017-10-01 20:53 ` [PATCH v2 11/15] cli: change while to for in keyword " Jani Nikula
2017-10-01 20:53 ` [PATCH v2 12/15] cli: reduce indent " Jani Nikula
2017-10-02  0:33   ` David Bremner
2017-10-05 10:43     ` David Bremner
2017-10-01 20:53 ` [PATCH v2 13/15] cli: add support for --no- prefixed boolean and keyword flag arguments Jani Nikula
2017-10-01 21:08   ` William Casarin
2017-10-02 15:52     ` Jani Nikula
2017-10-01 20:53 ` [PATCH v2 14/15] cli: use the negating boolean support for new and insert --no-hooks Jani Nikula
2017-10-01 20:53 ` [PATCH v2 15/15] test: expand argument parsing sanity checks Jani Nikula
2017-10-02 16:25 ` [PATCH] cli: allow empty strings for notmuch insert --folder argument Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dd6fe2caf3d4f72f79eb2b1ad675291489c415d.1506890421.git.jani@nikula.org \
    --to=jani@nikula.org \
    --cc=david@tethera.net \
    --cc=dkg@fifthhorseman.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).