From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH 4/9] cli/show: use a table for choosing the formatter
Date: Fri, 6 Jan 2017 22:14:45 +0200 [thread overview]
Message-ID: <05947448b61690904fc488546a76ce31c539a0eb.1483733461.git.jani@nikula.org> (raw)
In-Reply-To: <cover.1483733461.git.jani@nikula.org>
In-Reply-To: <cover.1483733461.git.jani@nikula.org>
Continue detangling format pointer and format selection variables. No
functional changes.
---
notmuch-show.c | 36 +++++++++++++++---------------------
1 file changed, 15 insertions(+), 21 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index b8e45f187360..93b51008381c 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -978,6 +978,14 @@ enum {
NOTMUCH_FORMAT_RAW
};
+static const notmuch_show_format_t *formatters[] = {
+ [NOTMUCH_FORMAT_JSON] = &format_json,
+ [NOTMUCH_FORMAT_SEXP] = &format_sexp,
+ [NOTMUCH_FORMAT_TEXT] = &format_text,
+ [NOTMUCH_FORMAT_MBOX] = &format_mbox,
+ [NOTMUCH_FORMAT_RAW] = &format_raw,
+};
+
enum {
ENTIRE_THREAD_DEFAULT,
ENTIRE_THREAD_TRUE,
@@ -997,7 +1005,7 @@ notmuch_show_command (notmuch_config_t *config, int argc, char *argv[])
notmuch_query_t *query;
char *query_string;
int opt_index, ret;
- const notmuch_show_format_t *format = &format_text;
+ const notmuch_show_format_t *formatter;
sprinter_t *sprinter;
notmuch_show_params_t params = {
.part = -1,
@@ -1063,29 +1071,14 @@ notmuch_show_command (notmuch_config_t *config, int argc, char *argv[])
format_sel = NOTMUCH_FORMAT_TEXT;
}
- switch (format_sel) {
- case NOTMUCH_FORMAT_JSON:
- format = &format_json;
- break;
- case NOTMUCH_FORMAT_TEXT:
- format = &format_text;
- break;
- case NOTMUCH_FORMAT_SEXP:
- format = &format_sexp;
- break;
- case NOTMUCH_FORMAT_MBOX:
+ if (format_sel == NOTMUCH_FORMAT_MBOX) {
if (params.part > 0) {
fprintf (stderr, "Error: specifying parts is incompatible with mbox output format.\n");
return EXIT_FAILURE;
}
-
- format = &format_mbox;
- break;
- case NOTMUCH_FORMAT_RAW:
- format = &format_raw;
+ } else if (format_sel == NOTMUCH_FORMAT_RAW) {
/* raw format only supports single message display */
single_message = TRUE;
- break;
}
notmuch_exit_if_unsupported_format ();
@@ -1148,11 +1141,12 @@ notmuch_show_command (notmuch_config_t *config, int argc, char *argv[])
}
/* Create structure printer. */
- sprinter = format->new_sprinter(config, stdout);
+ formatter = formatters[format_sel];
+ sprinter = formatter->new_sprinter(config, stdout);
/* If a single message is requested we do not use search_excludes. */
if (single_message) {
- ret = do_show_single (config, query, format, sprinter, ¶ms);
+ ret = do_show_single (config, query, formatter, sprinter, ¶ms);
} else {
/* We always apply set the exclude flag. The
* exclude=true|false option controls whether or not we return
@@ -1171,7 +1165,7 @@ notmuch_show_command (notmuch_config_t *config, int argc, char *argv[])
params.omit_excluded = FALSE;
}
- ret = do_show (config, query, format, sprinter, ¶ms);
+ ret = do_show (config, query, formatter, sprinter, ¶ms);
}
notmuch_crypto_cleanup (¶ms.crypto);
--
2.11.0
next prev parent reply other threads:[~2017-01-06 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 20:14 [PATCH 0/9] cli/show: refactoring and cleanup Jani Nikula
2017-01-06 20:14 ` [PATCH 1/9] cli/show: detangle overloading of params.part for single message display Jani Nikula
2017-03-11 14:06 ` David Bremner
2017-01-06 20:14 ` [PATCH 2/9] cli/show: remove unused raw member from show parameters struct Jani Nikula
2017-01-06 20:14 ` [PATCH 3/9] cli/show: consistently use format_sel for checking the format Jani Nikula
2017-01-06 20:14 ` Jani Nikula [this message]
2017-01-06 20:14 ` [PATCH 5/9] cli/show: rename format_sel to simply format Jani Nikula
2017-01-06 20:14 ` [PATCH 6/9] cli/show: group --entire-thread option handling into one place Jani Nikula
2017-01-06 20:14 ` [PATCH 7/9] cli/show: move formatter structs closer to where they're needed Jani Nikula
2017-01-06 20:14 ` [PATCH 8/9] cli: simplify mime node walk Jani Nikula
2017-01-06 20:14 ` [PATCH 9/9] cli: do not initialize zero values with designated initializers Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05947448b61690904fc488546a76ce31c539a0eb.1483733461.git.jani@nikula.org \
--to=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).