From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 82F04431FAF for ; Sun, 27 Jan 2013 14:05:57 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.001 X-Spam-Level: X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 tests=[HTML_MESSAGE=0.001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bY-rABGG9T2R for ; Sun, 27 Jan 2013 14:05:53 -0800 (PST) X-Greylist: delayed 402 seconds by postgrey-1.32 at olra; Sun, 27 Jan 2013 14:05:53 PST Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7490D431FAE for ; Sun, 27 Jan 2013 14:05:53 -0800 (PST) Received: (qmail 23786 invoked from network); 27 Jan 2013 22:59:09 +0100 Received: from ip73-109-210-87.adsl2.static.versatel.nl (HELO PCvangebruike) (87.210.109.73) by srv047132.webreus.nl with SMTP; 27 Jan 2013 22:59:07 +0100 From: "Robert Mast" To: Subject: Reply all - issue Date: Sun, 27 Jan 2013 22:58:58 +0100 Message-ID: <000001cdfcd9$82500f00$86f02d00$@nl> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0001_01CDFCE1.E4147700" X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac382YIPcFbBRELZQDerBAwMXRgaKA== Content-Language: nl X-Mailman-Approved-At: Sun, 27 Jan 2013 23:36:54 -0800 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jan 2013 22:05:57 -0000 This is a multi-part message in MIME format. ------=_NextPart_000_0001_01CDFCE1.E4147700 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Last week I studied many Windows-Mail User Agents with the conversation threading feature. None of them (SUP, mutt-kz(notmuch), Outlook 2010, Thunderbird with conversation thread plug in, Postbox, Evolution) could cope with the following case: In our e-mail-discussions people often choose 'reply-all' to construct a new message with the same reciepients. They clear the body and the subject, but the hidden References: and In-reply-To: stay and should be cleared as well. Result is that this new subject drowns in an old conversation-thread-drilldown and this unpredictable behavior makes conversation threading useless. This weekend I went analyzing the notmuch-source to find where I could put a fix best. I think of a fix that indexes the first dates of (stripped) subject-changes within threads, and with each first (stripped) subject change check the body on quotes of previous messages. If there is no quote to referenced mails then drop the reference and assign a new thread_id_ to the (stripped) subject. After two days of studying I think the best place with the least interference with existing code is between 'notmuch new' and starting the MUA. Then the threads are in place in XAPIAN, and new thread_id_'s can be inserted. Am I right? ------=_NextPart_000_0001_01CDFCE1.E4147700 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Last week I studied many Windows-Mail User Agents with the = conversation threading feature.

None of them (SUP, = mutt-kz(notmuch), Outlook 2010, Thunderbird with conversation thread = plug in, Postbox, Evolution) could cope with the following = case:

 

In our e-mail-discussions people often choose = ‘reply-all’ to construct a new message with the same = reciepients.

They clear the body and the subject, but the hidden = References: and In-reply-To: stay and should be cleared as = well.

Result is that this new subject drowns in an old = conversation-thread-drilldown and this unpredictable behavior makes = conversation threading useless.

This weekend I went analyzing the = notmuch-source to find where I could put a fix = best.

 

I think of a fix that indexes the first dates of (stripped) = subject-changes within threads, and with each first (stripped) subject = change check the body on quotes of previous messages. If there is no = quote to referenced mails then drop the reference and assign a new = thread_id_ to the (stripped) subject.

 

After two days of studying I think = the best place with the least interference with existing code is between = ‘notmuch new’ and starting the MUA. Then the threads are in = place in XAPIAN, and new thread_id_’s can be = inserted.

 

Am I right?

 

------=_NextPart_000_0001_01CDFCE1.E4147700-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C8917431FAF for ; Mon, 28 Jan 2013 07:13:33 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wCkzBoGJO-Dn for ; Mon, 28 Jan 2013 07:13:33 -0800 (PST) Received: from mail-bk0-f44.google.com (mail-bk0-f44.google.com [209.85.214.44]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C3DD8431FAE for ; Mon, 28 Jan 2013 07:13:32 -0800 (PST) Received: by mail-bk0-f44.google.com with SMTP id j4so1402833bkw.17 for ; Mon, 28 Jan 2013 07:13:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type:x-gm-message-state; bh=Zd8xAeNCq1DsVm+H8MPBCA1HQCjWmF9AF33ZVEdpQbk=; b=jBb9oQLYjn8hI4xYSrh0ZtYrg0CuICYpkryiPTBcxqJsyjkk2RjO0bT7CFdlvRcT9P niqnQyz+7zpJR91cxnhK+oVC98zPMHwSbt99NBqDT9hYmsVD744zGYGK5lnvFgM2JJ4n KBRYRzHL+QeBWSzhp6KAr4VxY5foGX+5csSajBK5paxljETN8AWI2EaR7yCJb3z6NYPt VAxReVDiwZW3qeTSfkyrLbaMMcusyTYJfZ/8fvjkIpwJm+8Z7rtCS+V+jCP3FW80raZb fUDXOVrmWKOvUKfq6qjvKmepcafXOlGny/SgBsBhRedfSXjKR38UWgSmPCIOJuVCTxjs mYKw== X-Received: by 10.204.13.25 with SMTP id z25mr505432bkz.114.1359386008694; Mon, 28 Jan 2013 07:13:28 -0800 (PST) Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) by mx.google.com with ESMTPS id fs20sm4075475bkc.8.2013.01.28.07.13.26 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Mon, 28 Jan 2013 07:13:27 -0800 (PST) From: Jani Nikula To: Robert Mast , notmuch@notmuchmail.org Subject: Re: Reply all - issue In-Reply-To: <000001cdfcd9$82500f00$86f02d00$@nl> References: <000001cdfcd9$82500f00$86f02d00$@nl> User-Agent: Notmuch/0.14+259~gdee88db (http://notmuchmail.org) Emacs/23.2.1 (x86_64-pc-linux-gnu) Date: Mon, 28 Jan 2013 16:13:19 +0100 Message-ID: <87wquxjq7k.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Gm-Message-State: ALoCoQnuswafvHmLQkGJxLiy77Ick30gH97f9KxVgnporeWA6hQINQ1scazh6XbO3IW0ApuHXOWD X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2013 15:13:33 -0000 On Sun, 27 Jan 2013, Robert Mast wrote: > Last week I studied many Windows-Mail User Agents with the conversation > threading feature. > > None of them (SUP, mutt-kz(notmuch), Outlook 2010, Thunderbird with > conversation thread plug in, Postbox, Evolution) could cope with the > following case: Apparently all of them obey the RFC 2822 References: and In-Reply-To: headers for threading, and have no additional heuristics. I think it's a good thing, but YMMV. I think mutt supports manual breaking and joining of threads. The gmail web interface, OTOH, automatically breaks threads on Subject: changes too [1]. > In our e-mail-discussions people often choose 'reply-all' to construct a new > message with the same reciepients. > > They clear the body and the subject, but the hidden References: and > In-reply-To: stay and should be cleared as well. > > Result is that this new subject drowns in an old > conversation-thread-drilldown and this unpredictable behavior makes > conversation threading useless. The term you're looking for is thread hijacking. One could argue the problem lies in the sender, not the recipient, and therefore should be fixed in the sender end. > I think of a fix that indexes the first dates of (stripped) subject-changes > within threads, and with each first (stripped) subject change check the body > on quotes of previous messages. If there is no quote to referenced mails > then drop the reference and assign a new thread_id_ to the (stripped) > subject. Doing something like this would break threading for emailed patch series [2], a very common practice in the open source world, including notmuch development [3]. Indeed, the way gmail breaks patch threads, but then joins different versions of the same patch email into new threads, is very annoying IMO. Also note that whatever you do, it should work the same way regardless of the order in which messages the thread are indexed. Regenerating the database should always end up in the same thread structure. > After two days of studying I think the best place with the least > interference with existing code is between 'notmuch new' and starting the > MUA. Then the threads are in place in XAPIAN, and new thread_id_'s can be > inserted. The place you're looking for is probably _notmuch_database_link_message() in lib/database.cc. Patches, as they say, are welcome, but I believe for upstream notmuch inclusion you'd need to address the issues I pointed out above. HTH, Jani. [1] http://support.google.com/mail/bin/answer.py?hl=en&answer=5900 [2] http://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project#Public-Large-Project [3] http://notmuchmail.org/pipermail/notmuch/2013/thread.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D44BB431FB6 for ; Mon, 28 Jan 2013 10:16:03 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3ONViV9yISjS for ; Mon, 28 Jan 2013 10:15:59 -0800 (PST) Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id F2033431FAE for ; Mon, 28 Jan 2013 10:15:58 -0800 (PST) Received: (qmail 21730 invoked from network); 28 Jan 2013 19:15:57 +0100 Received: from 87-251-48-4.lombox.customer.bit.nl (HELO WBNL79005) (87.251.48.4) by srv047132.webreus.nl with SMTP; 28 Jan 2013 19:15:57 +0100 From: "Robert Mast" To: "'Jani Nikula'" , References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> In-Reply-To: <87wquxjq7k.fsf@nikula.org> Subject: RE: Reply all - issue Date: Mon, 28 Jan 2013 19:15:55 +0100 Message-ID: <002601cdfd83$83b283f0$8b178bd0$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac39agg6riWfWJCKSlivo9D6sTE32AAFOTnA Content-Language: nl X-Mailman-Approved-At: Mon, 28 Jan 2013 18:19:02 -0800 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2013 18:16:04 -0000 Thanks for your reply. I never tried gmail-conversation threading, but from your first reference I understand it breaks threads on subject unconditionally. Breaking on subject unconditionally would be even easier to implement, as comparing the contents of previous messages takes performance and as long as the crucial linking messages aren't read the outcome is ambiguous and would lead to the annoying jumping of results. I'll watch for 'client-end' solutions, but the mail that broke all those mailers originated from my own mailprogram, I think Outlook 2010, so automatic clearing references and in-reply-to when the user clears the subject and body isn't common practice for MUA's. Your point on patch-breaking related to gmail and my proposal isn't completely clear to me, but I've probably addressed it well with my new approach. I'll study the code for adding the option of unconditional (stripped) subject breaking on top of the existing thread-breaking. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0B352431FB6 for ; Mon, 28 Jan 2013 18:44:54 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZuQYcSllI8Iv for ; Mon, 28 Jan 2013 18:44:53 -0800 (PST) Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 5DC2A431FAE for ; Mon, 28 Jan 2013 18:44:53 -0800 (PST) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id EF01C29A063; Mon, 28 Jan 2013 18:44:51 -0800 (PST) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id C700A67855; Mon, 28 Jan 2013 18:47:33 -0800 (PST) From: Carl Worth To: Robert Mast , 'Jani Nikula' , notmuch@notmuchmail.org Subject: RE: Reply all - issue In-Reply-To: <002601cdfd83$83b283f0$8b178bd0$@nl> References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> User-Agent: Notmuch/0.13.1 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Tue, 29 Jan 2013 13:47:33 +1100 Message-ID: <87boc8bt8a.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2013 02:44:54 -0000 --=-=-= Robert Mast writes: > Your point on patch-breaking related to gmail and my proposal isn't > completely clear to me, but I've probably addressed it well with my new > approach. The issue here is that many developers tend to develop a patch series (perhaps with dozens of patches) as a single conceptual unit. When these are emailed out, they are often sent as one thread with a new subject for every patch. In particular, users of git and "git send-email" often send patches this way. For what it's worth, it's my preferred way to send and receive patches via email. It's extremely useful for messages like this to be presented as a single thread. This means that the dozens of messages don't clutter the inbox, and it also allows for an operation to act on all of the messages at once, (for example, notmuch provides "C-u |" which can apply all of the received patches to a code repository in a single operation). So, those of us accustomed to sending, receiving, reviewing, and applying patches emailed in this way would be basically unable to use an email program that split threads unconditionally on subject changes. So it may be tricky to find a single behavior that would make everyone happy. Perhaps a configuration option for splitting threads on subject changes. > I'll study the code for adding the option of unconditional (stripped) > subject breaking on top of the existing thread-breaking. Is there any existing thread-breaking? There wasn't the last time I looked at the code closely, (but admittedly, that was a while ago). -Carl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlEHOEUACgkQ6JDdNq8qSWgLlgCffo6q71opXZZ8zt3iCRQPQhIW 9KMAmQGmrC8Y7y8WPbD29mBlpKVj3lkb =d9g7 -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2411C431FCB for ; Wed, 30 Jan 2013 09:15:09 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k+ZOLhvyIx52 for ; Wed, 30 Jan 2013 09:15:05 -0800 (PST) Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B6A54431FAE for ; Wed, 30 Jan 2013 09:15:04 -0800 (PST) Received: (qmail 19748 invoked from network); 30 Jan 2013 18:15:01 +0100 Received: from ip73-109-210-87.adsl2.static.versatel.nl (HELO PCvangebruike) (87.210.109.73) by srv047132.webreus.nl with SMTP; 30 Jan 2013 18:15:01 +0100 From: "Robert Mast" To: "'Carl Worth'" , "'Jani Nikula'" , References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> <87boc8bt8a.fsf@yoom.home.cworth.org> In-Reply-To: <87boc8bt8a.fsf@yoom.home.cworth.org> Subject: RE: Reply all - issue Date: Wed, 30 Jan 2013 18:14:48 +0100 Message-ID: <00bf01cdff0d$4ecedd10$ec6c9730$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac39yr2ciHq/BzOAQieJla7aevASjQBP0GPg Content-Language: nl X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2013 17:15:09 -0000 Thanks for your clear explanation. The thread-merging and breaking is in the procedure already pointed at by Jani: (_notmuch_database_link_message() in lib/database.cc.) Is there a quick way to recognize those git-threads by subject-syntax, or to reliably tag them to exclude them from subject-breaking? -----Oorspronkelijk bericht----- Van: Carl Worth [mailto:cworth@cworth.org] Verzonden: dinsdag 29 januari 2013 3:48 Aan: Robert Mast; 'Jani Nikula'; notmuch@notmuchmail.org Onderwerp: RE: Reply all - issue Is there any existing thread-breaking? There wasn't the last time I looked at the code closely, (but admittedly, that was a while ago). -Carl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5077D431FC0 for ; Wed, 30 Jan 2013 12:57:18 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3aMP9Zlm4Eko for ; Wed, 30 Jan 2013 12:57:15 -0800 (PST) Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 6DB81431FAE for ; Wed, 30 Jan 2013 12:57:15 -0800 (PST) Received: (qmail 26515 invoked from network); 30 Jan 2013 21:57:12 +0100 Received: from ip73-109-210-87.adsl2.static.versatel.nl (HELO PCvangebruike) (87.210.109.73) by srv047132.webreus.nl with SMTP; 30 Jan 2013 21:57:09 +0100 From: "Robert Mast" To: "'Carl Worth'" , "'Jani Nikula'" , References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> <87boc8bt8a.fsf@yoom.home.cworth.org> In-Reply-To: Subject: RE: Reply all - issue Date: Wed, 30 Jan 2013 21:56:59 +0100 Message-ID: <000001cdff2c$59262b50$0b7281f0$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac39yr2ciHq/BzOAQieJla7aevASjQBP0GPgAAf4vDA= Content-Language: nl X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2013 20:57:18 -0000 I never used git for mailpatching, so I have no example-mailbox to analyse. I understand that the subject starting with "[PATCH ]" can be a git-hint, but is not guaranteed. Or is it? [1] If it isn't, can I assume all git-messages comply to this set: [2] "The patch is expected to be inline, directly following the message. Any line that is of the form: . three-dashes and end-of-line, or . a line that begins with "diff -", or . a line that begins with "Index: " " Or should the git filter also look for a "scissor-line" [3] to identify a git-message? [1] http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html [2] http://linux.die.net/man/1/git-am [3] http://linux.die.net/man/1/git-mailinfo Or are there any guaranteed under water git-markers in the mailheader? -----Oorspronkelijk bericht----- Van: Robert Mast [mailto:beheerder@tekenbeetziekten.nl] Verzonden: woensdag 30 januari 2013 18:15 Aan: 'Carl Worth'; 'Jani Nikula'; 'notmuch@notmuchmail.org' Onderwerp: RE: Reply all - issue Thanks for your clear explanation. The thread-merging and breaking is in the procedure already pointed at by Jani: (_notmuch_database_link_message() in lib/database.cc.) Is there a quick way to recognize those git-threads by subject-syntax, or to reliably tag them to exclude them from subject-breaking? -----Oorspronkelijk bericht----- Van: Carl Worth [mailto:cworth@cworth.org] Verzonden: dinsdag 29 januari 2013 3:48 Aan: Robert Mast; 'Jani Nikula'; notmuch@notmuchmail.org Onderwerp: RE: Reply all - issue Is there any existing thread-breaking? There wasn't the last time I looked at the code closely, (but admittedly, that was a while ago). -Carl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B60F0431FAF for ; Wed, 30 Jan 2013 13:39:47 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IUIXj84xhiK4 for ; Wed, 30 Jan 2013 13:39:47 -0800 (PST) Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 2B8D6431FAE for ; Wed, 30 Jan 2013 13:39:47 -0800 (PST) Received: by mail-we0-f179.google.com with SMTP id x43so1608701wey.24 for ; Wed, 30 Jan 2013 13:39:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=do2gsLgOwTgn6Tz5AuHPOnX9BhJLTw6N88bdJ6kk0xA=; b=o9rFv7Cdj5Z4oGDHdDVAjS5SAQLnK+qZYxYnjcFq18j0RpyMEVfqk01tc9W4KFtLwM AQXCsF44fKMG1sUGYZepqNPh7KPBJZBrTcRImFHZFl6AjoUTI7/5OzOrlER4hiYWvScq S48ImcXYtwkwaJRVBNSSzysphlzitsMpcvQrpBBoxzQm1B2N9h3/H+5GcYh1SffmTRGS YT5uKR/klgYsbHoCEdu4XYxdj3LIn7W/TJZj7nK8DPK9g3c3wrK1aNXT9aeuZUOUZTf5 jdRxq0apPfnQ24LHqMwVuKuzfC+lDW0PxrTAukNDEkpWReLsXL4GZXn5t1wQYAHlphba KEyg== X-Received: by 10.180.85.103 with SMTP id g7mr11324584wiz.29.1359581984535; Wed, 30 Jan 2013 13:39:44 -0800 (PST) Received: from kuru.dyndns-at-home.com (AAnnecy-651-1-13-37.w90-27.abo.wanadoo.fr. [90.27.180.37]) by mx.google.com with ESMTPS id bd7sm5577165wib.8.2013.01.30.13.39.42 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 30 Jan 2013 13:39:43 -0800 (PST) Sender: suvayu ali Date: Wed, 30 Jan 2013 22:39:40 +0100 From: Suvayu Ali To: notmuch@notmuchmail.org Subject: Re: Reply all - issue Message-ID: <20130130213940.GC434@kuru.dyndns-at-home.com> Mail-Followup-To: notmuch@notmuchmail.org References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> <87boc8bt8a.fsf@yoom.home.cworth.org> <00bf01cdff0d$4ecedd10$ec6c9730$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00bf01cdff0d$4ecedd10$ec6c9730$@nl> User-Agent: Mutt/1.5.21 (2011-07-01) X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2013 21:39:47 -0000 Hi, I am a *very new* notmuch user (notmuch + mutt-kz/Emacs), but I would like to throw in a few opinions about this topic. On Wed, Jan 30, 2013 at 06:14:48PM +0100, Robert Mast wrote: > Thanks for your clear explanation. > > The thread-merging and breaking is in the procedure already pointed at by > Jani: (_notmuch_database_link_message() in lib/database.cc.) > > Is there a quick way to recognize those git-threads by subject-syntax, or to > reliably tag them to exclude them from subject-breaking? > I don't like this feature at all. Threads with patches from git-send-email are not the only kind of threads where this might be relevant. Often I encounter threads with sub-threads which are a little OT hence get renamed, but they are still related to the parent thread. Sometimes this helps in following how a topic came up while discussing something else. This is especially true when going through old emails for reference. I have encountered this in mailing lists, personal emails and discussions with colleagues. One of the many other reasons for me to switch from Gmail to my present setup was to avoid this "feature". That said, I think this feature is indeed useful at times but it should be implemented in the UI on user command or as a configurable (e.g. mutt provides the command), not a default underlying behaviour of the backend. If this is pursued, implementing it as a configurable in the Emacs UI might be more appropriate (or whatever other UIs exists out there). Hope this is constructive to the discussion. :) Cheers, -- Suvayu Open source is the future. It sets us free. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D1749431FAF for ; Wed, 30 Jan 2013 13:49:48 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2cGqOQSF0tSP for ; Wed, 30 Jan 2013 13:49:45 -0800 (PST) Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 71D8B431FAE for ; Wed, 30 Jan 2013 13:49:45 -0800 (PST) Received: (qmail 1736 invoked from network); 30 Jan 2013 22:49:44 +0100 Received: from ip73-109-210-87.adsl2.static.versatel.nl (HELO PCvangebruike) (87.210.109.73) by srv047132.webreus.nl with SMTP; 30 Jan 2013 22:49:41 +0100 From: "Robert Mast" To: "'Carl Worth'" , "'Jani Nikula'" , References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> <87boc8bt8a.fsf@yoom.home.cworth.org> In-Reply-To: Subject: RE: Reply all - issue Date: Wed, 30 Jan 2013 22:49:31 +0100 Message-ID: <000001cdff33$afe11070$0fa33150$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac39yr2ciHq/BzOAQieJla7aevASjQBP0GPgAAf4vDAAAUOMgA== Content-Language: nl X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2013 21:49:49 -0000 I ran git send-email and became the following line in the mail-header: "X-Mailer: git-send-email 1.7.9.5" I see that this git-marker already existed in version 1.3 in 2006: http://comments.gmane.org/gmane.comp.version-control.git/23337 Can I assume, apart from the version number, that this header-marker applies to all git-mail that should not be subject-splitted? I can also leave the threads in the database as they are and only change notmuch_query_search_threads in lib/query.cc to add the subject as a second hash-key and notmuch_threads_get/_notmuch_thread_create for also looking for the subject of the seed-message. Then I only have to add the stripped subject as a search-term. The subject that's now in the database is the original non-stripped subject. I expect next weekend to have some time again. -----Oorspronkelijk bericht----- Van: Robert Mast [mailto:beheerder@tekenbeetziekten.nl] Verzonden: woensdag 30 januari 2013 21:57 Aan: 'Carl Worth'; 'Jani Nikula'; 'notmuch@notmuchmail.org' Onderwerp: RE: Reply all - issue I never used git for mailpatching, so I have no example-mailbox to analyse. I understand that the subject starting with "[PATCH ]" can be a git-hint, but is not guaranteed. Or is it? [1] If it isn't, can I assume all git-messages comply to this set: [2] "The patch is expected to be inline, directly following the message. Any line that is of the form: . three-dashes and end-of-line, or . a line that begins with "diff -", or . a line that begins with "Index: " " Or should the git filter also look for a "scissor-line" [3] to identify a git-message? [1] http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html [2] http://linux.die.net/man/1/git-am [3] http://linux.die.net/man/1/git-mailinfo Or are there any guaranteed under water git-markers in the mailheader? -----Oorspronkelijk bericht----- Van: Robert Mast [mailto:beheerder@tekenbeetziekten.nl] Verzonden: woensdag 30 januari 2013 18:15 Aan: 'Carl Worth'; 'Jani Nikula'; 'notmuch@notmuchmail.org' Onderwerp: RE: Reply all - issue Thanks for your clear explanation. The thread-merging and breaking is in the procedure already pointed at by Jani: (_notmuch_database_link_message() in lib/database.cc.) Is there a quick way to recognize those git-threads by subject-syntax, or to reliably tag them to exclude them from subject-breaking? -----Oorspronkelijk bericht----- Van: Carl Worth [mailto:cworth@cworth.org] Verzonden: dinsdag 29 januari 2013 3:48 Aan: Robert Mast; 'Jani Nikula'; notmuch@notmuchmail.org Onderwerp: RE: Reply all - issue Is there any existing thread-breaking? There wasn't the last time I looked at the code closely, (but admittedly, that was a while ago). -Carl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C0038431FAF for ; Wed, 30 Jan 2013 17:13:04 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=unavailable Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MuIvvpcB33Zk for ; Wed, 30 Jan 2013 17:13:04 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 9D1DC431FAE for ; Wed, 30 Jan 2013 17:13:04 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1U0ihx-0006x2-Q0; Wed, 30 Jan 2013 21:12:56 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1U0ihr-0003Ml-Qz; Wed, 30 Jan 2013 21:12:47 -0400 From: David Bremner To: Robert Mast , 'Carl Worth' , 'Jani Nikula' , notmuch@notmuchmail.org Subject: RE: Reply all - issue In-Reply-To: <000001cdff33$afe11070$0fa33150$@nl> References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> <87boc8bt8a.fsf@yoom.home.cworth.org> <000001cdff33$afe11070$0fa33150$@nl> User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Wed, 30 Jan 2013 21:12:47 -0400 Message-ID: <87txpykve8.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2013 01:13:04 -0000 Robert Mast writes: > I ran git send-email and became the following line in the mail-header: > > "X-Mailer: git-send-email 1.7.9.5" > > Can I assume, apart from the version number, that this header-marker applies > to all git-mail that should not be subject-splitted? Hardcoding particular headers sounds too fragile to me. With that said, if you want a corpus of email to investigate, there is e.g. http://notmuchmail.org/corpus/ Unfortunately I seem to recall threading is mostly pretty trivial, except in the notmuch mailing list archive. If you prefer a smaller download, that is at http://notmuchmail.org/corpus/ (as an mbox) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6CD2D431FAF for ; Wed, 30 Jan 2013 17:15:07 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=unavailable Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ogqGR24yQ6Eq for ; Wed, 30 Jan 2013 17:15:07 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 45F97431FAE for ; Wed, 30 Jan 2013 17:15:07 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1U0ik5-0006zs-2p; Wed, 30 Jan 2013 21:15:05 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1U0ijz-0003pZ-Cb; Wed, 30 Jan 2013 21:14:59 -0400 From: David Bremner To: Robert Mast , 'Carl Worth' , 'Jani Nikula' , notmuch@notmuchmail.org Subject: RE: Reply all - issue In-Reply-To: <87txpykve8.fsf@zancas.localnet> References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> <87boc8bt8a.fsf@yoom.home.cworth.org> <000001cdff33$afe11070$0fa33150$@nl> <87txpykve8.fsf@zancas.localnet> User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Wed, 30 Jan 2013 21:14:59 -0400 Message-ID: <87r4l2kvak.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2013 01:15:07 -0000 David Bremner writes: > > Hardcoding particular headers sounds too fragile to me. With that said, > if you want a corpus of email to investigate, there is e.g. > Let me step back a level and say that special casing git patch series strikes me as not yet seeing the problem in enough generality. Others might disagree, of course. d From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 82C9C431FAF for ; Thu, 31 Jan 2013 02:21:25 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xoOzJk2uUHai for ; Thu, 31 Jan 2013 02:21:25 -0800 (PST) Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com [209.85.215.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id CA58A431FAE for ; Thu, 31 Jan 2013 02:21:24 -0800 (PST) Received: by mail-ea0-f173.google.com with SMTP id i1so1183031eaa.32 for ; Thu, 31 Jan 2013 02:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Se0vxvWSbdoVzxR5QLU/lVwU1i6MA32o33FpBsi9Iw8=; b=QNPw4mj01UNZNmjMV5RrMefab7Lx64H4YJiPtTW0MPUC3yO9thoWTMB7R33FgtKNn0 Q2NMIlJx33CAWjlUpep9JDM7KpSF+bL041dejr2+mqoYZmNIoXttgryMxkiWf96Fa55o UgG/BnhMDnNX+xDQlOAl7M1v/LTUeCvEHxjwkE66f8ESDSYYETEmlzW1O+2CX6TDl9cF GvF6nME0z2SPZYBEvdTqmiORlR1RHBBOP/c/XCjXVYCL8LaA3kD3hnZ/RaOTXRWGqoaY AQugZNLxyAUuRo2/wXENe7lkT6MY43eC0Lk9EA3U7TdRfWWKGGgRBiPg4Ii44FTVNpqb XNgw== X-Received: by 10.14.223.135 with SMTP id v7mr25764404eep.41.1359627683620; Thu, 31 Jan 2013 02:21:23 -0800 (PST) Received: from sid.nuvreauspam ([92.86.142.199]) by mx.google.com with ESMTPS id f49sm6633410eep.12.2013.01.31.02.21.21 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 31 Jan 2013 02:21:22 -0800 (PST) Received: by sid.nuvreauspam (Postfix, from userid 1077) id DDC1E7456; Thu, 31 Jan 2013 12:21:19 +0200 (EET) Date: Thu, 31 Jan 2013 12:21:19 +0200 From: Andrei POPESCU To: notmuch@notmuchmail.org Subject: Re: Reply all - issue Message-ID: <20130131102119.GD4184@sid.nuvreauspam> References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> <87boc8bt8a.fsf@yoom.home.cworth.org> <00bf01cdff0d$4ecedd10$ec6c9730$@nl> <20130130213940.GC434@kuru.dyndns-at-home.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rS8CxjVDS/+yyDmU" Content-Disposition: inline In-Reply-To: <20130130213940.GC434@kuru.dyndns-at-home.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2013 10:21:25 -0000 --rS8CxjVDS/+yyDmU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mi, 30 ian 13, 22:39:40, Suvayu Ali wrote: >=20 > That said, I think this feature is indeed useful at times but it should > be implemented in the UI on user command or as a configurable (e.g. mutt > provides the command), not a default underlying behaviour > of the backend. If this is pursued, implementing it as a configurable > in the Emacs UI might be more appropriate (or whatever other UIs exists > out there). As a subscriber of 30+ mailing lists a big +1 from me. Mutt's=20 has served me well on the very rare occasion I needed it. Kind regards, Andrei --=20 If you can't explain it simply, you don't understand it well enough. (Albert Einstein) --rS8CxjVDS/+yyDmU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAEBCAAGBQJRCkWfAAoJEHNWs3jeoi3pGNEH+wYaO7AP64WxOv/eNJT6tofr AZM/yirz7uBPucd7OmbZn3IVZ83oG9izZLvhhN+AnZjQJ21SMj82IQDngnyT3Dum 2ehd3t4FgH5GtqxORA9/aIIbBg5JI3JCogXkfhJnXxGfWPNTk+VtpzIvUB+4JJqR B45UPo5kkggxukvrL9yJyE9jUvTgBEDi70ldIh4CXLYpcyH6AXb7/4jzgNF8JoN2 LYmPBn0gX2s9PemMDpwJRFcAkfaqp9ZeaMXDDMdgSic/xr9HnxnVhoR7JEBDYJYo HDhWKLjRlF5dUVVLCQldZkPJ3Z08/yJ2FRWBmZ9hR4BMORVKgadAyrpJ2WkhPVQ= =s7Nu -----END PGP SIGNATURE----- --rS8CxjVDS/+yyDmU-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 9EFFE431FB6 for ; Thu, 31 Jan 2013 02:52:11 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.698 X-Spam-Level: X-Spam-Status: No, score=-0.698 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kRJkVrejNmPc for ; Thu, 31 Jan 2013 02:52:10 -0800 (PST) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com [209.85.217.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 0C6F2431FAE for ; Thu, 31 Jan 2013 02:52:09 -0800 (PST) Received: by mail-lb0-f175.google.com with SMTP id n3so3163128lbo.6 for ; Thu, 31 Jan 2013 02:52:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=4ldirySpVoRwW81WL3v+hjW1z6RJYCfLzeeSBL81Flw=; b=i7vTrLN+1XCFljQ4S5+uw4HBxmS6ckxZMMhmlFJC1HvsDcyKdm7SMzDeHje+N9Oxuq hjyR99Vyg9ZlQvcLJFoGGNpockG3BAffn2GJqYconKIgUyKot/F0qKYRoaXaVnJjxolo UVF1AXgBvd2ERZ3YZ6gsPmqyMa6ld1CyE4sGbDncyaGO38nQA0oz+w7O0TNFZM4r+Eg3 b3KONx6YflWSicCH/lr0TnnTxQ30JPUtHtnK6a406hlr3qaBK3JnGQ+D2VQmzlYmzhr6 ozn8wwBH8kw/o/4Cu1G5YxEL/UlqzCiu7W50HfV/TGNRkif7YAkmritYsuU3w/5l9W1Q Yefg== MIME-Version: 1.0 X-Received: by 10.152.144.4 with SMTP id si4mr7428456lab.10.1359629525667; Thu, 31 Jan 2013 02:52:05 -0800 (PST) Sender: mnazarewicz@gmail.com Received: by 10.114.99.65 with HTTP; Thu, 31 Jan 2013 02:52:05 -0800 (PST) Received: by 10.114.99.65 with HTTP; Thu, 31 Jan 2013 02:52:05 -0800 (PST) In-Reply-To: <000001cdfcd9$82500f00$86f02d00$@nl> References: <000001cdfcd9$82500f00$86f02d00$@nl> Date: Thu, 31 Jan 2013 11:52:05 +0100 X-Google-Sender-Auth: SInv3Mdfmxx8BuEYK3yX48xttvo Message-ID: Subject: Re: Reply all - issue From: =?UTF-8?Q?Micha=C5=82_Nazarewicz?= To: Robert Mast Content-Type: multipart/alternative; boundary=e89a8f22c3f7e74e8004d4936a9f Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2013 10:52:11 -0000 --e89a8f22c3f7e74e8004d4936a9f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 28 sty 2013 08:37, "Robert Mast" napisa=C5= =82(a): > I think of a fix that indexes the first dates of (stripped) subject-changes within threads, and with each first (stripped) subject change check the body on quotes of previous messages. If there is no quote to referenced mails then drop the reference and assign a new thread_id_ to the (stripped) subject. This is a misfeature which only reinforces the incorrect behaviour and one of the tbings I hate about Gmail. As such I hope that at the *very* *least* there will be an option to turn tbis behaviour off. --e89a8f22c3f7e74e8004d4936a9f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

28 sty 2013 08:37, "Robert Mast" <beheerder@tekenbeetziekten.nl> n= apisa=C5=82(a):
> I think of a fix that indexes the first dates of (stripped) subject-ch= anges within threads, and with each first (stripped) subject change check t= he body on quotes of previous messages. If there is no quote to referenced = mails then drop the reference and assign a new thread_id_ to the (stripped)= subject.

This is a misfeature which only reinforces the incorrect beh= aviour and one of the tbings I hate about Gmail. As such I hope that at the= *very* *least* there will be an option to turn tbis behaviour off.

--e89a8f22c3f7e74e8004d4936a9f-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CD2F3431FB6 for ; Sat, 2 Feb 2013 08:21:44 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.001 X-Spam-Level: X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 tests=[HTML_MESSAGE=0.001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AW+EFPuKsLpp for ; Sat, 2 Feb 2013 08:21:44 -0800 (PST) Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BE9B2431FAE for ; Sat, 2 Feb 2013 08:21:43 -0800 (PST) Received: (qmail 16259 invoked from network); 2 Feb 2013 17:21:40 +0100 Received: from ip73-109-210-87.adsl2.static.versatel.nl (HELO PCvangebruike) (87.210.109.73) by srv047132.webreus.nl with SMTP; 2 Feb 2013 17:21:37 +0100 From: "Robert Mast" To: =?utf-8?Q?'Micha=C5=82_Nazarewicz'?= References: <000001cdfcd9$82500f00$86f02d00$@nl> In-Reply-To: Subject: RE: Reply all - issue Date: Sat, 2 Feb 2013 17:21:32 +0100 Message-ID: <000001ce0161$5da40990$18ec1cb0$@nl> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0001_01CE0169.BF6A4650" X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac3/oQamHj3hr98TR6O/L7L4p4FCQwBvuYIA Content-Language: nl Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2013 16:21:45 -0000 This is a multi-part message in MIME format. ------=_NextPart_000_0001_01CE0169.BF6A4650 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Off course I=E2=80=99ll try not to hinder the current notmuch-users. My = intent is to even find some support for it. =20 As far as I know Gmail was the great example of threading for the = SUP-developers, and SUP lead to Notmuch. =20 So Gmail-threading is still the best I suppose, except for git = send-email-users, which happen to have quite an overlap with the = developers of nutmuch. =20 Anyone interested in me patching Notmuch, or shall I keep the changes to = myself? =20 Van: mnazarewicz@gmail.com =E2=80=A6 This is a misfeature which only reinforces the incorrect behaviour and = one of the things I hate about Gmail. As such I hope that at the *very* = *least* there will be an option to turn this behaviour off. ------=_NextPart_000_0001_01CE0169.BF6A4650 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Off course I=E2=80=99ll try not to hinder the current notmuch-users. = My intent is to even find some support for it.

 

As far as I know Gmail was the great example of threading for the = SUP-developers, and SUP lead to Notmuch.

 

So Gmail-threading is still the best I suppose, except for git = send-email-users, which happen to have quite an overlap with the = developers of nutmuch.

 

Anyone interested in me patching Notmuch, or shall I keep the changes = to myself?

 

Van:<= /b> = mnazarewicz@gmail.com
=E2=80=A6

This is a = misfeature which only reinforces the incorrect behaviour and one of the = things I hate about Gmail. As such = I hope that at the *very* *least* there will be an option to turn this behaviour = off.

------=_NextPart_000_0001_01CE0169.BF6A4650-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 95561431FB6 for ; Sat, 2 Feb 2013 12:52:51 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6lADadiOXmDE for ; Sat, 2 Feb 2013 12:52:49 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B773D431FAE for ; Sat, 2 Feb 2013 12:52:49 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1U1k4p-0006yI-B7; Sat, 02 Feb 2013 16:52:46 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1U1k4j-00029G-Js; Sat, 02 Feb 2013 16:52:37 -0400 From: David Bremner To: Robert Mast Subject: RE: Reply all - issue In-Reply-To: <000001ce0161$5da40990$18ec1cb0$@nl> References: <000001cdfcd9$82500f00$86f02d00$@nl> <000001ce0161$5da40990$18ec1cb0$@nl> User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Sat, 02 Feb 2013 16:52:37 -0400 Message-ID: <87a9rml9pm.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2013 20:52:51 -0000 Robert Mast writes: > > Anyone interested in me patching Notmuch, or shall I keep the changes > to myself? > Hi Robert; If you have patches, and you want feedback on them, then you are of course welcome to send them to the list. Previous experience suggests us that it is often faster in the long run (in terms of actually getting code into notmuch) to take time to work out the design issues before starting coding. Some suggestions/comments: 1) See http://notmuchmail.org/contributing/ for some general hints on contributing code to notmuch. 2) Make sure whatever threading heuristic you use is deterministic, and robust in the face of messages arriving in different orders, and munging of headers by mailing lists (subjects in particular get munged fairly often). 3) In particular, it seems important that "notmuch dump" followed by "notmuch restore" (possibly followed by notmuch new?) yields unchanged or equivalent thread structure 4) Since threading heuristics are a matter of taste (i.e. not everyone is convinced that the way Gmail does it is the way notmuch should), you'll need to make this configurable. One constraint is that the library itself (under ./lib) is should not read configuration files (or environment variables, although it violates this for debugging). This just means you will have to change the API to pass configuration information in to certain routines. 5) I'd say it's more important that you can shut off the heuristic completely than have special handling for git (or other version control system) patch series. If you do decide to add some special handling for patch series, I'd suggest making it as generic as possible, perhaps a configurable list of (header, regex) values that disable the thread splitting heuristics. 6) Decide how, if at all your design will support manually joining threads together. I think an acceptable answer would probably be "disable all thread splitting heuristics and rebuild the database". I'm not sure if it's feasible to do anything nicer than that. d From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 50100431FB6 for ; Sat, 2 Feb 2013 16:07:27 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tcCSguf1Ipw5 for ; Sat, 2 Feb 2013 16:07:24 -0800 (PST) Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BE94E431FAE for ; Sat, 2 Feb 2013 16:07:23 -0800 (PST) Received: (qmail 19805 invoked from network); 3 Feb 2013 01:07:20 +0100 Received: from ip73-109-210-87.adsl2.static.versatel.nl (HELO PCvangebruike) (87.210.109.73) by srv047132.webreus.nl with SMTP; 3 Feb 2013 01:07:11 +0100 From: "Robert Mast" To: "'David Bremner'" References: <000001cdfcd9$82500f00$86f02d00$@nl> <000001ce0161$5da40990$18ec1cb0$@nl> <87a9rml9pm.fsf@zancas.localnet> In-Reply-To: <87a9rml9pm.fsf@zancas.localnet> Subject: RE: [Spam-verdenking][english 100%] RE: Reply all - issue Date: Sun, 3 Feb 2013 01:06:58 +0100 Message-ID: <005401ce01a2$62293300$267b9900$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac4Bh0PMAEUftH8lRH6w+fV5DvJa7QABgqoQ Content-Language: nl Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2013 00:07:27 -0000 Thanks for the guidelines! One answer I couldn't find under coding: Do you all develop with = emacs/GDB or is there a more visual and intuitive IDE to code with and = load/show the dependency-tree? I only debugged some C-code with emacs 15 = years ago and feel quite clumsy to get emacs to function like a proper = wysywig-IDE. #4) naturally. I like your last suggestion at #5) of the header-regexp and agree to = first work on the design-issues left before coding: @#6): I doubt whether I should tamper with threading heuristics at = all at the level of /lib/database.cc. Does anyone know whether the MUA's = using notmuch depend on thread-id's at the level of database.cc, or will = MUA's respect the different threads coming from seeding = lib/thread.cc/_notmuch_thread_create with all known messages except = already processed messages as is done with notmuch_query_search_threads? If I let lib/thread.cc/_notmuch_thread_create only 'eat' everything from = 'match_set' for a stripped subject the 'seed'-message of another subject = within the same thread will then lead to another created thread within = the result set. If I start coding this I can try the result with mutt-kz/notmuch and = notmuch/emacs. My aim with getting notmuch working well will be providing a base for = reviving something like mail2forum for phpBB3 with = mailcompression-capabilities to prevent for mailthreads to be copied in = again and again with every mailed answer. I think that can be accomplished by keeping the original mails as well = and compress the forum-threads to sup-like threads (by hiding quoted = e-mail). -----Oorspronkelijk bericht----- Van: David Bremner [mailto:david@tethera.net]=20 Verzonden: zaterdag 2 februari 2013 21:53 Aan: Robert Mast CC: notmuch@notmuchmail.org Onderwerp: [Spam-verdenking][english 100%] RE: Reply all - issue Robert Mast writes: > > Anyone interested in me patching Notmuch, or shall I keep the changes=20 > to myself? > Hi Robert; If you have patches, and you want feedback on them, then you are of = course welcome to send them to the list. Previous experience suggests = us that it is often faster in the long run (in terms of actually getting = code into notmuch) to take time to work out the design issues before = starting coding. Some suggestions/comments: 1) See http://notmuchmail.org/contributing/ for some general hints on contributing code to notmuch. =20 2) Make sure whatever threading heuristic you use is deterministic, and robust in the face of messages arriving in different orders, and munging of headers by mailing lists (subjects in particular get munged fairly often). =20 3) In particular, it seems important that "notmuch dump" followed by "notmuch restore" (possibly followed by notmuch new?) yields = unchanged or equivalent thread structure 4) Since threading heuristics are a matter of taste (i.e. not everyone is convinced that the way Gmail does it is the way notmuch should), you'll need to make this configurable. One constraint is that the library itself (under ./lib) is should not read configuration files (or environment variables, although it violates this for debugging). This just means you will have to change the API to pass configuration information in to certain routines. 5) I'd say it's more important that you can shut off the heuristic completely than have special handling for git (or other version control system) patch series. If you do decide to add some special handling for patch series, I'd suggest making it as generic as possible, perhaps a configurable list of (header, regex) values that disable the thread splitting heuristics. 6) Decide how, if at all your design will support manually joining threads together. I think an acceptable answer would probably be "disable all thread splitting heuristics and rebuild the database". I'm not sure if it's feasible to do anything nicer than that. d . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2DE56431FB6 for ; Sun, 3 Feb 2013 07:26:53 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ohp7oDa+ul51 for ; Sun, 3 Feb 2013 07:26:50 -0800 (PST) Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 0E279431FAE for ; Sun, 3 Feb 2013 07:26:49 -0800 (PST) Received: (qmail 28155 invoked from network); 3 Feb 2013 16:26:45 +0100 Received: from ip73-109-210-87.adsl2.static.versatel.nl (HELO PCvangebruike) (87.210.109.73) by srv047132.webreus.nl with SMTP; 3 Feb 2013 16:26:43 +0100 From: "Robert Mast" To: "'David Bremner'" References: <000001cdfcd9$82500f00$86f02d00$@nl> <000001ce0161$5da40990$18ec1cb0$@nl> <87a9rml9pm.fsf@zancas.localnet> In-Reply-To: <87a9rml9pm.fsf@zancas.localnet> Subject: RE: Reply all - issue Date: Sun, 3 Feb 2013 16:26:27 +0100 Message-ID: <000001ce0222$d5f30420$81d90c60$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac4Bh0PMAEUftH8lRH6w+fV5DvJa7QAm1Gtg Content-Language: nl Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2013 15:26:53 -0000 I committed a little patch on a memory-issue I found. Can someone look whether I used git the right way, or should I study git = send-email some further? -----Oorspronkelijk bericht----- Van: David Bremner [mailto:david@tethera.net]=20 Verzonden: zaterdag 2 februari 2013 21:53 Aan: Robert Mast CC: notmuch@notmuchmail.org Onderwerp: [Spam-verdenking][english 100%] RE: Reply all - issue Robert Mast writes: > > Anyone interested in me patching Notmuch, or shall I keep the changes=20 > to myself? > Hi Robert; If you have patches, and you want feedback on them, then you are of = course welcome to send them to the list. Previous experience suggests = us that it is often faster in the long run (in terms of actually getting = code into notmuch) to take time to work out the design issues before = starting coding. Some suggestions/comments: 1) See http://notmuchmail.org/contributing/ for some general hints on contributing code to notmuch. =20 2) Make sure whatever threading heuristic you use is deterministic, and robust in the face of messages arriving in different orders, and munging of headers by mailing lists (subjects in particular get munged fairly often). =20 3) In particular, it seems important that "notmuch dump" followed by "notmuch restore" (possibly followed by notmuch new?) yields = unchanged or equivalent thread structure 4) Since threading heuristics are a matter of taste (i.e. not everyone is convinced that the way Gmail does it is the way notmuch should), you'll need to make this configurable. One constraint is that the library itself (under ./lib) is should not read configuration files (or environment variables, although it violates this for debugging). This just means you will have to change the API to pass configuration information in to certain routines. 5) I'd say it's more important that you can shut off the heuristic completely than have special handling for git (or other version control system) patch series. If you do decide to add some special handling for patch series, I'd suggest making it as generic as possible, perhaps a configurable list of (header, regex) values that disable the thread splitting heuristics. 6) Decide how, if at all your design will support manually joining threads together. I think an acceptable answer would probably be "disable all thread splitting heuristics and rebuild the database". I'm not sure if it's feasible to do anything nicer than that. d . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7558C431FAE for ; Sun, 3 Feb 2013 10:28:46 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z9IDqcsE400J for ; Sun, 3 Feb 2013 10:28:43 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BE0B4431FB6 for ; Sun, 3 Feb 2013 10:28:43 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1U24Iv-0000qS-KH; Sun, 03 Feb 2013 14:28:38 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1U24IL-0004Ek-SF; Sun, 03 Feb 2013 14:28:01 -0400 From: David Bremner To: Robert Mast Subject: RE: Reply all - issue In-Reply-To: <000001ce0222$d5f30420$81d90c60$@nl> References: <000001cdfcd9$82500f00$86f02d00$@nl> <000001ce0161$5da40990$18ec1cb0$@nl> <87a9rml9pm.fsf@zancas.localnet> <000001ce0222$d5f30420$81d90c60$@nl> User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Sun, 03 Feb 2013 14:28:01 -0400 Message-ID: <871ucxl0b2.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2013 18:28:46 -0000 Robert Mast writes: > I committed a little patch on a memory-issue I found. Where did you commit it? > > Can someone look whether I used git the right way, or should I study > git send-email some further? I guess that's probably the simplest. Otherwise you need to push it to a publically available repo. d From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3925D431FB6 for ; Mon, 4 Feb 2013 02:39:49 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.698 X-Spam-Level: X-Spam-Status: No, score=-0.698 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id usJp0+xPCRjM for ; Mon, 4 Feb 2013 02:39:48 -0800 (PST) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com [209.85.217.169]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id F1B2E431FAE for ; Mon, 4 Feb 2013 02:39:47 -0800 (PST) Received: by mail-lb0-f169.google.com with SMTP id m4so6569592lbo.0 for ; Mon, 04 Feb 2013 02:39:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=LZQRR7999u2s2zLHdrWW6OBVBck+rBTTDEUvUSmA7/c=; b=d/n5oU1+WQF1pgA+FZH/TvJqn9sVn9x+jGKqYYvlbL7ZGojqFn5oeUp3GGmAzkmZ6N Va99uCorti4KiAs6BAfHCbTVmZ4GV03MNP2XydnJQGFaqKy8afxWgK1vhWqQ6QQuN90r FS/SDSZq0mpboZgohQSRx5KKkoUds15lCMkvThqc6Na44Pa1RQfS17dNMjs6wBoZwYaY VAhJoWoGFvWz0OQ2FMVR9eK6l/KdrJRpLjYPo+ksOKd1QJ85JqW/yL3T1ytR9OasTLje Oo4Eh/TGQ0q9eretETiDVw8iyThYz7AfEVwBjKct5lmvbrG36ICqkv4LOp7mOD462bmW z4lg== MIME-Version: 1.0 X-Received: by 10.112.23.136 with SMTP id m8mr8082038lbf.53.1359974384828; Mon, 04 Feb 2013 02:39:44 -0800 (PST) Sender: mnazarewicz@gmail.com Received: by 10.114.99.65 with HTTP; Mon, 4 Feb 2013 02:39:44 -0800 (PST) Received: by 10.114.99.65 with HTTP; Mon, 4 Feb 2013 02:39:44 -0800 (PST) In-Reply-To: <000001ce0161$5da40990$18ec1cb0$@nl> References: <000001cdfcd9$82500f00$86f02d00$@nl> <000001ce0161$5da40990$18ec1cb0$@nl> Date: Mon, 4 Feb 2013 11:39:44 +0100 X-Google-Sender-Auth: 57rVVK4hNkAOjgCZ9gT3QZCOvtA Message-ID: Subject: RE: Reply all - issue From: =?UTF-8?Q?Micha=C5=82_Nazarewicz?= To: Robert Mast Content-Type: multipart/alternative; boundary=e0cb4efe304a1c828704d4e3b659 Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2013 10:39:49 -0000 --e0cb4efe304a1c828704d4e3b659 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2 lut 2013 17:21, "Robert Mast" napisa=C5= =82(a): > So Gmail-threading is still the best I suppose, I strongly disagree. Having said that, as long as it's configurable I obviously won't be blocking your efforts. > Anyone interested in me patching Notmuch, or shall I keep the changes to myself? I was actually wondering that instead of hard coding the logic into notmuch itself, maybe it would be better to provide some sort of "split-thread" and "join-threads" which could than be used by separate tagging tool. To be user-friendly this may require a possibly to search for all ancestors of a given message and possibly an option to sort results topologically which I dunno if notmuch has. --e0cb4efe304a1c828704d4e3b659 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

2 lut 2013 17:21, "Robert Mast" <beheerder@tekenbeetziekten.nl> na= pisa=C5=82(a):
> So Gmail-threading is still the best I suppose,

I strongly disagree. Having said that, as long as it's c= onfigurable I obviously won't be blocking your efforts.

> Anyone interested in me patching Notmuch, or shall I ke= ep the changes to myself?

I was actually wondering that instead of hard coding the log= ic into notmuch itself, maybe it would be better to provide some sort of &q= uot;split-thread" and "join-threads" which could than be use= d by separate tagging tool.

To be user-friendly this may require a possibly to search fo= r all ancestors of a given message and possibly an option to sort results t= opologically which I dunno if notmuch has.

--e0cb4efe304a1c828704d4e3b659-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4F96A431FBC for ; Mon, 4 Feb 2013 07:30:11 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6D9QdUhU0LAy for ; Mon, 4 Feb 2013 07:30:10 -0800 (PST) Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 89A1F431FB6 for ; Mon, 4 Feb 2013 07:30:10 -0800 (PST) Received: by mail-wi0-f171.google.com with SMTP id hn17so1763729wib.10 for ; Mon, 04 Feb 2013 07:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=kfdorMZUCNu93+YnD6teziIoaCLn4d5e6C85JC6e74g=; b=s9SE8/EdmmyyuWagH+KHyR9OsoOPEWCKicgW+dy26vCyWLzumQ3lPTAwB3wrdL3D+r 2lfYpTIqaFlFlBtESsQDf8ewFIwXr3I1VA1Rl+i1Z1HYZguhNGgNxrG258N3pcH0lmWa 36Vf7j6bEWnprOqXdDoZR1/Gzhrn1TmZvqM58Ixp3bt6j67OBkcOuG7MbQgqgaDKsZ/i lrRtqcSu8MsvsIBhL+021LupDS7xPh0FKl8OqOoXfdYBAsvrubR87OvNNRNttgWRS4xA s5dbfj4rCbxtqFy/XJlP1G42Edl9BklJM7SnK3SBJ2swCO89SnURnJu5UuhglFjSQiHq KvDQ== X-Received: by 10.180.96.194 with SMTP id du2mr11228881wib.19.1359991800232; Mon, 04 Feb 2013 07:30:00 -0800 (PST) Received: from kuru.dyndns-at-home.com (pb-d-128-141-52-150.cern.ch. [128.141.52.150]) by mx.google.com with ESMTPS id hb9sm2555277wib.3.2013.02.04.07.29.58 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 04 Feb 2013 07:29:58 -0800 (PST) Sender: suvayu ali Date: Mon, 4 Feb 2013 16:29:56 +0100 From: Suvayu Ali To: notmuch@notmuchmail.org Subject: Re: Reply all - issue Message-ID: <20130204152956.GD23614@kuru.dyndns-at-home.com> Mail-Followup-To: notmuch@notmuchmail.org References: <000001cdfcd9$82500f00$86f02d00$@nl> <000001ce0161$5da40990$18ec1cb0$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2011-07-01) X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2013 15:30:11 -0000 On Mon, Feb 04, 2013 at 11:39:44AM +0100, Michał Nazarewicz wrote: > 2 lut 2013 17:21, "Robert Mast" napisał(a): > > Anyone interested in me patching Notmuch, or shall I keep the changes to > myself? > > I was actually wondering that instead of hard coding the logic into notmuch > itself, maybe it would be better to provide some sort of "split-thread" and > "join-threads" which could than be used by separate tagging tool. > > To be user-friendly this may require a possibly to search for all ancestors > of a given message and possibly an option to sort results topologically > which I dunno if notmuch has. This would be a wonderful addition. :) -- Suvayu Open source is the future. It sets us free. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 52489431FB6 for ; Wed, 6 Feb 2013 10:39:36 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7XDWHLgwVlkD for ; Wed, 6 Feb 2013 10:39:35 -0800 (PST) X-Greylist: delayed 1184 seconds by postgrey-1.32 at olra; Wed, 06 Feb 2013 10:39:35 PST Received: from imarko.xen.prgmr.com (imarko.xen.prgmr.com [72.13.95.244]) by olra.theworths.org (Postfix) with ESMTP id 9F832431FAF for ; Wed, 6 Feb 2013 10:39:35 -0800 (PST) Received: from localhost ([127.0.0.1] helo=zsu.kismala.com) by imarko.xen.prgmr.com with esmtp (Exim 4.80.1) (envelope-from ) id 1U39b4-0004Sa-G3 for notmuch@notmuchmail.org; Wed, 06 Feb 2013 10:19:50 -0800 From: Istvan Marko To: notmuch@notmuchmail.org Subject: Re: Reply all - issue References: <000001cdfcd9$82500f00$86f02d00$@nl> <000001ce0161$5da40990$18ec1cb0$@nl> Date: Wed, 06 Feb 2013 10:19:50 -0800 In-Reply-To: (=?utf-8?Q?=22Micha=C5=82?= Nazarewicz"'s message of "Mon, 4 Feb 2013 11:39:44 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2013 18:39:36 -0000 Micha=C5=82 Nazarewicz writes: > I was actually wondering that instead of hard coding the logic into notmu= ch > itself, maybe it would be better to provide some sort of "split-thread" a= nd > "join-threads" which could than be used by separate tagging tool. Such a customized threading feature would be great, I would use it to tie together "loose threads" originating from crappy ticket tracking tools that don't insert any In-Reply-To or References headers. Currently I handle this by inserting fake In-Reply-To headers during delivery and I would love to have a cleaner way. To make this useful it would have to be persistent across dumps and restores.=20 If we only consider splitting then a relatively easy way might be to allow the user to configure some tags to mark a split. In .notmuch-config you'd have: split_tags: split And then you'd tag +split the message to mark the start of a new thread. The threading code would watch for such tags. Which might get hairy if the tag information is not already at hand during threading. I don't see how this would work for joins so it would not help me but it could address the original problem. --=20 Istvan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2E404431FBC for ; Mon, 11 Feb 2013 12:09:54 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y-LxznREmouH for ; Mon, 11 Feb 2013 12:09:53 -0800 (PST) Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id AA0AF431FAE for ; Mon, 11 Feb 2013 12:09:52 -0800 (PST) Received: (qmail 7816 invoked from network); 10 Feb 2013 16:43:09 +0100 Received: from ip73-109-210-87.adsl2.static.versatel.nl (HELO PCvangebruike) (87.210.109.73) by srv047132.webreus.nl with SMTP; 10 Feb 2013 16:42:59 +0100 From: "Robert Mast" To: References: <000001cdfcd9$82500f00$86f02d00$@nl> <000001ce0161$5da40990$18ec1cb0$@nl> <87a9rml9pm.fsf@zancas.localnet> In-Reply-To: <87a9rml9pm.fsf@zancas.localnet> Subject: RE: Reply all - issue Date: Sun, 10 Feb 2013 16:43:01 +0100 Message-ID: <00a501ce07a5$4edcbb10$ec963130$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac4Bh0PMAEUftH8lRH6w+fV5DvJa7QGDuB6A Content-Language: nl X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2013 20:09:54 -0000 >From many replies I understand manual thread-joining and -breaking = exists with mutt's manual commands and default subject breaking -as = Gmail does- would not be preferred, while not only version control = systems vary subjects within a thread, but also discussions with slight = off-topic forks and therefore slightly changed subjects should stay in = the same thread. The reason why I asked my question in the first place is because I have = lots of mail-discussions going on between about 10 board-members who are = not able to meet in real life often enough to decide everything by = conference, so our mailboxes pile up with suggestions, remarks with = longer growing thread-histories and evolving addressee-lists. Those = addressee-lists vary by individual choice, often without confirmation of = other participants to involve some new addressee's, sometimes resulting = in leakage. I thought to revive mail2forum, a plug-in for phpBB, to force people to = use existing addressee-lists per 'circle' and archive all = e-maildiscussions in a forum, so people wouldn't be e-mailed for every = subject and could lose/drop their own mail. Threads should be compressed = to keep mostly only original messages - if available -, and small = citations, or links to original texts if needed. This thread-compression = is functionality the existing mail2forum doesn't have, so that's where = for example notmuch comes in. Discussing around I understand that phpBB misses the very basic feature = of thread-forking: Every slightly off-topic remark in a phpBB-message = can only be splitted to a completely new thread. I wonder whether that is blocking for my own situation, as participants = in our discussions don't change the subject-line very often, but it = could probably affect the viability of mail2forum as an open = source-project. I don't see how I can easily manually manipulate threads with a mail = client when mail2forum automatically reads and processes new incoming = mail, so my efforts with notmuch will probably stick to the 'optional' = subject-splitting-solution. As, however, mail2forum should handle postponed e-mail as well (and = exchange former quotes with their original texts), probably patching = from a manually altered maildir wouldn't be such a big step. I however = haven't studied all that's needed there yet. By the way, before I spend too much time on mail2forum - does anyone = know an (open source?) group-mail project with user authentication to = centrally stored messages that already does have satisfying = thread-compression? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7C549431FBC for ; Mon, 11 Feb 2013 23:08:07 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=unavailable Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VLQhBVMnYWvn for ; Mon, 11 Feb 2013 23:08:07 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 564DC431FAF for ; Mon, 11 Feb 2013 23:08:07 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id C8D9866E00CF; Mon, 11 Feb 2013 23:07:59 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (cpe-76-166-145-133.socal.res.rr.com [76.166.145.133]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id AD94666E00B8; Mon, 11 Feb 2013 23:07:53 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 1078D62219; Mon, 11 Feb 2013 23:07:53 -0800 (PST) From: Jameson Graef Rollins To: David Bremner , Robert Mast , 'Carl Worth' , 'Jani Nikula' , notmuch@notmuchmail.org Subject: RE: Reply all - issue In-Reply-To: <87r4l2kvak.fsf@zancas.localnet> References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> <87boc8bt8a.fsf@yoom.home.cworth.org> <000001cdff33$afe11070$0fa33150$@nl> <87txpykve8.fsf@zancas.localnet> <87r4l2kvak.fsf@zancas.localnet> User-Agent: Notmuch/0.15+8~gd4a7374 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Mon, 11 Feb 2013 23:07:50 -0800 Message-ID: <87sj52nh6h.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2013 07:08:07 -0000 --=-=-= Content-Type: text/plain On Wed, Jan 30 2013, David Bremner wrote: > Let me step back a level and say that special casing git patch series > strikes me as not yet seeing the problem in enough generality. Others > might disagree, of course. I agree with this statement. So I encounter the thread hijacking problem occasionally, but not frequently enough that I would trust a particular heuristic to cover it. I think I would prefer to just split hijacked threads manually as I encounter them. Just a thought: what if messages with a given tag (e.g. "new-thread") were always treated as the source of a new thread? A message with the given tag could just be (re)indexed with any In-Reply-To/References headers stripped before indexing. This would allow users to break threads manually, and it would mean dump && restore would always return the same state. The actual thread breaking, or specifically where it happens, would have to be thought through a bit. Maybe this could be rolled into notmuch new somehow? Or some other top-level function that applies operations to messages based on tags? jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJRGepGAAoJEO00zqvie6q8ww0P+wfU3lZnpzMeX2xsygDyhrfv uxguQYOx744Nb3boVqkrKasRpJuuTXGkoyBvtnFHAD3EyExP1h/uE7YWBo8AULzd kxBgZdney4Z4UCxxPJpe4XJNjIEwTbuOR1691SU07GFshewI79/urC9jqiocUytO b6UhvwBXzK3qcqKgBgRmEYqO1V6Av7RdFjBSbL/ZiYn0nOc4y4oUi2dh2kB2gWeC n4YOsI1t2qV9b2Y+36SXBV7omX1a42CQJHLH/6mtGd2Oo3imIqdzsTW3kyZAhuJQ smBt4sxjYA79gvgUTlmw6tYIje2qhDbWbHFDUbb0kz0aZEqB4q+i04n5m4vdT4N3 7lvoG/IHnQWI1LDX81n9DoaISbfJ36WyUU3151izHt/0l12cGpP/CAynG1jGziRx N2iq4DBWlqQBKno/qNnSMY9usvnoA9beX9q4hMVg7S/YnDQk1lK1ux95oPfYtLDd g/EUEDgMFwia4Dft6Q9yCG1v0IQP9Q3R2VDTshgXv0NutQg/Benj70EDZVaQZbbs kdCB8xo3RRTUWPkAVk8lUoe6zrLPlrkhQknFPkFHxgkvBVwALceNBSwvxL0IChch XaG9qukYgqrlh+Fly3dqXY97m6rhbT57EyALHJCYgSjPOCw9LXcxkRB8TvT6TLkS OXps5gD/O80wf9MV7hK7 =7S0Z -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 93B6A431FB6 for ; Tue, 12 Feb 2013 11:14:32 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6yAEgKhSGjB5 for ; Tue, 12 Feb 2013 11:14:32 -0800 (PST) Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 09EA2431FAF for ; Tue, 12 Feb 2013 11:14:32 -0800 (PST) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 0D0BE6DE0941; Tue, 12 Feb 2013 11:14:30 -0800 (PST) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 44C3E64933; Wed, 13 Feb 2013 06:17:18 +1100 (EST) From: Carl Worth To: Jameson Graef Rollins , David Bremner , Robert Mast , 'Jani Nikula' , notmuch@notmuchmail.org Subject: RE: Reply all - issue In-Reply-To: <87sj52nh6h.fsf@servo.finestructure.net> References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> <002601cdfd83$83b283f0$8b178bd0$@nl> <87boc8bt8a.fsf@yoom.home.cworth.org> <000001cdff33$afe11070$0fa33150$@nl> <87txpykve8.fsf@zancas.localnet> <87r4l2kvak.fsf@zancas.localnet> <87sj52nh6h.fsf@servo.finestructure.net> User-Agent: Notmuch/0.13.1 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Tue, 12 Feb 2013 11:17:08 -0800 Message-ID: <877gmdjqa3.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2013 19:14:32 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jameson Graef Rollins writes: > Just a thought: what if messages with a given tag (e.g. "new-thread") > were always treated as the source of a new thread? It's a good start. And an approach like that would have the advantage that one could undo a thread-split by just removing the tag. (That's not an explicit thread-join feature, but I don't think anyone has ever asked for that.) > A message with the given tag could just be (re)indexed with any > In-Reply-To/References headers stripped before indexing. It would require a little more than that. Imagine this thread: A: Subject: An original thread =E2=94=94=E2=94=80B: Subject: Thread hijacking is fun (tag:new-thread) =E2=94=94=E2=94=80C: Subject: Re: Thread hijacking is fun In this case, message C is likely to have a References header that mentions both A and B. So the thread stitching logic in notmuch will want to merge threads A and B when indexing C. So special care will have to be taken here as well, (not just when indexing B). And that special care may not be cheap if it requires additional database lookups for each unique thread ID encountered among references of a message. Though, I don't mean to dissuade anyone from thinking this through and coding it up. The relevant code for the pieces I'm referring to starts in _notmuch_database_link_message in lib/database.cc. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlEalTQACgkQ6JDdNq8qSWguyQCfbtLt8QIx19Mjhbb7q/5BuEJe z5sAniG0T+bewnGDgmcAd+IUAQOJpD7Z =su3/ -----END PGP SIGNATURE----- --=-=-=--