From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id AExQNhlpSWYOQwAAqHPOHw:P1 (envelope-from ) for ; Sun, 19 May 2024 04:51:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id AExQNhlpSWYOQwAAqHPOHw (envelope-from ) for ; Sun, 19 May 2024 04:51:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=CUk6sHdF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-mumi-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-mumi-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716087065; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=qoB0qThkKXM5w6ZNZZ0lPeVAC4j4LPtLS8ZNikJ/hvQ=; b=mWc00tKQuW4JbqgXdASR2jjVQp3PitrB9BN0lXv9nWipMcR4cGLITanT05f94YvMxdyj6c bKndzt7DhlQuqFHeQ1qzftLko53RBNFComsGYbwgTPOWwyHqZjY7ef0pqa1kk99MKTWHkb o+58BFCRJIqOY9ybAFvaKwzPMIoyZ+WMUEajILEr8KhFe4DfBjKYbd6zZu9sj+Ezl9FQ6e aEfG7xk1Bfxb4+yplrB55CR97PHDVlG/M5DN9iXS7/inicM1G0JBQaohcQ3vYw4CJFgKWw mEfVDclCQQintevJ1FuJv1wUrT0BzKdGGYyextTSfAr30lxGfU9UJKAORP8X2w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716087065; a=rsa-sha256; cv=none; b=CRh1EGubKBIz8KMvUBmB9D0yz6ewBRnOVAfebiNjUuC3zOGpCZIusYmz3oaSp0hURtElfK g8e9/UKN6eaHKtUYSoXaAitpYQvppns32eWiEoa8dGTVMH98pi1nfGHMAC7fXO4a/vwSXC B2sp72e8yjHDeAPEzRZfX+CTZ31opWUb1OBWbdZFyQSV7TE/TN6PbDNyOq3IMTcB1nIVNt XjyLONncsXzzYQ/fweDgOYRrV6THdtjjTvMJs4LOcIlOY5K4P+++cNJ2JEjCLMTsGSDn1K +yc1ENlp+Zb1w/7PjcDx+XfSz7hfIL6X3chynRhgtK1L72A629l2P1d4/t2DZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=CUk6sHdF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-mumi-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-mumi-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9024367A8F for ; Sun, 19 May 2024 04:51:03 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s8WdY-0006Ho-KJ; Sat, 18 May 2024 22:51:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8WdX-0006HT-DG for bug-mumi@gnu.org; Sat, 18 May 2024 22:50:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s8WdX-0004fZ-4r for bug-mumi@gnu.org; Sat, 18 May 2024 22:50:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s8Wda-0006oM-9b for bug-mumi@gnu.org; Sat, 18 May 2024 22:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#70871: [PATCH] Show avatars from Libravatar. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: bug-mumi@gnu.org Resent-Date: Sun, 19 May 2024 02:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70871 X-GNU-PR-Package: mumi X-GNU-PR-Keywords: patch To: Felix Lechner Cc: 70871@debbugs.gnu.org, 70871@patchwise.org Received: via spool by 70871-submit@debbugs.gnu.org id=B70871.171608702726155 (code B ref 70871); Sun, 19 May 2024 02:51:02 +0000 Received: (at 70871) by debbugs.gnu.org; 19 May 2024 02:50:27 +0000 Received: from localhost ([127.0.0.1]:35683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8Wd0-0006nn-HS for submit@debbugs.gnu.org; Sat, 18 May 2024 22:50:27 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:37428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8Wcw-0006nb-Py for 70871@debbugs.gnu.org; Sat, 18 May 2024 22:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qoB0qThkKXM5w6ZNZZ0lPeVAC4j4LPtLS8ZNikJ/hvQ=; b=CUk6sHdFrECdmnhsDGgnBmwtkL u7AiGfJ0K0bThmd232EKhEEkxKH8omUQcERPUNjpdKQzvRtU13KZcU+cc/+uV1HO1LaLwpryXrnfX vcjiR4II7ZyaKaCI2zHso0fF38MFSHghvQYokxn+5ykw3pnXIPUJm9XVLcbhK4FOk+GrEzEj28VZ/ LlLdUESUNHThAtz793HCq7/u4soH2nKWr9QNLp0rsKxnJESvjWGX2WO42Q/LG1vCqFCy9XgupOOZE B929NvmD4GJWRxgISQfLWpiMX52Iun7QfWF7+ebws28KEvTAbwN6f2A1v+uMbJxkJkzAXD83UQgxJ 8rs5O5xw==; Received: from [192.168.2.1] (port=58688 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1s8WZt-0003DS-2v; Sun, 19 May 2024 03:47:14 +0100 From: Arun Isaac In-Reply-To: <87pltpwlvp.fsf@lease-up.com> References: <20240511032008.16270-1-felix.lechner@lease-up.com> <87plts5lyy.fsf@systemreboot.net> <87a5ku4mhy.fsf@systemreboot.net> <87pltpwlvp.fsf@lease-up.com> Date: Sun, 19 May 2024 03:50:06 +0100 Message-ID: <87ttiuikgx.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-mumi@gnu.org List-Id: "Bug reports for GNU Guix Mumi." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-mumi-bounces+larch=yhetil.org@gnu.org Sender: bug-mumi-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.26 X-Spam-Score: -2.26 X-Migadu-Queue-Id: 9024367A8F X-Migadu-Scanner: mx11.migadu.com X-TUID: T7oSKVClI/gc Hi Felix, > There is also not much to abstract: It's a single 'img' tag. Well, it's repeated in three places. So, it's probably worth abstracting out. > There is no third avatar. If you haven't yet followed the CSS with a > Web Inspector, please look for the 'display: none' for that 'img' tag. > It comes from here: I believe the third avatar shows up on smaller screens. Try using the "responsive mode" (Ctrl+Shift+m) in Icecat to simulate a smaller screen. >> I also just remembered that the alt attribute of the img tag is meant to >> be used in place of the image (visually challenged readers using a >> screen reader, image download failed on a slow connection, etc.). So, we >> shouldn't use the alt attribute as a fallback for users without >> avatars. > > Would you please explain that rationale? A blind person who disables > the loading of images would still "see" (or perhaps hear) the 'alt' > character. How does my code break anything for a blind person, > please? See https://accessibility.huit.harvard.edu/describe-content-images An alt text of "A" for "Arun Isaac" would not make sense if read out aloud by a screen reader. It should rather be "Profile picture of Arun Isaac" or similar. Perhaps, it should also be marked up with aria-hidden=true. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden I'm not saying the current situation in mumi gets accessibility right. But, while we are changing things, we might as well get things right. > For an interpreted language like Guile there is no need to provide > prerequisite checks at configure time unless they enable workarounds to > build without. The Guile module detections currently found in > configure.ac are luxuries. I would remove them. I agree. But, I'm mainly trying to remain consistent with the existing code base. > If you prefer to keep them and add guile-avatar for the sake of > consistency, please feel free to amend the patch. I am happy to make this change myself. > I am sorry, but I am super busy. Sorry, so am I, and so is everyone else hacking away on Guix and mumi in their spare time. > I'd be happy to cooperate, if you agree to be less picky about my > patches. As a reviewer, it is kinda my job to bring contributions up to shape before they get applied. I am happy to work in good faith towards that goal. And, I don't feel I have been particularly picky in my review. The changes I proposed were pretty reasonable. Regards, Arun