From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id oKpSMLaiP2asVwAAe85BDQ:P1 (envelope-from ) for ; Sat, 11 May 2024 18:54:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id oKpSMLaiP2asVwAAe85BDQ (envelope-from ) for ; Sat, 11 May 2024 18:54:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=QzAY2NQg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-mumi-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-mumi-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715446454; a=rsa-sha256; cv=none; b=eWaGdR0sbQiMcGU0hWLX8cuOEZ+DnySit/gJjfS9QFUG9t+6jQtBXdJCB9zKQHeCCMj/FR XkfR0JQ0b5sFPSZdBmjWBxki9sW876XyOeU16zfqYgc/l9lwsckN1w44hBecVDtJOw5hb+ Ixv4WYmWpWIR74VhjfNZs8bnZ8BqpiItogebt9GdKKgchoaK8WGL/7lAAy1E0jCpJMhhUc zfkX1Xo+oSH6fQbKY7gUb6WTJNPvsegA76aF9oge8GiqBIaonq9+2Okj+4qw27QpHDosK0 Ofwd3mtLt11bezhiXbcOjtXCCNmZIAjOhqdVCezaNk9vB//3JgQItDVL9BUzMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=QzAY2NQg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-mumi-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-mumi-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715446454; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=JNztq7KXEiH9LX+fzRKblPDFYEdvBQ2N7bWz1cZgHAM=; b=J85ffw9H18PzUFY0Vq42Scp/37VVRJlPYi6x8lb67MGFfhQYDWE9ZBuKQQYH4/EOs0nzeR Zf/csT4MNCBj405dS5h0T5SCFf5XbjbpUcQEOjzvwDayQVKNkesu/UKpojXM1bE9RTuUaZ qzc0m+AsuXYb6csCvPkKoshJx+DNLDBAmiAyn/OmFbpCYVBDinjo1ZECiy9uTSkM4dVJTf WwJv9h0Fro73imA5IFKCKoAZsU5OX6Gcr7suuuCBJlfkzJev+I8zBNCEySHT9/0Cx6ZVox HJx+4OOLu5yPOM3dUK37cz2XzXnWM76RAh2NDqMzmd2+BLwEpSRv2nqpYE/2HQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EEDA225A0C for ; Sat, 11 May 2024 18:54:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5pz9-0000UA-Ac; Sat, 11 May 2024 12:54:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5pz2-0000Sm-5m for bug-mumi@gnu.org; Sat, 11 May 2024 12:54:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s5pz1-0002Ta-Tx for bug-mumi@gnu.org; Sat, 11 May 2024 12:54:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s5pz1-0000o2-8j for bug-mumi@gnu.org; Sat, 11 May 2024 12:54:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#70871: [PATCH] Show avatars from Libravatar. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: bug-mumi@gnu.org Resent-Date: Sat, 11 May 2024 16:54:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70871 X-GNU-PR-Package: mumi X-GNU-PR-Keywords: patch To: Felix Lechner Cc: 70871@debbugs.gnu.org Received: via spool by 70871-submit@debbugs.gnu.org id=B70871.17154464203061 (code B ref 70871); Sat, 11 May 2024 16:54:03 +0000 Received: (at 70871) by debbugs.gnu.org; 11 May 2024 16:53:40 +0000 Received: from localhost ([127.0.0.1]:49257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5pyd-0000nJ-KQ for submit@debbugs.gnu.org; Sat, 11 May 2024 12:53:40 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:43662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5pya-0000n1-1J for 70871@debbugs.gnu.org; Sat, 11 May 2024 12:53:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JNztq7KXEiH9LX+fzRKblPDFYEdvBQ2N7bWz1cZgHAM=; b=QzAY2NQgQolMUrqH44QNuDQxt5 2Lua3zU5+jv8oA1ClXGcO2FZeC6y6HO/Z+gpM71Xiw7uq/verp3GKk7EMepO3Oy8yrU5eQPvoKOTZ D0fYfFmlmp5kS4lLnVcnUcZlUmKYFdwPVVqbjs7NMUsWy79GhSyh8LtiGDugfWyiOH3Qqq2nbWmWI pv3elJ4zr/pQ4/6n92hzqK9uER++ruO39TJjZupOFQAcCK+9NaUD0+sIM07wSAtMFJWfF3H3evYsp YkBq3gvFvYTQ8QYJpeODhXoElzx44B2RwwcimNLqfM4DSxRf1eR17Pgmw06D60FhHBttthQArNXH6 I/wYXcwg==; Received: from [192.168.2.1] (port=33640 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1s5pvs-0000qX-1e; Sat, 11 May 2024 17:50:49 +0100 From: Arun Isaac In-Reply-To: <20240511032008.16270-1-felix.lechner@lease-up.com> References: <20240511032008.16270-1-felix.lechner@lease-up.com> Date: Sat, 11 May 2024 17:53:25 +0100 Message-ID: <87plts5lyy.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-mumi@gnu.org List-Id: "Bug reports for GNU Guix Mumi." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-mumi-bounces+larch=yhetil.org@gnu.org Sender: bug-mumi-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: EEDA225A0C X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 4.50 X-Spam-Score: 4.50 X-TUID: pESxluUAlRYE Hi Felix, Libravatar for mumi is a cool idea. I am happy to merge this patch with the suggested changes. There seems to be one more place (a total of three places) in mumi/web/view/html.scm where there is an avatar. Search for "string-upcase" in the code. Could you change that to Libravatar as well? And, while you are at it, would you mind deduplicating these three avatars into a single function or similar? Also, we now need to check for guile-avatar in configure.ac. BTW, what is patchwise.org? Did I miss some conversation about it? I was under the impression that we should be sending to bug-mumi@gnu.org. Thank you for the clarification! Regards, Arun