From: Arun Isaac <arunisaac@systemreboot.net>
To: Felix Lechner <felix.lechner@lease-up.com>
Cc: 70871@debbugs.gnu.org
Subject: bug#70871: [PATCH] Show avatars from Libravatar.
Date: Sat, 11 May 2024 17:53:25 +0100 [thread overview]
Message-ID: <87plts5lyy.fsf@systemreboot.net> (raw)
In-Reply-To: <20240511032008.16270-1-felix.lechner@lease-up.com>
Hi Felix,
Libravatar for mumi is a cool idea. I am happy to merge this patch with
the suggested changes.
There seems to be one more place (a total of three places) in
mumi/web/view/html.scm where there is an avatar. Search for
"string-upcase" in the code. Could you change that to Libravatar as
well? And, while you are at it, would you mind deduplicating these three
avatars into a single function or similar?
Also, we now need to check for guile-avatar in configure.ac.
BTW, what is patchwise.org? Did I miss some conversation about it? I was
under the impression that we should be sending to
bug-mumi@gnu.org. Thank you for the clarification!
Regards,
Arun
next parent reply other threads:[~2024-05-11 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240511032008.16270-1-felix.lechner@lease-up.com>
2024-05-11 16:53 ` Arun Isaac [this message]
2024-05-12 23:51 ` bug#70871: [PATCH] Show avatars from Libravatar Arun Isaac
2024-05-13 19:30 ` Felix Lechner via Bug-mumi via Bug reports for GNU Guix Mumi.
2024-05-19 2:50 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://issues.guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plts5lyy.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=70871@debbugs.gnu.org \
--cc=felix.lechner@lease-up.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).