unofficial mirror of bug-mumi@gnu.org
 help / color / mirror / Atom feed
From: noe--- via Bug-mumi via "Bug reports for GNU Guix Mumi." <bug-mumi@gnu.org>
To: 69381@debbugs.gnu.org
Cc: "Noé Lopez" <noelopez@free.fr>, "Tomas Volf" <~@wolfsden.cz>,
	"Felix Lechner" <felix.lechner@lease-up.com>
Subject: bug#69381: [PATCH] web: Use string to avoid losing unicode characters.
Date: Sat,  2 Nov 2024 01:07:28 +0100	[thread overview]
Message-ID: <20241102000730.3330-1-noe@xn--no-cja.eu> (raw)
In-Reply-To: <Zds6yhPkZ0Id6SAT@ws>

From: Noé Lopez <noelopez@free.fr>

I don’t really understand why the unicode characters were lost in the
first place, maybe something in the sanitize-response of (fibers web
server)?  Specifically, strings and procedures don’t take the same
path there.

* mumi/web/render.scm (render-html): Return string instead of procedure.
---
 mumi/web/render.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mumi/web/render.scm b/mumi/web/render.scm
index 168f3bc..c28a26f 100644
--- a/mumi/web/render.scm
+++ b/mumi/web/render.scm
@@ -105,8 +105,9 @@
 (define* (render-html sxml #:key (extra-headers '()))
   (values (append extra-headers
                   '((content-type . (text/html (charset . "utf-8")))))
-          (lambda (port)
-            (sxml->html sxml port))))
+          (call-with-output-string
+	    (lambda (port)
+              (sxml->html sxml port)))))
 
 (define (render-json json)
   (values '((content-type . (application/json)))
-- 
2.46.0





  parent reply	other threads:[~2024-11-02  1:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-25 13:04 bug#69381: mumi does not correctly display (some?) non-ascii characters Tomas Volf
2024-05-14 23:12 ` bug#69381: [PATCH] Convert HTML to UTF-8 ourselves. (Closes: #69381) Felix Lechner via Bug-mumi via Bug reports for GNU Guix Mumi.
2024-11-02  0:07 ` noe--- via Bug-mumi via Bug reports for GNU Guix Mumi. [this message]
2024-11-02  0:14 ` bug#69381: [PATCH] web: Use string to avoid losing unicode characters Noé Lopez via Bug-mumi via Bug reports for GNU Guix Mumi.
2024-11-02  2:23 ` Noé Lopez via Bug-mumi via Bug reports for GNU Guix Mumi.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://issues.guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241102000730.3330-1-noe@xn--no-cja.eu \
    --to=bug-mumi@gnu.org \
    --cc=69381@debbugs.gnu.org \
    --cc=felix.lechner@lease-up.com \
    --cc=noe@xn--no-cja.eu \
    --cc=noelopez@free.fr \
    --cc=~@wolfsden.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).