From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alison.schofield@intel.com>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS4983 192.55.52.0/24
X-Spam-Status: No, score=-3.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id A416C1F542
	for <meta@public-inbox.org>; Thu, 25 May 2023 18:56:25 +0000 (UTC)
Authentication-Results: dcvr.yhbt.net;
	dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=TZ58+EXJ;
	dkim-atps=neutral
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1685040985; x=1716576985;
  h=date:from:to:cc:subject:message-id:mime-version;
  bh=0t4DXr8dPvNwjc+CUWn741pSPmzXDWHomrGvSX5sPLk=;
  b=TZ58+EXJ5sLMKDTSu9fXxI/WuMl8ZHotoegJnSp3Uf57k0EnBWVZwfru
   1s7MZCINtgWZMlBe0/ztc2bp7JwrL+Tz/huhTDFrAVedPtRRqdAa/3mfY
   iYa+Ak81KQoV0Li3PkshrKJXUlc5VBsMHNB4236vEWGsznF1tp2w9rJlo
   RTdKd09MCEXIa5efnV8IRvTAE75wrCPyd5YHT5I5xBHgtfpjBoYkxouma
   9m3Hs+JByKMs/7mmW7RJ8gXvjCCi7AqLU0kgB3ARbnkw5CmQtG1/YtEcj
   bn6SWF6g+RNBsUEraCPjiA/IbPncPHkQuENJylsJzxtB27DTewE/xazFn
   g==;
X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="334336181"
X-IronPort-AV: E=Sophos;i="6.00,191,1681196400"; 
   d="scan'208";a="334336181"
Received: from orsmga005.jf.intel.com ([10.7.209.41])
  by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2023 11:56:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="879237752"
X-IronPort-AV: E=Sophos;i="6.00,191,1681196400"; 
   d="scan'208";a="879237752"
Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.212.187.234])
  by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2023 11:56:24 -0700
Date: Thu, 25 May 2023 11:56:23 -0700
From: Alison Schofield <alison.schofield@intel.com>
To: meta@public-inbox.org
Cc: Dave Hansen <dave.hansen@intel.com>
Subject: Threaded responses to queries (x86)
Message-ID: <ZG+vV5X5bSm2pQjk@aschofie-mobl2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
List-Id: <meta.public-inbox.org>

Hi,

I use Lore and find the threaded results of many Lore Lists useful.
Then there is x86. It doesn't have a list, so I query:

https://lore.kernel.org/all/?q=tc:x86@kernel.org

The result of that query is not threaded. Can I change my query to
get the threading, or, as Dave Hansen suggested below, does the
underlying code need to change.  

Dave's diff follows. I don't have a means of trying that out.

I appreciate help in improving the view of x86!

Thanks,
Alison


diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index a8f1ad17..6d4c148d 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -266,7 +266,8 @@ sub get_new {
 sub get_index {
	my ($ctx) = @_;
 	require PublicInbox::Feed;
-	if ($ctx->{env}->{QUERY_STRING} =~ /(?:\A|[&;])q=/) {
+	if (($ctx->{env}->{QUERY_STRING} =~ /(?:\A|[&;])q=/) &&
+	    ($ctx->{env}->{QUERY_STRING} !~ /(?:\A|[&;])dothread=1/)) {
 		require PublicInbox::SearchView;
 		PublicInbox::SearchView::sres_top_html($ctx);
 	} else {