From: Alison Schofield <alison.schofield@intel.com>
To: meta@public-inbox.org
Cc: Dave Hansen <dave.hansen@intel.com>
Subject: Threaded responses to queries (x86)
Date: Thu, 25 May 2023 11:56:23 -0700 [thread overview]
Message-ID: <ZG+vV5X5bSm2pQjk@aschofie-mobl2> (raw)
Hi,
I use Lore and find the threaded results of many Lore Lists useful.
Then there is x86. It doesn't have a list, so I query:
https://lore.kernel.org/all/?q=tc:x86@kernel.org
The result of that query is not threaded. Can I change my query to
get the threading, or, as Dave Hansen suggested below, does the
underlying code need to change.
Dave's diff follows. I don't have a means of trying that out.
I appreciate help in improving the view of x86!
Thanks,
Alison
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index a8f1ad17..6d4c148d 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -266,7 +266,8 @@ sub get_new {
sub get_index {
my ($ctx) = @_;
require PublicInbox::Feed;
- if ($ctx->{env}->{QUERY_STRING} =~ /(?:\A|[&;])q=/) {
+ if (($ctx->{env}->{QUERY_STRING} =~ /(?:\A|[&;])q=/) &&
+ ($ctx->{env}->{QUERY_STRING} !~ /(?:\A|[&;])dothread=1/)) {
require PublicInbox::SearchView;
PublicInbox::SearchView::sres_top_html($ctx);
} else {
next reply other threads:[~2023-05-25 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 18:56 Alison Schofield [this message]
2023-05-31 7:50 ` Threaded responses to queries (x86) Eric Wong
2023-05-31 12:05 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG+vV5X5bSm2pQjk@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=dave.hansen@intel.com \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).