From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.0.0.0/16 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from nautica.notk.org (ipv6.notk.org [IPv6:2001:41d0:1:7a93::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D12011F670 for ; Sun, 27 Feb 2022 07:24:09 +0000 (UTC) Received: by nautica.notk.org (Postfix, from userid 108) id C92FBC01B; Sun, 27 Feb 2022 08:24:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1645946646; bh=KUBU+ihfxggvvPuDqdm/FpU/l3g6DfZmG3mcIZbPIKY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ASOjjYRp27rEEijdDnZDAiSIHWmLjRCBev1YouzZLJZU3gavsNKgYWJFPgpJHvawD 1TWUWOGZas/YRmTgY/PdWaG75yCfXkntKX18KfUHVruDMLUaaXw5WodVfzB3FD5AmT VFj9+garkYc5IH/8XEsQNoTq6eGQiJsDMmVBdCG1Tdtlb6HXQYp52WKnJXfpBYjznt XDIIx/LWJxj8EXMQvo2TUr3jpzg6Qi5g5JRHoDMDBW+s2n9HUqwN5zIVYPHXU1PBkY 5tBCt1KXPDLeWfofbLUSlQ+yxMwdKr8ZssVcI/9L6PLC2gQVNhQhYIXctuTarkbL7Z y9sO/Gpo+AxUA== Received: from odin.codewreck.org (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 76B31C009; Sun, 27 Feb 2022 08:24:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1645946646; bh=KUBU+ihfxggvvPuDqdm/FpU/l3g6DfZmG3mcIZbPIKY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ASOjjYRp27rEEijdDnZDAiSIHWmLjRCBev1YouzZLJZU3gavsNKgYWJFPgpJHvawD 1TWUWOGZas/YRmTgY/PdWaG75yCfXkntKX18KfUHVruDMLUaaXw5WodVfzB3FD5AmT VFj9+garkYc5IH/8XEsQNoTq6eGQiJsDMmVBdCG1Tdtlb6HXQYp52WKnJXfpBYjznt XDIIx/LWJxj8EXMQvo2TUr3jpzg6Qi5g5JRHoDMDBW+s2n9HUqwN5zIVYPHXU1PBkY 5tBCt1KXPDLeWfofbLUSlQ+yxMwdKr8ZssVcI/9L6PLC2gQVNhQhYIXctuTarkbL7Z y9sO/Gpo+AxUA== Received: from localhost (odin.codewreck.org [local]) by odin.codewreck.org (OpenSMTPD) with ESMTPA id fd7690f7; Sun, 27 Feb 2022 07:24:01 +0000 (UTC) Date: Sun, 27 Feb 2022 16:23:46 +0900 From: Dominique Martinet To: Julien Moutinho Cc: Eric Wong , meta@public-inbox.org Subject: Re: [PATCH] t/lei-sigpipe: attempt to improve diagnostics for stuck test Message-ID: References: <20211208010730.f47xxgzj53nwgvja@sourcephile.fr> <20211208040836.GA27368@dcvr> <20211209013743.okzgim7bbrpahks7@sourcephile.fr> <20220217210233.GA31923@dcvr> <20220220013853.4vtvnyvpaichgpkm@sourcephile.fr> <20220222064424.GA11876@dcvr> <20220227041533.5dvcuuaffjhzrhuw@sourcephile.fr> <20220227064144.wo3flsc2xboks6sg@sourcephile.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220227064144.wo3flsc2xboks6sg@sourcephile.fr> List-Id: Hello, Julien Moutinho wrote on Sun, Feb 27, 2022 at 07:41:44AM +0100: > Le dim. 27 févr. 2022 05h15 +0100, Julien Moutinho a écrit : > > Yes, I'm using: > > $ nix-daemon --version > > > nix-daemon (Nix) 2.7.0pre20220127_558c4ee > Dominique reminded me that that fix was first intended for > `nix develop`, so I've asked whether it also applies to `nix build`: > https://github.com/NixOS/nix/pull/5683#issuecomment-1053239025 I've replied over there, I don't think leaked fd is a problem. However Julien's latest traces gave a good enough hint: the lei process that should die from sigpipe just didn't die... And surely enough, nix adds SIGPIPE to ignores. This can be confirmed by looking at SigIgn in /proc/xxx/status of one of the builder PIDs: # grep SigIgn /proc/3124202/status SigIgn: 0000000000001004 Where 0x1000 is the 13th bit: $ kill -l 13 PIPE Running tests manually won't inherit masked signals and thus won't reproduce. I guess we can now open a nix issue asking to reset signal handlers after fork, before executing its builder?... -- Dominique