From: Dominique Martinet <asmadeus@codewreck.org>
To: Eric Wong <e@80x24.org>
Cc: Julien Moutinho <julm+public-inbox@sourcephile.fr>,
meta@public-inbox.org
Subject: Re: FD_CLOEXEC w/ nix-shell [was: Test failures with 1.7.0]
Date: Wed, 2 Feb 2022 09:23:38 +0900 [thread overview]
Message-ID: <YfnPCo2fhyHuSxku@codewreck.org> (raw)
In-Reply-To: <20220201232740.M97535@dcvr>
Eric Wong wrote on Tue, Feb 01, 2022 at 11:27:40PM +0000:
> Is nix-shell setting FD_CLOEXEC on all FDs (>= 3) it creates?
> IMNSHO it should.
ugh, it definitely should -- in this case it looks like a plain fd
leak.
$ ls -l /proc/$$/fd/
total 0
lrwx------ 1 asmadeus users 64 Feb 2 09:17 0 -> /dev/pts/28
lrwx------ 1 asmadeus users 64 Feb 2 09:17 1 -> /dev/pts/28
lrwx------ 1 asmadeus users 64 Feb 2 09:17 2 -> /dev/pts/28
lrwx------ 1 asmadeus users 64 Feb 2 09:17 255 -> /dev/pts/28
lrwx------ 1 asmadeus users 64 Feb 2 09:17 4 -> '/tmp/nix-shell.vhDsb9 (deleted)'
$ ls -l /proc/self/fd/
total 0
lrwx------ 1 asmadeus users 64 Feb 2 09:17 0 -> /dev/pts/28
lrwx------ 1 asmadeus users 64 Feb 2 09:17 1 -> /dev/pts/28
lrwx------ 1 asmadeus users 64 Feb 2 09:17 2 -> /dev/pts/28
lr-x------ 1 asmadeus users 64 Feb 2 09:17 3 -> /proc/1220800/fd
lrwx------ 1 asmadeus users 64 Feb 2 09:17 4 -> '/tmp/nix-shell.vhDsb9 (deleted)'
nix-shell/nix shell don't seem to have the problem it's a 'nix develop'
bug, I'll follow it up with nix devs and get it fixed there.
(I don't have an opinion if you want to make your tests more robust, it
might be a good thing in general anyway)
Thanks for figuring this out!
--
Dominique
next prev parent reply other threads:[~2022-02-02 0:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 1:07 Test failures with 1.7.0 Julien Moutinho
2021-12-08 4:08 ` Eric Wong
2021-12-08 10:56 ` Dominique Martinet
2021-12-08 18:22 ` [PATCH] nodatacow: quiet chattr errors [was: Test failures with 1.7.0] Eric Wong
2021-12-08 21:14 ` Dominique Martinet
2021-12-08 22:01 ` Dominique Martinet
2022-01-30 21:49 ` Eric Wong
2022-01-30 23:18 ` Dominique Martinet
2022-01-31 2:03 ` Eric Wong
2022-01-31 3:34 ` Dominique Martinet
2022-02-01 1:27 ` Eric Wong
2021-12-09 1:37 ` Test failures with 1.7.0 Julien Moutinho
2021-12-09 2:53 ` Dominique Martinet
2022-02-01 9:37 ` Eric Wong
2022-02-01 23:27 ` FD_CLOEXEC w/ nix-shell [was: Test failures with 1.7.0] Eric Wong
2022-02-02 0:23 ` Dominique Martinet [this message]
2022-02-02 2:11 ` Dominique Martinet
2022-02-01 23:34 ` [PATCH] test_lei: use consistent locale for error messages Eric Wong
2022-02-17 21:02 ` [PATCH] t/lei-sigpipe: attempt to improve diagnostics for stuck test Eric Wong
2022-02-20 1:38 ` Julien Moutinho
2022-02-22 6:44 ` Eric Wong
2022-02-27 4:15 ` Julien Moutinho
2022-02-27 6:41 ` Julien Moutinho
2022-02-27 7:23 ` Dominique Martinet
2022-02-27 8:04 ` Julien Moutinho
2022-02-27 11:17 ` [PATCH] t/lei-sigpipe: ensure SIGPIPE is unblocked for this test Eric Wong
2022-03-11 10:42 ` [PATCH] t/lei-sigpipe.t: ensure SIGPIPE is not ignored instead of not blocked Julien Moutinho
2022-03-14 22:14 ` Eric Wong
2022-03-15 2:56 ` Julien Moutinho
2022-03-01 2:30 ` Test failures with 1.7.0 Julien Moutinho
2022-03-01 4:05 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfnPCo2fhyHuSxku@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=e@80x24.org \
--cc=julm+public-inbox@sourcephile.fr \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).