From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS16276 91.121.0.0/16 X-Spam-Status: No, score=-3.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from nautica.notk.org (nautica.notk.org [91.121.71.147]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E8C591F953 for ; Wed, 8 Dec 2021 22:02:05 +0000 (UTC) Received: by nautica.notk.org (Postfix, from userid 108) id 7EF47C01A; Wed, 8 Dec 2021 23:02:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1639000924; bh=N3cXCyXN4wyz4V7yEcGJ9pDiCGwf6JFkZejS8KaJYHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=But433MQJHvekktqf2Ejw80HrhMdoPEiLO/CgtOE4aim6kFqQe/uFN5x/gk7QYI2s 51tNPsXxh9QW9YZ7B0BaNcBmZqpJzQfncjnYQCYlSBWnzzpjkfNSLagtMNbf7C+nGv Y/26kqqvog1pFXg9K5LslHtmM/ZA4p6ePy5LYnykZA+T1jWCffX9oy97gVe+uxG02r CTFllg9hHHas66NhYybxquvwfwXdNaQCxlcWshJzZcmPE8V/s6pcMpxOaB7CAHc2wZ RpFTL0sZ32MjIMDRtpVTVy5+iaLGNfMgtvlBv4alj2eudYsmHWJYvfIr0NdIyHXJvL 6snFt2L9QLzZQ== Received: from odin.codewreck.org (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 26C79C009; Wed, 8 Dec 2021 23:02:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1639000924; bh=N3cXCyXN4wyz4V7yEcGJ9pDiCGwf6JFkZejS8KaJYHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=But433MQJHvekktqf2Ejw80HrhMdoPEiLO/CgtOE4aim6kFqQe/uFN5x/gk7QYI2s 51tNPsXxh9QW9YZ7B0BaNcBmZqpJzQfncjnYQCYlSBWnzzpjkfNSLagtMNbf7C+nGv Y/26kqqvog1pFXg9K5LslHtmM/ZA4p6ePy5LYnykZA+T1jWCffX9oy97gVe+uxG02r CTFllg9hHHas66NhYybxquvwfwXdNaQCxlcWshJzZcmPE8V/s6pcMpxOaB7CAHc2wZ RpFTL0sZ32MjIMDRtpVTVy5+iaLGNfMgtvlBv4alj2eudYsmHWJYvfIr0NdIyHXJvL 6snFt2L9QLzZQ== Received: from localhost (odin.codewreck.org [local]) by odin.codewreck.org (OpenSMTPD) with ESMTPA id a413a8be; Wed, 8 Dec 2021 22:01:59 +0000 (UTC) Date: Thu, 9 Dec 2021 07:01:44 +0900 From: Dominique Martinet To: Eric Wong Cc: Julien Moutinho , meta@public-inbox.org Subject: Re: [PATCH] nodatacow: quiet chattr errors [was: Test failures with 1.7.0] Message-ID: References: <20211208010730.f47xxgzj53nwgvja@sourcephile.fr> <20211208040836.GA27368@dcvr> <20211208182247.M197857@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: List-Id: Dominique Martinet wrote on Thu, Dec 09, 2021 at 06:14:36AM +0900: > I'll try giving it one, in my opinion it's more representative to test > with inline-c working. So giving tests a home appear to make another test hang (t/lei-refresh-mail-sync.t) I've run out of time, will provide more traces tonight > > Yes on tests requiring stderr to be empty. Below is a patch > > which should fix it; however it should only be calling chattr on > > btrfs mounts. > > I'll give this a try as well. This patch makes the tests pass as expected. > > You can also try: > > > > BTRFS_TESTDIR=/path/to/your/btrfs-mount prove -bvw t/nodatacow.t > > I'll try something similar as well. I can confirm this one works as well after installing chattr and running on btrfs, so there's no problem if mounts parsing is fixed. I'd say this hints at a problem so we're probably better off not silencing chattr warnings, but would also need to check if the chattr binary is present... Probably not worth the hassle, I don't know. > It turns out the other people with failing test are both using zfs, so > the last problem might be somewhat related; I'll give that a try too. Julien could also reproduce this one by running on ZFS, we'll provide more traces when we have them! -- Dominique