From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from mail-qt0-x243.google.com (mail-qt0-x243.google.com [IPv6:2607:f8b0:400d:c0d::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3ADE21F42D for ; Wed, 23 May 2018 21:51:41 +0000 (UTC) Received: by mail-qt0-x243.google.com with SMTP id h2-v6so30164565qtp.7 for ; Wed, 23 May 2018 14:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VynLHwvn1oYTyVzZF9fAcF7cVPDQIKLDORuv5nnHsf4=; b=g3qUva2uiAUwBWZrbVI+Nyz52yh5ZF1sE6OCQCkwwa7VsQ6WCpFHYijTJIvMBrwmGj AIO4hTwKbRajjbeTcfvztpXMjFiiPuPU1gsRSNS8wMc0th879VsvsvrC6Z9xbVeKwPDx 7RKs7wD1+GBEt+66YDeBEkCsSy7cxwCQA9dLg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VynLHwvn1oYTyVzZF9fAcF7cVPDQIKLDORuv5nnHsf4=; b=XX/E2mhvMNhd8kKvh7c1g2r1flhGNxPhIlUbRywkWu1MwPY5Xz8cGIwEJh39FoAtfR lpqapNpuG7Qyb7B1EbxOlsEZRHJ/oPluj5Vuuxv1ogKPEK/rPUd07+fMCjj+Tak7lolP 4OsdAG+3emiYhbNCbXNoFqbm186dye+AWNP+Lh1m2di56m1uGOTpHS0nyLnJykihhtqt yGtRrhGtvA3+iWHqb7dkKPOF+2qUQjlIIOMKDSyCc+6C221DHqun35GOh5xW60tr1FQc lCv3tShUQMoBHxDWnivzhpQEtzKrotsqDtQgMx1DsTlaKGcgCmu8LhoDWoWnjRAc1Fe4 HfAw== X-Gm-Message-State: ALKqPwdSkJXI28iddKQ154SPa1bQS5BiXFiD+/QvU91SSX1l3sclKWoD u5a64gfqUR3PUzeLGYddwDo+YZuNsoq72k7RJeOy7A== X-Google-Smtp-Source: ADUXVKJU8+iOVvGUA1Ul7c0v1n2NM5AAW6rQHDgrj+J3rrKs5Jl69YIemNMrE1222oeUwpZ8CVe6KRDLU0nIPIWimlM= X-Received: by 2002:aed:2ce7:: with SMTP id g94-v6mr4490539qtd.298.1527112300052; Wed, 23 May 2018 14:51:40 -0700 (PDT) MIME-Version: 1.0 References: <20180511192018.6432-1-e@80x24.org> <20180511193801.GA1940@dcvr> <20180516051206.GA16155@dcvr> In-Reply-To: <20180516051206.GA16155@dcvr> From: Konstantin Ryabitsev Date: Wed, 23 May 2018 17:51:28 -0400 Message-ID: Subject: Re: [PATCH 0/4] test fixes for latest CPAN modules To: Eric Wong Cc: meta@public-inbox.org Content-Type: text/plain; charset="UTF-8" List-Id: On Wed, 16 May 2018 at 01:12, Eric Wong wrote: > Ah, took me a while to realize what was going on :x > The Xapian files processes were lacking O_CLOEXEC and FD_CLOEXEC > usage and this was a problem in Xapian >= 1.2.21 && <= 1.2.24 > Relevant Xapian commit should be e953a10dc4f0cc8e604fd2082c87b638c6a3382b > ("Set CLOEXEC on the lock file fd and pipe") > I suspect the following patch works around the problem with or > without parallel=0 > --- a/t/v2mirror.t > +++ b/t/v2mirror.t > @@ -50,7 +50,7 @@ for my $i (1..9) { > $mime->header_set('Subject', "subject = $i"); > ok($v2w->add($mime), "add msg $i OK"); > } > -$v2w->barrier; > +$v2w->done; > my %opts = ( > LocalAddr => '127.0.0.1', > Can you confirm? I don't have 1.2.22 handy anymore, but I > reported this problem and got Olly to fix it back in 2016. Sorry I missed your reply! Yes, you're correct -- applying the above patch makes all tests pass. I'm guessing it's also the reason why I'm seeing the "already locked" error in my other tests, too: $ public-inbox-index /var/lib/public-inbox/meta.git Exception: Unable to get write lock on /var/lib/public-inbox/meta.git/public-inbox/xapian15: already locked Hope this helps. -K