From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 0/4] test fixes for latest CPAN modules
Date: Wed, 23 May 2018 17:51:28 -0400 [thread overview]
Message-ID: <CAMwyc-RyEzoAXY0U6C0n_72MmYzMtCz2Z04AQaRZPjH2T1oXjw@mail.gmail.com> (raw)
In-Reply-To: <20180516051206.GA16155@dcvr>
On Wed, 16 May 2018 at 01:12, Eric Wong <e@80x24.org> wrote:
> Ah, took me a while to realize what was going on :x
> The Xapian files processes were lacking O_CLOEXEC and FD_CLOEXEC
> usage and this was a problem in Xapian >= 1.2.21 && <= 1.2.24
> Relevant Xapian commit should be e953a10dc4f0cc8e604fd2082c87b638c6a3382b
> ("Set CLOEXEC on the lock file fd and pipe")
> I suspect the following patch works around the problem with or
> without parallel=0
> --- a/t/v2mirror.t
> +++ b/t/v2mirror.t
> @@ -50,7 +50,7 @@ for my $i (1..9) {
> $mime->header_set('Subject', "subject = $i");
> ok($v2w->add($mime), "add msg $i OK");
> }
> -$v2w->barrier;
> +$v2w->done;
> my %opts = (
> LocalAddr => '127.0.0.1',
> Can you confirm? I don't have 1.2.22 handy anymore, but I
> reported this problem and got Olly to fix it back in 2016.
Sorry I missed your reply! Yes, you're correct -- applying the above patch
makes all tests pass. I'm guessing it's also the reason why I'm seeing the
"already locked" error in my other tests, too:
$ public-inbox-index /var/lib/public-inbox/meta.git
Exception: Unable to get write lock on
/var/lib/public-inbox/meta.git/public-inbox/xapian15: already locked
Hope this helps.
-K
next prev parent reply other threads:[~2018-05-23 21:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 19:20 [PATCH 0/4] test fixes for latest CPAN modules Eric Wong
2018-05-11 19:20 ` [PATCH 1/4] content_id: workaround quote handling change in Email::* modules Eric Wong
2018-05-11 19:20 ` [PATCH 2/4] convert+compact: fix when running without ~/.public-inbox/config Eric Wong
2018-05-11 19:20 ` [PATCH 3/4] t/v2mda: setup emergency Maildir for test Eric Wong
2018-05-11 19:20 ` [PATCH 4/4] t/search: quiet warning from Encode.pm Eric Wong
2018-05-11 19:27 ` [PATCH 0/4] test fixes for latest CPAN modules Konstantin Ryabitsev
2018-05-11 19:38 ` Eric Wong
2018-05-11 19:50 ` Konstantin Ryabitsev
2018-05-16 5:12 ` Eric Wong
2018-05-23 21:51 ` Konstantin Ryabitsev [this message]
2018-05-24 8:41 ` Eric Wong
2018-05-24 15:15 ` Konstantin Ryabitsev
2018-05-30 11:57 ` Eric Wong
2018-05-30 15:28 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMwyc-RyEzoAXY0U6C0n_72MmYzMtCz2Z04AQaRZPjH2T1oXjw@mail.gmail.com \
--to=konstantin@linuxfoundation.org \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).