From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <robh@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS2044 198.145.29.0/24
X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
	SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham
	autolearn_force=no version=3.4.2
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id EE2D71F9FC
	for <meta@public-inbox.org>; Tue,  9 Nov 2021 00:38:38 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 9018261165
	for <meta@public-inbox.org>; Tue,  9 Nov 2021 00:38:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1636418318;
	bh=j4mCvT67dJs6+1ZoxBOukPueWrD2Yk04HXd/IV/IWf8=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=iUK3ok1QpqUOT31GPz8xCiyiNtGnpmymC0mYgvcdEJbmRxBKx+t94tDCFvd7KP9tz
	 8IK29Rg+eFp/SIIDNbobNYO+X1O9BhIAcu9X93Oi+U9bpgHkF7QJCXDVm+UvQ31CkO
	 Y4gnDArh0G7Q4lylzOP2ZqNXnOqe2vxaWLM0EqVkpZXPcyUred0uNT56Y4PMqckPz1
	 G0TJvDVs9ICDTlauHickfYpnMv5F4GR25gAGVRptY0GF0Dhult+5zMmtqQwL7So891
	 XDiPMEzF4t6K+uymJZz1AMBqWkMh2TLdAhgecbQPU5vqcVt21RnpxnRY2rBZPHeaQ8
	 YRZwmxPHqtL/Q==
Received: by mail-ed1-f41.google.com with SMTP id r12so69435525edt.6
        for <meta@public-inbox.org>; Mon, 08 Nov 2021 16:38:38 -0800 (PST)
X-Gm-Message-State: AOAM533Bd3VFeB5FytwVN0qJPHC8E+/nFPwNDA9/FG6rnFu5+j9JsaVv
	7ik/aWJwzocsr5ftWNlTKQjX/Zq1tWqbDiM9Tw==
X-Google-Smtp-Source: ABdhPJyOZfSVs5m9C+kr2Sx8131XUZ9EddkYfYtocHv/xkAhrrR5oCJ3rQ81CbLQnggO41j7v8CvF6JG6aXJAsnQLAw=
X-Received: by 2002:a17:907:a411:: with SMTP id sg17mr4220885ejc.84.1636418317082;
 Mon, 08 Nov 2021 16:38:37 -0800 (PST)
MIME-Version: 1.0
References: <lorelei.part1.202111051304.mdtebsxahljcrxak@meerkat.local>
 <CAL_JsqJBh1O3H2-P07AHzVq0x89BoP_N6P=rT5up6=3QyF_B0Q@mail.gmail.com>
 <20211108202204.q5zg6bachnvbjlnx@meerkat.local> <CAL_Jsq+XtqOEF7p5zbO2O2YdHPr61+ahPgdDhH7_XMwyuDuc2w@mail.gmail.com>
 <20211108212714.GA13642@dcvr>
In-Reply-To: <20211108212714.GA13642@dcvr>
From: Rob Herring <robh@kernel.org>
Date: Mon, 8 Nov 2021 18:38:25 -0600
X-Gmail-Original-Message-ID: <CAL_Jsq+aqDmpxUHsw844xS8f6WRX3gcvt7GQhf2XB7-Lb=Yx8Q@mail.gmail.com>
Message-ID: <CAL_Jsq+aqDmpxUHsw844xS8f6WRX3gcvt7GQhf2XB7-Lb=Yx8Q@mail.gmail.com>
Subject: Re: [PATCH] searchidx: index "diff --git a/... b/..." headers
To: Eric Wong <e@80x24.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>, meta@public-inbox.org
Content-Type: text/plain; charset="UTF-8"
List-Id: <meta.public-inbox.org>

On Mon, Nov 8, 2021 at 3:27 PM Eric Wong <e@80x24.org> wrote:
>
> Rob Herring <robh@kernel.org> wrote:
> > On Mon, Nov 8, 2021 at 2:22 PM Konstantin Ryabitsev
> > > I think 's:patch AND nq:diff' is a good option here.
> >
> > Not even close really. That mainly finds my replies with 'diff' in
> > them. I'm not sure why, but it misses most actual patches:
> >
> > https://lore.kernel.org/all/?q=s%3Apatch+nq%3Adiff+f%3Arobh%40kernel.org
>
> Actually, it looks like nq:diff never works.  The diff indexer
> skips right over 'diff --git a/... b/...' lines :x

Never works for 'diff' being a patch? Because it works very well
finding all the other cases.

> The following should fix it, but reindexing is necessary.
> ---------8<----------
> Subject: [PATCH] searchidx: index "diff --git a/... b/..." headers
>
> While we do detailed indexing of git diffs, the header itself
> was failing and queries like 'nq:diff' would not work.

Any thoughts on supporting an 'is a patch' type query?

Rob