From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <varuncvarada@gmail.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
	RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.2
Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 824481F55B
	for <meta@public-inbox.org>; Fri,  5 Jun 2020 20:23:02 +0000 (UTC)
Received: by mail-oo1-xc2f.google.com with SMTP id 7so2240119oof.8
        for <meta@public-inbox.org>; Fri, 05 Jun 2020 13:23:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:from:date:message-id:subject:to;
        bh=0x2/K3LpAIQ/elLhtkeiUssqeK/M8VWwfOzYurjpF3c=;
        b=I8TfQwhycvqrHt16tTHTg7/chJtI/u5PuSa4kb23K4kzJCM8z1TaeDpxJZpvjrxaL8
         EbmBPHLaM2z3QO08GffeKynXrL90E7uIPMAQGvfg47cxTEdMJyRADmgUwutA6S9mxeQq
         nGwi5TH8103CJe0lZUdZAFpAxIHOViMPwra6+fwZJgn72VnArR5oxxhf9VJQ7talKxAE
         hcA8auhORRxdcQK/M/azRW2abwbAQzTwa1J8iePs9rthLUbu533T/7nF74NisBZQZEd4
         TwxGbsAeNZhIb4iAo8hNKtmXU3bSzuj3i+YIdyzbUHosRLZO/VwDlAqGNYEFqXx2qGcz
         SRDw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=0x2/K3LpAIQ/elLhtkeiUssqeK/M8VWwfOzYurjpF3c=;
        b=RiW+jcSzKLWcnQ69rf2rPKORfm+rOq+A5mpGX2+jr17xvSUSaj8kHfs08hCdbx/R0J
         BaTo0Fm3PeK+nfVks2Zal6Q1T2oeXFg60h7cZBTqHoKPdB3uiEAYa+BXK9AVqX6sdBEa
         4yZXA78SOW+T3nfeL2HFadH5lpSE415NiCBowH3mdvbb50/AMPnYEyew7mvEXiZVlNAe
         Ym8B6mN7XbBs3qmL96fS/r+t6PV3VvoLLiznxVsCyWBSgfSuos8ugNOeT8x1W3dSTh2c
         /7WO7WUpMKYUlgeMR/i6p/Y6m/1Z/KuKh+UAEhPZQENoNGb6OkoDTCcrYXMKDEZvXs/7
         OewA==
X-Gm-Message-State: AOAM532LIRQF5jNW5lt0uMSHRzVXfknnsXdYakjGdvR81UQXsn+BjnPC
	+39ocKBVXwJ36AKBX0H6xKrym90yDCKnSnD5hgCX+HdWzjqaGw==
X-Google-Smtp-Source: ABdhPJxUchiuTUDvz6nbw7FCLTarmo486COiQgfVx484ntyDMqAgED+kkwh9UIk4C978zYAAKkYR5b57epZYRqE10Q4=
X-Received: by 2002:a4a:6812:: with SMTP id p18mr9029285ooc.45.1591388581170;
 Fri, 05 Jun 2020 13:23:01 -0700 (PDT)
MIME-Version: 1.0
From: Varun Varada <varuncvarada@gmail.com>
Date: Fri, 5 Jun 2020 15:22:50 -0500
Message-ID: <CAD2i4DDD8XCPQ2t61VJ-f4BSGkktcBf2O89K1ARGv=C1f+reqw@mail.gmail.com>
Subject: [Patch] Update 24-hour times to use two digits for the hour
To: meta@public-inbox.org
Content-Type: text/plain; charset="UTF-8"
List-Id: <meta.public-inbox.org>

Hello,

Here is a patch to update the timestamps displayed to have 2 digits
for the hour when since it is using the 24-hour clock:

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 0bc2b06e..def138c6 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -178,7 +178,7 @@ sub nr_to_s ($$$) {
 }

 # human-friendly format
-sub fmt_ts ($) { strftime('%Y-%m-%d %k:%M', gmtime($_[0])) }
+sub fmt_ts ($) { strftime('%Y-%m-%d %H:%M', gmtime($_[0])) }

 # Displays the text of of the message for /$INBOX/$MSGID/[Tt]/ endpoint
 # this is already inside a <pre>
diff --git a/lib/PublicInbox/WwwStatic.pm b/lib/PublicInbox/WwwStatic.pm
index 3c933156..c3b29c49 100644
--- a/lib/PublicInbox/WwwStatic.pm
+++ b/lib/PublicInbox/WwwStatic.pm
@@ -294,12 +294,12 @@ sub dir_response ($$$) {
  } else {
  next;
  }
- # 54 = 80 - (SP length(strftime(%Y-%m-%d %k:%M)) SP human_size)
+ # 54 = 80 - (SP length(strftime(%Y-%m-%d %H:%M)) SP human_size)
  $hsize = sprintf('% 8s', $hsize);
  my $pad = 54 - length($name);
  $pad = 1 if $pad <= 0;
  $entry .= qq(<a\nhref="$href">$name</a>) . (' ' x $pad);
- $mtime = strftime('%Y-%m-%d %k:%M', gmtime($mtime));
+ $mtime = strftime('%Y-%m-%d %H:%M', gmtime($mtime));
  $entry .= $mtime . $hsize;
  }

diff --git a/xt/msgtime_cmp.t b/xt/msgtime_cmp.t
index 95d7c64b..6f4ca198 100644
--- a/xt/msgtime_cmp.t
+++ b/xt/msgtime_cmp.t
@@ -36,7 +36,7 @@ sub quiet_is_deeply ($$$$$) {
  ($old->[0] != $cur->[0]) ||
  ($old->[1] != $cur->[1]))) {
  for ($cur, $old) {
- $_->[2] = strftime('%Y-%m-%d %k:%M:%S', gmtime($_->[0]))
+ $_->[2] = strftime('%Y-%m-%d %H:%M:%S', gmtime($_->[0]))
  }
  is_deeply($cur, $old, "$func $oid");
  diag('got: ', explain($cur));


Regards,
Varun