When dupe-finder was switched from ->search->{over_ro} to ->over, the database handle was dropped. Restore it because a spot downstream uses it. Fixes: 73e3a6ed6e95adc6 (use more idiomatic internal API for ->over access) --- scripts/dupe-finder | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/dupe-finder b/scripts/dupe-finder index 7b490cbb..deeb0d6f 100644 --- a/scripts/dupe-finder +++ b/scripts/dupe-finder @@ -22,6 +22,7 @@ if (index($repo, '@') > 0) { $ibx or die "No inbox"; $ibx->search or die "search not available for inbox"; my $over = $ibx->over; +my $dbh = $over->dbh; sub emit ($) { my ($nums) = @_; base-commit: 8080720d242f7450ecaf7e962c0f4ac9c5c2115b -- 2.28.0
Kyle Meyer <kyle@kyleam.com> wrote:
> When dupe-finder was switched from ->search->{over_ro} to ->over, the
> database handle was dropped. Restore it because a spot downstream
> uses it.
>
> Fixes: 73e3a6ed6e95adc6 (use more idiomatic internal API for ->over access)
Thanks, I haven't used this since 2018 :x
Btw, is this tool something you find useful? I'll consider
making it part of a local tool I'm brainstorming...
Eric Wong writes: > Btw, is this tool something you find useful? I'll consider > making it part of a local tool I'm brainstorming... I found it very helpful when I made a mistake with a custom filter I use to remove the footer at <https://yhetil.org/notmuch>. The footer used by the list changed at some point. I updated the filter and restarted -watch without thinking about what would happen with the messages that were already in the maildir. (I keep messages around for ~10 days before deleting them.) That led to a good number of duplicates. Aside from that, I've run it a few times over the inboxes at <https://yhetil.org>, and it's turned up a couple of hits. So, I've found it useful, but in the hosting context.