From: Kyle Meyer <kyle@kyleam.com>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: [PATCH] doc: lei: favor "-o format:$PATHNAME" over "-f"
Date: Mon, 22 Feb 2021 22:45:52 -0500 [thread overview]
Message-ID: <87wnuzsaz3.fsf@kyleam.com> (raw)
In-Reply-To: <20210220080716.GA30570@dcvr>
Eric Wong writes:
> Maybe not dropped, but probably tweaked for DWIM-ness.
>
> Maybe:
>
> If somebody wants a Maildir to dump JSON search results in they
> could use "-o ./json" or "-o json/" or "-o /path/to/json".
>
> "-o json" (no slashes or colons) would mean JSON output to stdout.
>
> But then, "json" could be the name of an existing directory,
> so if it exists...
>
> Part of me thinks its too magical...
That's kind of my feeling, though I suspect that would at least
consistently do what I mean and be unsurprising.
> On the other hand, maybe only requiring the colon: "-o json:"
> is enough to disambiguate and isn't too much typing.
Yeah, I don't mind that, but I guess that almost gets us back to "-o
json:-". Then again, I didn't mind that either or really any of the
options proposed in this thread :)
Anyway, no matter where this lands, the manpages should switch to
using/recommending the <format>: prefix, so here's a patch for that.
-- >8 --
Subject: [PATCH] doc: lei: favor "-o format:$PATHNAME" over "-f"
The --format argument is redundant and may be dropped entirely.
Update the lei manpages to prefer the format prefix.
cf. https://public-inbox.org/meta/20210217044032.GA17934@dcvr/
---
Documentation/lei-import.pod | 10 ++++++----
Documentation/lei-overview.pod | 4 ++--
Documentation/lei-q.pod | 20 ++++++++++++++------
3 files changed, 22 insertions(+), 12 deletions(-)
diff --git a/Documentation/lei-import.pod b/Documentation/lei-import.pod
index 14ca2d45d6d8bfa1..2051e6bc86c5fd36 100644
--- a/Documentation/lei-import.pod
+++ b/Documentation/lei-import.pod
@@ -11,8 +11,10 @@ lei import [OPTIONS] --stdin
=head1 DESCRIPTION
Import messages into the local storage of L<lei(1)>. C<LOCATION> is a
-source of messages: a directory (Maildir) or a file (whose format is
-specified via C<--format>).
+source of messages: a directory (Maildir) or a file. For a regular
+file, the location must have a C<E<lt>formatE<gt>:> prefix specifying
+one of the following formats: C<eml>, C<mboxrd>, C<mboxcl2>,
+C<mboxcl>, or C<mboxo>.
TODO: Update when URL support is added.
@@ -22,8 +24,8 @@ TODO: Update when URL support is added.
=item -f MAIL_FORMAT, --format=MAIL_FORMAT
-Message input format: C<eml>, C<mboxrd>, C<mboxcl2>, C<mboxcl>,
-C<mboxo>.
+Message input format. Unless messages are given on C<stdin>, using a
+format prefix with C<LOCATION> is preferred.
=item --stdin
diff --git a/Documentation/lei-overview.pod b/Documentation/lei-overview.pod
index 840d011b27adb088..62b62280ad2ddd69 100644
--- a/Documentation/lei-overview.pod
+++ b/Documentation/lei-overview.pod
@@ -16,7 +16,7 @@ L<public-inbox-v2-format(5)>.
=over
-=item $ lei import --format=mboxrd t.mbox
+=item $ lei import mboxrd:t.mbox
Import the messages from an mbox into the local storage.
@@ -64,7 +64,7 @@ Search for messages whose subject includes "lei" and "skeleton".
Do the same, but also report unmatched messages that are in the same
thread as a matched message.
-=item $ lei q -t -o t.mbox -f mboxcl2 --mua=mutt s:lei s:skeleton
+=item $ lei q -t -o mboxcl2:t.mbox --mua=mutt s:lei s:skeleton
Write mboxcl2-formatted results to t.mbox and enter mutt to view the
file by invoking C<mutt -f %f>.
diff --git a/Documentation/lei-q.pod b/Documentation/lei-q.pod
index c8df6fc7244bfae6..75fdc613579cdc18 100644
--- a/Documentation/lei-q.pod
+++ b/Documentation/lei-q.pod
@@ -26,17 +26,25 @@ Read search terms from stdin.
=item -o MFOLDER, --output=MFOLDER, --mfolder=MFOLDER
-Destination for results (e.g., C<path/to/Maildir> or - for stdout).
+Destination for results (e.g., C<path/to/Maildir> or
+C<mboxcl2:path/to/mbox>). The format can be specified by adding a
+C<E<lt>formatE<gt>:> prefix with any of these values: C<maildir>,
+C<mboxrd>, C<mboxcl2>, C<mboxcl>, C<mboxo>, C<json>, C<jsonl>, or
+C<concatjson>.
+
+TODO: Provide description of formats?
+
+When a format isn't specified, it's chosen based on the destination.
+C<json> is used for the default destination (stdout), and C<maildir>
+is used for an existing directory or non-existing path.
Default: -
=item -f FORMAT, --format=FORMAT
-Format of results: C<maildir>, C<mboxrd>, C<mboxcl2>, C<mboxcl>,
-C<mboxo>, C<json>, C<jsonl>, or C<concatjson>. The default format
-used depends on C<--output>.
-
-TODO: Provide description of formats?
+Format of results. This option exists as a convenient way to specify
+the format for the default stdout destination. Using a C<format:>
+prefix with the C<--output> destination is preferred otherwise.
=item --pretty
base-commit: c1ad789a90c274f9912d53bb1c7f1a3cc07cb233
--
2.30.1
next prev parent reply other threads:[~2021-02-23 3:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 4:40 does "lei q" --format/-f need to exist? Eric Wong
2021-02-18 5:28 ` Kyle Meyer
2021-02-18 12:07 ` Eric Wong
2021-02-19 3:10 ` Kyle Meyer
2021-02-19 11:13 ` Eric Wong
2021-02-19 13:47 ` Kyle Meyer
2021-02-19 19:06 ` Eric Wong
2021-02-20 7:12 ` Kyle Meyer
2021-02-20 8:07 ` Eric Wong
2021-02-23 3:45 ` Kyle Meyer [this message]
2021-02-23 6:03 ` [PATCH] doc: lei: favor "-o format:$PATHNAME" over "-f" Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnuzsaz3.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).