Re: Warnings from git fsck after lkml import

[ebiederm@xmission.com (Eric W. Biederman)]

ebiederm@xmission.com (Eric W. Biederman) writes:

> Eric Wong <e@80x24.org> writes:
>
>> "Eric W. Biederman" <ebiederm@xmission.com> wrote:
>>> It looks like public-inbox has some challenges when importing some
>>> questionable emails.  The import of lkml has resulted in several commits
>>> with bad dates that git fsck complains about.  I have previously
>>> reported this to Konstantin Ryabitsev who maintains kernel.org but since
>>> I have not seen any discussion of this I thought I should report it
>>> directly here as well.
>>
>> Thanks for bringing this up publically.
>>
>> Yes, I early during v2 development I noticed old mails had some
>> -1400 timezone values (but the furthest is -1200).  I opted to
>> attempt to preserve the wonky timezones since fast-import
>> happily accepts -1400 and I didn't anticipate problems...
>
> I think 0.git was generated after your earlier fix.
>
> Looking at the commits in question this is a different issue.
> On some of the later ones I am really not certain what it is
> but here is a representative sample you can look at.

Except below is looking at the pretty output of git show.
To actually see the problem git show --format=raw is needed.

Which for commit 59173dc1fe67b113ace4ce83e7f522414b3e0404
shows me:
author Dieter Ferdinand <dieter.ferdinand@gmx.de> 1166001998 +1

Which makes it clear the ``timezone'' was passed straight through
without modification.  The date in the email was: "Date: Wed, 13 Dec 2006 10:26:38 +1"

And the problem is the timezone is not a 4 byte number.  I see the same
pattern with the rest of the bad time zone warnings.

So it should be straight forward if the timezone is not 4 digits to just not pass
the time zone through.

Eric