From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyle@kyleam.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS11403 64.147.108.0/24
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
	SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 599681F487
	for <meta@public-inbox.org>; Sat,  4 Apr 2020 04:58:54 +0000 (UTC)
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
	by pb-smtp2.pobox.com (Postfix) with ESMTP id 896634F11B
	for <meta@public-inbox.org>; Sat,  4 Apr 2020 00:58:52 -0400 (EDT)
	(envelope-from kyle@kyleam.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to
	:subject:date:message-id:mime-version:content-type; s=sasl; bh=f
	zIYFxaemXWCVBw3VTgRdwxIGgc=; b=gAokhsd3uTvCU2O6tf6lV7SdzUn1ZtnwB
	dfrupbHjK6zCNr/gjgIqWRS8di7D2D5ki5X742rqxP8XNrv2LHOKSs+QYPhXkqXh
	ndSj51CwlqfTGFLG7mQ7iHPDupn2tL9ywWeE+4D7OjHZKKjAGLGFj29jj/bU/Tr+
	v3r950SC1w=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
	by pb-smtp2.pobox.com (Postfix) with ESMTP id 80B534F11A
	for <meta@public-inbox.org>; Sat,  4 Apr 2020 00:58:52 -0400 (EDT)
	(envelope-from kyle@kyleam.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com;
 h=from:to:subject:date:message-id:mime-version:content-type; s=mesmtp;
 bh=GPBr1p0GIg72032C3lFOZGRGOzHaGneKNJ2h58nPKJM=;
 b=PFdSVn9UPSqXmQAoDK2dtXdXY6+6se3QF/5AViy2MHSCNvSvH05N24TXdcs0ikZip+cELX0BGjk7d7qtgGR2+5fLyYyS6nqm7JIVE3WCt6vDJAwVMf+FVRGP1bP9ek7ZknXbWyDH9CT+079OZtQWTC0c8bpUMRSjz3yOTYu+x58=
Received: from localhost (unknown [45.33.91.115])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by pb-smtp2.pobox.com (Postfix) with ESMTPSA id EECB54F119
	for <meta@public-inbox.org>; Sat,  4 Apr 2020 00:58:51 -0400 (EDT)
	(envelope-from kyle@kyleam.com)
From: Kyle Meyer <kyle@kyleam.com>
To: meta@public-inbox.org
Subject: From-munge not being reversed on mbox import
Date: Sat, 04 Apr 2020 04:58:51 +0000
Message-ID: <87lfnb3kz8.fsf@kyleam.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID:
 FA690608-7630-11EA-A570-D1361DBA3BAF-24757444!pb-smtp2.pobox.com
List-Id: <meta.public-inbox.org>

I'm feeding mbox files created with Konstantin Ryabitsev's
list-archive-maker.py script [^1] to import_vger_from_mbox.  Looking
through the result, I noticed some ">From" lines.  Here's an example:

  https://yhetil.org/orgmode/871rpt9zc4.fsf@kyleam.com/

If I'm following the code correctly, that leads to an import_mbox call,
which in turn calls mb_add:

   sub mb_add ($$$$) {
       my ($im, $variant, $filter, $msg) = @_;
       $$msg =~ s/(\r?\n)+\z/$1/s;
       my $mime = PublicInbox::MIME->new($msg);
       if ($variant eq 'mboxrd') {
               $$msg =~ s/^>(>*From )/$1/sm;
       } elsif ($variant eq 'mboxo') {
               $$msg =~ s/^>From /From /sm;
       }
   [...]

So, it appears the ">From" _should_ be getting reversed.  To eliminate
any stupid things I may have done when creating the archive, I looked
for a message on meta that has an in-body line starting with "From" and
found

  https://public-inbox.org/meta/20200121222924.ioz5ve2sg65zcuoy@chatter.i7.local/

So I downloaded the public-inbox generated mbox and fed it to
import_vger_from_mbox:

  curl -s https://public-inbox.org/meta/20200121222924.ioz5ve2sg65zcuoy@chatter.i7.local/t.mbox.gz \
   | zcat | scripts/import_vger_from_mbox testing emacs-orgmode@gnu.org ~/inboxes/testing

That too leaves a ">From" in the body:

  https://yhetil.org/testing/20200121222924.ioz5ve2sg65zcuoy@chatter.i7.local/

Any idea what's going wrong here?


[^1]: https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/plain/list-archive-maker.py