From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyle@kyleam.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS16276 188.165.0.0/16
X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,
	SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham
	autolearn_force=no version=3.4.2
Received: from out2.migadu.com (out2.migadu.com [188.165.223.204])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id E83731F727
	for <meta@public-inbox.org>; Mon, 20 Jun 2022 20:01:37 +0000 (UTC)
Authentication-Results: dcvr.yhbt.net;
	dkim=pass (2048-bit key; unprotected) header.d=kyleam.com header.i=@kyleam.com header.b="vepIWixL";
	dkim-atps=neutral
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1;
	t=1655755295;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uUj6FkjPD/yPZ3DYWRJbHKsoodT/7f+9sjr0xTuXF8E=;
	b=vepIWixLSyhZIS1C+3/jPGhRRZXA9X5Sx8DZbOpqFmud78e7QxpqUPe0GtbRX7MivSW8rU
	6YFrjcNNWsdDuK5pfIeL2p/gGAU07rbMeBx0YnHrxlnqikcq2TXDFAs70Yt3ThVTr1G0hT
	d3RK3oEVPNZgLqSsTCbh3OvgCFnyg1D5s2auW0CgocUBu4woVxue5KsMP6jyPb8rF+bdaU
	5NRVuFRyvZjiwsk3k4deNGyJL+Zt4mBIITqFujFWXyPYFyLiKjzkMk9G29a7Cfe/1thVUV
	elrUJDaeA8KRIUvOCl7SfIWZRAvSSf5hHF+oL/Hw9YjLYqkzCZZsUQhj6W3vJg==
From: Kyle Meyer <kyle@kyleam.com>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 2/3] search: support "patchid:" prefix (git patch-id
 --stable)
In-Reply-To: <20220620192730.550803-3-e@80x24.org>
References: <20220620192730.550803-1-e@80x24.org>
 <20220620192730.550803-3-e@80x24.org>
Date: Mon, 20 Jun 2022 16:01:33 -0400
Message-ID: <87letrt882.fsf@kyleam.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: kyleam.com
List-Id: <meta.public-inbox.org>

Eric Wong writes:

> This allows easy searching via patch-id from a git commit.

Neat.  I played around a bit with this locally, and it seems to be
working nicely.

> diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
> index 523003b3..6f9fdde1 100644
> --- a/lib/PublicInbox/Search.pm
> +++ b/lib/PublicInbox/Search.pm
> @@ -1,4 +1,4 @@
> -# Copyright (C) 2015-2021 all contributors <meta@public-inbox.org>
> +# Copyright (C) all contributors <meta@public-inbox.org>
>  # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
>  # based on notmuch, but with no concept of folders, files or flags
>  #
> @@ -118,9 +118,10 @@ my %bool_pfx_external = (
>  	dfpre => 'XDFPRE',
>  	dfpost => 'XDFPOST',
>  	dfblob => 'XDFPRE XDFPOST',
> +	patchid => 'XDFID',
>  );
>  
> -my $non_quoted_body = 'XNQ XDFN XDFA XDFB XDFHH XDFCTX XDFPRE XDFPOST';
> +my $non_quoted_body = 'XNQ XDFN XDFA XDFB XDFHH XDFCTX XDFPRE XDFPOST XDFID';
>  my %prob_prefix = (
>  	# for mairix compatibility
>  	s => 'S',

Should an entry for this be added to Search.pm's @HELP?