From: Kyle Meyer <kyle@kyleam.com>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 2/3] search: support "patchid:" prefix (git patch-id --stable)
Date: Mon, 20 Jun 2022 16:01:33 -0400 [thread overview]
Message-ID: <87letrt882.fsf@kyleam.com> (raw)
In-Reply-To: <20220620192730.550803-3-e@80x24.org>
Eric Wong writes:
> This allows easy searching via patch-id from a git commit.
Neat. I played around a bit with this locally, and it seems to be
working nicely.
> diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
> index 523003b3..6f9fdde1 100644
> --- a/lib/PublicInbox/Search.pm
> +++ b/lib/PublicInbox/Search.pm
> @@ -1,4 +1,4 @@
> -# Copyright (C) 2015-2021 all contributors <meta@public-inbox.org>
> +# Copyright (C) all contributors <meta@public-inbox.org>
> # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
> # based on notmuch, but with no concept of folders, files or flags
> #
> @@ -118,9 +118,10 @@ my %bool_pfx_external = (
> dfpre => 'XDFPRE',
> dfpost => 'XDFPOST',
> dfblob => 'XDFPRE XDFPOST',
> + patchid => 'XDFID',
> );
>
> -my $non_quoted_body = 'XNQ XDFN XDFA XDFB XDFHH XDFCTX XDFPRE XDFPOST';
> +my $non_quoted_body = 'XNQ XDFN XDFA XDFB XDFHH XDFCTX XDFPRE XDFPOST XDFID';
> my %prob_prefix = (
> # for mairix compatibility
> s => 'S',
Should an entry for this be added to Search.pm's @HELP?
next prev parent reply other threads:[~2022-06-20 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 19:27 [PATCH 0/3] search indexing improvements Eric Wong
2022-06-20 19:27 ` [PATCH 1/3] searchidx: use regexp as first arg for `split' op Eric Wong
2022-06-20 19:27 ` [PATCH 2/3] search: support "patchid:" prefix (git patch-id --stable) Eric Wong
2022-06-20 20:01 ` Kyle Meyer [this message]
2022-06-21 10:37 ` [PATCH 4/3] search: add help for patchid: prefix Eric Wong
2022-06-22 7:50 ` [PATCH 5/3] doc: lei-q: regenerate for patchid: help Eric Wong
2022-06-20 19:27 ` [PATCH 3/3] search: do not index base-85 binary patches Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87letrt882.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).