From: Leah Neukirchen <leah@vuxu.org>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: WwwAttach::referer_match and HTTPS
Date: Fri, 06 Aug 2021 22:50:55 +0200 [thread overview]
Message-ID: <878s1e9u1c.fsf@vuxu.org> (raw)
In-Reply-To: <20210806204132.GB25682@dcvr> (Eric Wong's message of "Fri, 6 Aug 2021 20:41:32 +0000")
Eric Wong <e@80x24.org> writes:
> Leah Neukirchen <leah@vuxu.org> wrote:
>> Hi,
>>
>> I noticed that referer_match in lib/PublicInbox/WwwAttach.pm always
>> fails over HTTPS on my setup as psgi.url_scheme is set to 'http' in
>> lib/PublicInbox/HTTPD.pm but I have a HTTPS-terminating proxy in front,
>> so the referer starts with "https://"
>> (public-inbox-1.6.1 but same in HEAD afaics.)
>>
>> Did I forget to set anything, or should referer_match just accept both
>> http and https?
>
> Hmm, yes, probably it should unconditionally accept /\Ahttps?/i
> iff psgi.url_scheme eq 'http' given the way common configs are.
> psgi.url_scheme seems inconsistent and difficult to rely on with
> so many possible forwarding proxies and configurations.
>
> There's the Forwarded: (RFC 7239) header nowadays, and
> X-Forwarded-* before, though I suspect X-Forwarded-* remains
> widely in use.
I currently set
proxy_set_header X-Forwarded-Host $host;
proxy_set_header X-Forwarded-Server $host;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
but not X-Forwarded-Proto...
--
Leah Neukirchen <leah@vuxu.org> https://leahneukirchen.org
next prev parent reply other threads:[~2021-08-06 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 15:01 WwwAttach::referer_match and HTTPS Leah Neukirchen
2021-08-06 20:41 ` Eric Wong
2021-08-06 20:50 ` Leah Neukirchen [this message]
2021-08-08 1:00 ` Eric Wong
2021-08-08 11:17 ` Leah Neukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s1e9u1c.fsf@vuxu.org \
--to=leah@vuxu.org \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).