From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyle@kyleam.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS11403 64.147.108.0/24
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
	SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id F306B1F751
	for <meta@public-inbox.org>; Mon, 20 Apr 2020 01:13:31 +0000 (UTC)
Received: from pb-smtp1.pobox.com (unknown [127.0.0.1])
	by pb-smtp1.pobox.com (Postfix) with ESMTP id 0A92351BDD;
	Sun, 19 Apr 2020 21:13:31 -0400 (EDT)
	(envelope-from kyle@kyleam.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:in-reply-to:references:date:message-id:mime-version
	:content-type; s=sasl; bh=tW32W/XTeUINnLfNoou56T7ws8A=; b=NsF4Ov
	JLeVVMbgDddCoKjlSH0SKAXqT++txo1rNyAqAfradX8IrIdhZSdnyG4+EDqPCG9n
	5WkABMmk3FmumsuAD7egqeTARgXCeIpRsiANLfzVs2vDX2uRL7tJo5+nvbvJJ0BF
	z9Dh5IlZTSwD0d55aIOMwWL+dlmd41LEjvSDE=
Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1])
	by pb-smtp1.pobox.com (Postfix) with ESMTP id EF03E51BDC;
	Sun, 19 Apr 2020 21:13:30 -0400 (EDT)
	(envelope-from kyle@kyleam.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com;
 h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=oqwnn0RiWUzTyS3ebVzjS+Ju+Ht9BCOvJVOwdVCqsLo=; b=nk8Mqcr5NMDeXV2V+8PyTS35khekPSOYHztbjUobcDm8A9sG3jSTOYWhv2uhxFY+bXJ9bd4NzjMo83aK/yOj/QZ3apFqpg+Ubu04vbABVOtrr+sBgx5H73QdOQC6y5Pcs7HW8ZDB82Rr1ETTQUv5lLDFex5dW3DaWn7BeAD3KcY=
Received: from localhost (unknown [45.33.91.115])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 83BBF51BDB;
	Sun, 19 Apr 2020 21:13:30 -0400 (EDT)
	(envelope-from kyle@kyleam.com)
From: Kyle Meyer <kyle@kyleam.com>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH v2] watchmaildir: support multiple watchheader values
In-Reply-To: <20200420004515.GA67768@dcvr>
References: <20200412215933.GA63705@dcvr> <20200420001332.14769-1-kyle@kyleam.com> <20200420004515.GA67768@dcvr>
Date: Mon, 20 Apr 2020 01:13:22 +0000
Message-ID: <877dybrmbx.fsf@kyleam.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID:
 259D62E0-82A4-11EA-A5D3-C28CBED8090B-24757444!pb-smtp1.pobox.com
List-Id: <meta.public-inbox.org>

Eric Wong <e@80x24.org> writes:

> Kyle Meyer <kyle@kyleam.com> wrote:
>
> <snip> Thanks.  Most everything looks good, some minor issues..
>
>> +++ b/t/watch_muliple_headers.t
>
> speling :>

Oops, thanks.

>> +my $num = $ibx->mm->num_for('to@a.com');
>> +ok(defined $num, 'Matched for address in To:');
>> +my $num = $ibx->mm->num_for('cc@a.com');
>
> That `$num' shadows/masks

Ah, sorry.  Aside from, er, actually knowing what I'm doing in perl and
seeing that obvious mistake, is there a way I could see the warning when
I run the tests?  To run only the tests in that file as I was working on
it, I started with the command I saw when I called 'make test' and
restricted it to just the file, So, with typo included for historical
accuracy :), I was running

  PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" \
    "-MTest::Harness" "-e" \
    "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" \
    t/watch_muliple_headers.t

> Will squash the following in before pushing:

Thanks!