From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyle@kyleam.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
	SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id F0C9D1F670
	for <meta@public-inbox.org>; Fri, 13 Nov 2020 12:38:03 +0000 (UTC)
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
	by pb-smtp2.pobox.com (Postfix) with ESMTP id F0E1C78522;
	Fri, 13 Nov 2020 07:38:01 -0500 (EST)
	(envelope-from kyle@kyleam.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:in-reply-to:references:date:message-id:mime-version
	:content-type; s=sasl; bh=b20S+mIA2ScDE1NfXSVJF22Vv3A=; b=X6cyS9
	ENhghC0MZ2rmVJatdpUnAln7KbXMdLkBy62yJ2exLC7VzELryELIfD0W6mF/knkV
	A6IrON8kFs4ASluFXyrhk8rd2DnL74H4qqBrk7thLwYkLhFjSsDm35cK1VXP5ywY
	EDQj4hRgTANDl/b5PIg5K6B7mdTX/6geq+51o=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
	by pb-smtp2.pobox.com (Postfix) with ESMTP id D34C478521;
	Fri, 13 Nov 2020 07:38:01 -0500 (EST)
	(envelope-from kyle@kyleam.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com;
 h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=y4Eo/+dsOY1DAHJOA2Al3cuvJ7k0lCMrmrIfjddXp9k=; b=2Ahwvlg0rShhJmc/qNsBOg1mmgHhLFjH3L9Bq90pGAtzPnL9BMgEsxORaFBJrZGRAS6T2LdUZIEbGNiLL4B1luGQikCHIxqIMLiRBbffuBQJwZvjLg2sbjBRpgm7vgZRm4Ln5IJnELL/zhTRFyVzn7+yRTre7EyvnTonbY6t4ec=
Received: from localhost (unknown [45.33.91.115])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by pb-smtp2.pobox.com (Postfix) with ESMTPSA id D3E3B78520;
	Fri, 13 Nov 2020 07:38:00 -0500 (EST)
	(envelope-from kyle@kyleam.com)
From: Kyle Meyer <kyle@kyleam.com>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 2/4] *index: avoid per-epoch --batch-check processes
In-Reply-To: <20201113111144.23038-3-e@80x24.org>
References: <20201113111144.23038-1-e@80x24.org>
 <20201113111144.23038-3-e@80x24.org>
Date: Fri, 13 Nov 2020 07:38:00 -0500
Message-ID: <877dqpig9j.fsf@kyleam.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID:
 1101129E-25AD-11EB-8BF2-74DE23BA3BAF-24757444!pb-smtp2.pobox.com
List-Id: <meta.public-inbox.org>

[ superficial typo comments from a reader who is out of his depth :) ]

Eric Wong writes:

> Since all.git (v2) and ALL.git (extindex) encompass every single
> epoch or indexed inbox; and we is_ancestor() only uses

s/we is_ancestor/is_ancestor/?

> hexadecimal OIDs, there is no good reason to to use $unit->{git}
> for an epoch-local $git->check avoids redundant long-lived
> processes.

s/to to/to/

I'm having trouble parsing that last part.  Perhaps the "avoids ..." is
covered by the next paragraph and should be dropped?

> This prevents dozens/hundreds of --batch-check processes from
> being left running after indexing and can improve locality
> if size checks are being done (since that uses --batch-check,
> too).
>
> Theoretically an several epochs may have conflicting OIDs, but

s/an several/several/

> we're screwed in those cases, anyways, so we might as well
> detect it earlier (though I'm not sure what the behavior would
> be :x).