From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6315 166.70.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 04D931F62D; Fri, 6 Jul 2018 00:36:34 +0000 (UTC) Received: from in02.mta.xmission.com ([166.70.13.52]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fbEjg-0005HB-OA; Thu, 05 Jul 2018 18:36:32 -0600 Received: from [97.119.167.31] (helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fbEjf-0003jd-Mr; Thu, 05 Jul 2018 18:36:32 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Eric Wong Cc: meta@public-inbox.org References: <87a7r6z1cy.fsf@xmission.com> <20180705231346.GA6524@dcvr> Date: Thu, 05 Jul 2018 19:36:20 -0500 In-Reply-To: <20180705231346.GA6524@dcvr> (Eric Wong's message of "Thu, 5 Jul 2018 23:13:46 +0000") Message-ID: <87601turnf.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1fbEjf-0003jd-Mr;;;mid=<87601turnf.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.119.167.31;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18OMX+X1vIuZOE1H9EosWHEsrrZBQ5oHY4= X-SA-Exim-Connect-IP: 97.119.167.31 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: Warnings from git fsck after lkml import X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) List-Id: Eric Wong writes: > "Eric W. Biederman" wrote: >> It looks like public-inbox has some challenges when importing some >> questionable emails. The import of lkml has resulted in several commits >> with bad dates that git fsck complains about. I have previously >> reported this to Konstantin Ryabitsev who maintains kernel.org but since >> I have not seen any discussion of this I thought I should report it >> directly here as well. > > Thanks for bringing this up publically. > > Yes, I early during v2 development I noticed old mails had some > -1400 timezone values (but the furthest is -1200). I opted to > attempt to preserve the wonky timezones since fast-import > happily accepts -1400 and I didn't anticipate problems... I think 0.git was generated after your earlier fix. Looking at the commits in question this is a different issue. On some of the later ones I am really not certain what it is but here is a representative sample you can look at. email: Date: Wed, 13 Dec 2006 10:26:38 +1 git: Date: Wed Dec 13 09:27:38 2006 +0001 email: Date: Sun, 10 Sep 2006 23:18:30 +1 git: Date: Sun Sep 10 22:19:30 2006 +0001 email: Date: Fri, 3 Feb 2006 18:11:22 -00 git: Date: Fri Feb 3 18:11:22 2006 +0000 email: Date: Mon, 06 Jun 2005 13:59:56 +1 git: Date: Mon Jun 6 13:00:56 2005 +0001 email: Date: Thursday, 20 Feb 2003 01:14:34 +000 git: Date: Thu Feb 20 01:14:34 2003 +0000 # The error in this one does not immediate stand out commit: 0f66db71a06bd7d651a0cd80877d8043b70fda20 email: Date: Fri, 28 Jun 2002 12:54:40 -700 git: Date: Fri Jun 28 12:54:40 2002 -0700 commit e8d3b19a91a2d86b6a91bd19dc811e851398b519 email: Date: Sat, 12 Jan 2002 12:52:57 -200 git: Date: Sat Jan 12 12:52:57 2002 -0200 commit afd9fc0cc87e56ed7736d633e17d0ef77817b3cc email: Date: Thu, 10 Jan 2002 09:56:29 -200 git: Date: Thu Jan 10 09:56:29 2002 -0200 commit 811b3217708358cf1b75fba4602a64a426fce0f5 email: Date: Mon, 05 Nov 2001 10:36:16 -800 git: Date: Mon Nov 5 10:36:16 2001 -0800 commit e7a751a597c6f5e4770c61bdee6220d55a37cba9 email: Date: Sun, 09 Sep 2001 09:59:05 -800 git: Date: Sun Sep 9 09:59:05 2001 -0800 commit 3e32ad6192fe093e03e6b9346c3a90b16d9905c0 email: Date: Monday, 09 Apr 2001 23:50:10 +000 git: Date: Mon Apr 9 23:50:10 2001 +0000 >> >> At a practical level these errors initially preventing me from cloning >> the repos as in .gitconfig I had: >> > [transfer] >> > fsckobjects = true >> > [fetch] >> > fsckobjects = true >> > [receive] >> > fsckobjects = true > > ...But I didn't know people cared to set those :x > > Now I wonder if git should only warn for bad-but-still-usable > objects on clone, as I wouldn't consider a malformed date to be > on the level as actual FS corruption. Or at least complete > the clone and fail with a special exit code. I have added: [fsck] badTimezone = warn To hopefully achieve that. Eric