From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS151847 202.12.124.0/24 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,URIBL_SBL_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from fhigh-b5-smtp.messagingengine.com (fhigh-b5-smtp.messagingengine.com [202.12.124.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E66F41F4D0 for ; Tue, 7 Jan 2025 17:56:11 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=alyssa.is header.i=@alyssa.is header.a=rsa-sha256 header.s=fm1 header.b=nXbulCd8; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=onpbiuGk; dkim-atps=neutral Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id EEDE625401A0 for ; Tue, 7 Jan 2025 12:46:39 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Tue, 07 Jan 2025 12:46:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm1; t=1736271999; x=1736358399; bh=QheidLDT+lGa8XuMlue6z q7PXuIVpas01BR4TqnijaE=; b=nXbulCd8gUDCHGSe5kLiCz4YTAOuP6MD2k9Qm uzlt9hunBJQ5TPXD0LyoQJg8aPyi3WiyWAfiDG03oGKfnWDQXww90oiPgOtjwmxF Ci7wkYhj4h33EuhvyifwMcGDj785v1YANSjHjq2zY1y2sl/7jm4YAQbzezd5RzSj BpKXxzmsEnLdlF5RDOxN1vtYZSwoy/j48wWVBfHaC2Lyc5ji5oVCCFoS3efDOUpA RdFRXDqSjemVtElxu6pKdl+T/bHTfAlUqqmJ+rfWB6+gm5HyPPetA/Uan8NDcGzs aYKEl9gFzTqNFzUw9kY0GaqgnP3RdUj4VpHN2dTcbA25QLZ+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1736271999; x=1736358399; bh=QheidLDT+lGa8XuMlue6zq7PXuIVpas01BR 4TqnijaE=; b=onpbiuGkUwjH+2kvVZ1uJTt5vKIdfxptfImYjztRvFYS1HTStck NaRF0y2K8IiVjqf6DmNB5lPwMxZsgKSo2LbGPjQMYy6y761W6KTlJY12DgrZAkUf 60PMjo7djfxL+tYE3btAgxOAr7P7pJy+Di5ig1+0/0iBtb2lf95bPhLPYbifm2tK ZgZ2MkXFqDs5horYod+Fimg4I+p093Z78B+oW9XbH8MUHNpDmW9LWQOn2d1WXcq3 vLW+yW60xKDMAj+humJge6hDyJYmDLF1Gd6B55z7nNWlnnereTfnhlwbidCE39AC 8JgoDGzBrJW2EGlTxjGTvitM2cvBVYi/zRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudegvddguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvuf ffkffoggfgsedtkeertdertddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhi segrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeehvdffgffhteeijefgteeftd fghfdvheeuhedvjedugfeggfeljefgleefvefgfeenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspghrtg hpthhtohepuddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmhgvthgrsehpuhgs lhhitgdqihhnsghogidrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 7 Jan 2025 12:46:39 -0500 (EST) Received: by mbp.qyliss.net (Postfix, from userid 1000) id BC144D8EE; Tue, 07 Jan 2025 18:46:36 +0100 (CET) From: Alyssa Ross To: meta@public-inbox.org Subject: [PATCH 1/2] t/lei-sigpipe.t: use correct pipe size Date: Tue, 7 Jan 2025 18:46:23 +0100 Message-ID: <20250107174624.1504268-1-hi@alyssa.is> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: According to fcntl(2), Linux will round up pipe sizes lower than a page to a whole page. Additionally, the kernel may use a larger size in general, "if that is convenient for the implementation". The actual size of the pipe is returned from fcntl, so the test should use that return value, rather than assuming the size requested was accepted exactly. This fixes the test on my system with 16K pages. --- t/lei-sigpipe.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/lei-sigpipe.t b/t/lei-sigpipe.t index b9fd88a6..c01d9f83 100644 --- a/t/lei-sigpipe.t +++ b/t/lei-sigpipe.t @@ -33,8 +33,8 @@ test_lei(sub { my $imported; for my $out ([], [qw(-f mboxcl2)], [qw(-f text)]) { pipe(my $r, my $w); - my $size = $F_SETPIPE_SZ && fcntl($w, $F_SETPIPE_SZ, 4096) ? - 4096 : 65536; + my $size = ($F_SETPIPE_SZ && fcntl($w, $F_SETPIPE_SZ, 4096)) || + 65536; unless (-f $f) { my $fh = write_file '>', $f, <<'EOM'; From: big@example.com base-commit: 7ec09f72bc12c3b882ba56c8bf16565f39afbc79 -- 2.47.0