From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id DF6341F4CC
	for <meta@public-inbox.org>; Mon,  9 Dec 2024 20:57:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1733777869;
	bh=vxaPsRE4q7oxFWiTxGEUfziXqCsUnNI6Ev9X9fnGSWg=;
	h=From:To:Subject:Date:From;
	b=DhqqiSUgOo7u2OViizw944/BDM57V0jg4dK+WFOq+WlOztQabM+Q8Jiz//yowZZfE
	 rWW+rbuO9vH+r3Na/Ka+IhQ57KBmr9S/gXYWs/3IuiXzgVgXmwEk6OgMwFbMWcV2sJ
	 RnEHEGncE/WSo8L08JwkSDBOiFb7NjdA+fUYpxiM=
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] search_query: drop CR (`\r') from queries
Date: Mon,  9 Dec 2024 20:57:49 +0000
Message-ID: <20241209205749.883976-1-e@80x24.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

w3m (and presumably other browsers) send CRLF instead of LF for
queries made from <textarea> from the VCS view.  CRs require
unnecessary escaping and make RLs look ugly, so omit them
to cleanup URLs and reduce memory traffic in Xapian.
---
 lib/PublicInbox/SearchQuery.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/SearchQuery.pm b/lib/PublicInbox/SearchQuery.pm
index 747e3249..e0127dea 100644
--- a/lib/PublicInbox/SearchQuery.pm
+++ b/lib/PublicInbox/SearchQuery.pm
@@ -17,8 +17,10 @@ sub new {
 	my ($l) = (($qp->{l} || '') =~ /([0-9]+)/);
 	$l = $LIM if !$l || $l > $LIM;
 	my ($o) = (($qp->{o} || '0') =~ /(-?[0-9]+)/);
+	my $q = $qp->{'q'};
+	$q =~ s/\r\n/\n/sg if defined $q;
 	bless {
-		q => $qp->{'q'},
+		q => $q,
 		x => $qp->{x} || '',
 		o => $o,
 		l => $l,