From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 6A2981F4C1
	for <meta@public-inbox.org>; Wed, 20 Nov 2024 19:12:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1732129943;
	bh=WcCmGc0Q9r8NNMkwcdH8YCovW9fWLs4DHj3y0PmGsoM=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=YTuXcdZV2NO9I3ZwfvkrORzmZLI+Xk5d/QpOucYTGnHyO1dLO9KndE5Ye5Do9QDI6
	 O1hVKbvpiFMknttJFECMhfPgV5pKylytZh0nsPrkQYPXeP56afPZy5GLTcgl30A9+Y
	 iAixjidQQrZul/7h/jcvd5taz0TCcPiScls9SwIc=
Date: Wed, 20 Nov 2024 19:06:58 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 3/3] v2writable: done: force synchronous awaitpid
Message-ID: <20241120190658.M920857@dcvr>
References: <20241119214752.1883670-1-e@80x24.org>
 <20241119214752.1883670-4-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20241119214752.1883670-4-e@80x24.org>
List-Id: <meta.public-inbox.org>

Pushed as commit 99fc3d76968aacaea55f5b98b5b5a4d2314bc97c
with the following commit message:

    v2writable: done: force synchronous awaitpid

    We need to shut down shards synchronously to reliably release
    the inbox write lock when inside the DS event loop (as the
    lei/store subprocess is, unlike most v2writable users).

    This seems to fix long-running `lei import' failures to
    lei/store after repeated tests.  It is a good idea anyways to
    ensure exit status of shard workers are correct before returning
    from ->done.