From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 4/6] nntp: integerize {article} to save memory
Date: Fri, 15 Nov 2024 02:59:30 +0000 [thread overview]
Message-ID: <20241115025932.1647240-5-e@80x24.org> (raw)
In-Reply-To: <20241115025932.1647240-1-e@80x24.org>
The NNTP article number is always an integer, so ensure it's
stored as one to avoid malloc overhead since NNTP clients may
linger for minutes at a time.
---
lib/PublicInbox/NNTP.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 1749a755..6fa9159f 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -520,7 +520,7 @@ sub msg_body_write ($$) {
sub set_art {
my ($self, $art) = @_;
- $self->{article} = $art if defined $art && $art =~ /\A[0-9]+\z/;
+ $self->{article} = $art + 0 if defined $art && $art =~ /\A[0-9]+\z/;
}
sub msg_hdr_write ($$) {
next prev parent reply other threads:[~2024-11-15 2:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 2:59 [PATCH 0/6] a few random small fixes and improvements Eric Wong
2024-11-15 2:59 ` [PATCH 1/6] tests: fix missing modules under TEST_RUN_MODE=0 Eric Wong
2024-11-15 2:59 ` [PATCH 2/6] test_common: disable fsync in git(1) commands Eric Wong
2024-11-15 2:59 ` [PATCH 3/6] nntp: improve protocol error messages Eric Wong
2024-11-15 2:59 ` Eric Wong [this message]
2024-11-15 2:59 ` [PATCH 5/6] view: reduce ops for <b> encasement Eric Wong
2024-11-15 2:59 ` [PATCH 6/6] view: fix obfuscation in message/* attachments Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115025932.1647240-5-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).