From: Eric Wong <e@80x24.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: meta@public-inbox.org
Subject: Re: Occasional public-inbox-httpd flakiness
Date: Tue, 12 Nov 2024 21:54:32 +0000 [thread overview]
Message-ID: <20241112215432.M457200@dcvr> (raw)
In-Reply-To: <87bjykp1kl.fsf@trenco.lwn.net>
Jonathan Corbet <corbet@lwn.net> wrote:
> Eric Wong <e@80x24.org> writes:
> > Jonathan Corbet <corbet@lwn.net> wrote:
> >> Eric Wong <e@80x24.org> writes:
> >> > Jonathan Corbet <corbet@lwn.net> wrote:
> >> >> Just to add a data point...the problem just recurred, and there are
> >> >> definitely cat-file processes running:
> >> >>
> >> >> $ ps ax | fgrep git
> >> >> 2640024 ? S 0:40 /usr/bin/git --git-dir=repos/ALL.git -c core.abbrev=40 cat-file --batch
> >> >> 2735080 ? S 0:18 /usr/bin/git --git-dir=repos/ALL.git -c core.abbrev=40 cat-file --batch
> >> >> 3184082 ? S 0:03 /usr/bin/git --git-dir=repos/ALL.git -c core.abbrev=40 cat-file --batch
> >> >> 3723223 ? Z 0:00 [git] <defunct>
> >> >> 3723227 ? Z 0:00 [git] <defunct>
> >> >
> >> > Can you see if the worker process causing warnings is connected to defunct gits?
> >> > Should've been fixed in master a while ago, but there's a lot of changes :x
> >> > master should be fine as long as you're not using -cindex + coderepos yet.
> >>
> >> By "connected to" you mean "is the parent of"?
> >
> > Yes. lsof +E should show how pipes are connecting processes.
> > Just wondering, those git zombies lingered until the restart, right?
> >
> > IOW, they didn't disappear after a few seconds if the -httpd
> > worker was busy with other things. During heavy traffic you'll
> > inevitably see short-lived zombies as the -httpd may not reap
> > fast enough, but zombies shouldn't linger indefinitely.
>
> Looking back through the terminal history, it looks like the zombies
> hung out for a bit, but then went away. There were a couple of zombies
> every time I looked, but the PIDs eventually changed.
OK. Any idea how long the zombies lingered?
How much load the LWN -httpd instance see?
AFAIK, the main cause of zombies I've seen was from the blob solver,
but that requires coderepos, which AFAIK nobody else ever used...
Also, it would likely be useful if you got an strace on the worker PID
that was causing warnings
prev parent reply other threads:[~2024-11-12 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 22:31 Occasional public-inbox-httpd flakiness Jonathan Corbet
2024-11-05 23:24 ` Eric Wong
2024-11-05 23:29 ` Jonathan Corbet
2024-11-05 23:34 ` Eric Wong
2024-11-12 19:14 ` Jonathan Corbet
2024-11-12 19:20 ` Eric Wong
2024-11-12 21:25 ` Jonathan Corbet
2024-11-12 21:41 ` Eric Wong
2024-11-12 21:46 ` Jonathan Corbet
2024-11-12 21:54 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112215432.M457200@dcvr \
--to=e@80x24.org \
--cc=corbet@lwn.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).