unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 4/4] view: avoid uninitialized var from diff query textarea
Date: Mon, 11 Nov 2024 21:56:56 +0000	[thread overview]
Message-ID: <20241111215656.2411957-5-e@80x24.org> (raw)
In-Reply-To: <20241111215656.2411957-1-e@80x24.org>

Rare commits without titles and emails without a Subject: header
should not litter stderr or syslog with uninitialized variable
warnings.
---
 lib/PublicInbox/View.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 275258e3..7ca85a85 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -849,7 +849,7 @@ sub thread_skel ($$$) {
 sub dfqry_text ($$) {
 	my ($ctx, $subj) = @_;
 	my $qry_dfblob = delete $ctx->{-qry_dfblob} or return (undef);
-	my @bs = split /["\x{201c}\x{201d}]+/, $subj;
+	my @bs = split /["\x{201c}\x{201d}]+/, $subj // '';
 	my $q = join ' ', (@bs ? ('(') : ()), map {
 		chop if length > 7; # include 1 abbrev "older" patches
 		"dfblob:$_";

      parent reply	other threads:[~2024-11-11 21:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11 21:56 [PATCH 0/4] another round of small fixes Eric Wong
2024-11-11 21:56 ` [PATCH 1/4] t/inbox_idle: delay for low-res FS w/o inotify||kqueue Eric Wong
2024-11-11 21:56 ` [PATCH 2/4] t/spawn: increase timeout for slow systems Eric Wong
2024-11-11 21:56 ` [PATCH 3/4] import: avoid uninitialized comparison on failures Eric Wong
2024-11-11 21:56 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241111215656.2411957-5-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).