From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH v2 3/3] viewvcs: generate search query for merge commits
Date: Mon, 7 Oct 2024 08:29:58 +0000 [thread overview]
Message-ID: <20241007082959.M2843@dcvr> (raw)
In-Reply-To: <20241002223902.4139389-4-e@80x24.org>
Eric Wong <e@80x24.org> wrote:
> @@ -275,7 +305,10 @@ committer $co
>
> <b>$title_html</b>
> EOM
> - print $zfh "\n", $ctx->{-linkify}->to_html($bdy) if length($bdy);
> + if (length($bdy)) {
> + print $zfh "\n", $ctx->{-linkify}->to_html($bdy);
> + $merge_titles = prep_merge_titles $bdy if $merge_titles;
> + }
I squashed this in to handle blank commit messages for merges:
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 48a16c11..d9df671c 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -334,7 +334,7 @@ id=related><pre>find related emails, including ancestors/descendants/conflicts
/>\t(<a href="${ibx_url}_/text/help/">help</a>)</pre></form>
EOM
}
- if ($merge_titles) {
+ if (ref $merge_titles) {
print $zfh <<EOM;
<hr><form action="$ibx_url" id=merged><pre>find merged patch emails
<textarea name=q cols=78
prev parent reply other threads:[~2024-10-07 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 19:44 [PATCH] viewvcs: generate search query for merge commits Eric Wong
2024-10-02 22:38 ` [PATCH v2 0/3] viewvcs: commit => query improvements Eric Wong
2024-10-02 22:39 ` [PATCH v2 1/3] viewvcs: close the <pre> tag if no query is extracted Eric Wong
2024-10-02 22:39 ` [PATCH v2 2/3] viewvcs: use wider textarea for search query Eric Wong
2024-10-02 22:39 ` [PATCH v2 3/3] viewvcs: generate search query for merge commits Eric Wong
2024-10-07 8:29 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007082959.M2843@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).