From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 015371F5CE
	for <meta@public-inbox.org>; Wed,  2 Oct 2024 22:39:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1727908743;
	bh=aY5I9U9UE4uSiBKgoZcPnxLz5INPUUdHdHmSAMmeBio=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=0fLxCRz5BSqSxV1TuDmXTcwGgYhptfuoe9nLEVMSMVSvUH5UaSCrL3DJsACfvrmiG
	 rOEEv0SuKM1who/uIvDVEbMKxZAYzkbE+efVcbJQHCEiyBgtd4Gk2+EgQfi5i77Z7f
	 WysYw6qKblHRuyK3yBdmv99AuJYKQUDlTsRs2QyE=
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH v2 1/3] viewvcs: close the <pre> tag if no query is extracted
Date: Wed,  2 Oct 2024 22:39:00 +0000
Message-ID: <20241002223902.4139389-2-e@80x24.org>
In-Reply-To: <20241002194448.4123393-1-e@80x24.org>
References: <20241002194448.4123393-1-e@80x24.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

In the odd case we get a patch with no valid query and
no commit title, we still need to close the <pre> tag
we started.
---
 lib/PublicInbox/ViewVCS.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 14c2e4e3..a29789fd 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -291,6 +291,7 @@ EOM
 		# TODO: should there be another textarea which attempts to
 		# search for the exact email which was applied to make this
 		# commit?
+		print $zfh '</pre>';
 		my ($rows, $q) = PublicInbox::View::dfqry_text $ctx, $s;
 		if ($rows) {
 			my $ibx_url = ibx_url_for($ctx);
@@ -305,7 +306,7 @@ EOM
 				$alt = '';
 			}
 			print $zfh <<EOM;
-</pre><hr><form action="$ibx_url"
+<hr><form action="$ibx_url"
 id=related><pre>find related emails, including ancestors/descendants/conflicts
 <textarea name=q cols=${\PublicInbox::View::COLS} rows=$rows>$q</textarea>
 <input type=submit value="search$alt"