unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Cc: "Robin H. Johnson" <robbat2@gentoo.org>,
	"Štěpán Němec" <stepnem@smrk.net>
Subject: Re: [PATCH v2] www: allow specifying CSS @import or <link> tags
Date: Sun, 29 Sep 2024 00:22:38 +0000	[thread overview]
Message-ID: <20240929002238.M917903@dcvr> (raw)
In-Reply-To: <20240928204217.M58159@dcvr>

Eric Wong <e@80x24.org> wrote:
> I'll squash this in before pushing:

And this, totally forgot to test the final patch :x

diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 60c437a5..987d644e 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -632,7 +632,7 @@ sub stylesheets_prepare ($$) {
 			} elsif (open(my $fh, '<', $fn)) {
 				($local, $ctime) = _read_css $fh, $mini, $fn;
 				if ($local =~ /\@import\b/) {
-					$import = $attr->{-do_import} = 1
+					$import = $attr->{-do_import} = 1;
 					push @css_dir, $dir if !$css_dir{$dir}++
 				}
 				$css_map->{$key} = [ $local, $ctime ];

  reply	other threads:[~2024-09-29  0:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-01  5:07 CSS behaviors bug report: dark/light switch non-functional Robin H. Johnson
2024-09-18  0:04 ` Eric Wong
2024-09-26  0:55 ` [PATCH 0/5] css improvements (hopefully) Eric Wong
2024-09-26  0:55   ` [PATCH 1/5] user_content: simplify internal API and use v5.12 Eric Wong
2024-09-26  0:55   ` [PATCH 2/5] www: don't reread CSS files Eric Wong
2024-09-26  0:55   ` [PATCH 3/5] www: load CSS files in same dir if @import is in use Eric Wong
2024-09-26  0:55   ` [PATCH 4/5] www: allow specifying CSS @import or <link> tags Eric Wong
2024-09-26 18:34     ` Štěpán Němec
2024-09-28 18:39       ` [PATCH v2] " Eric Wong
2024-09-28 19:29         ` Štěpán Němec
2024-09-28 20:42           ` Eric Wong
2024-09-29  0:22             ` Eric Wong [this message]
2024-09-26  0:55   ` [PATCH 5/5] www: use mtime as CSS cache-buster instead of ctime Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240929002238.M917903@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --cc=robbat2@gentoo.org \
    --cc=stepnem@smrk.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).