From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stepnem@smrk.net>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS20473 45.76.80.0/20
X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6
Received: from mail.smrk.net (mail.smrk.net [45.76.87.244])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512)
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 4BD561F5CB
	for <meta@public-inbox.org>; Thu, 26 Sep 2024 18:33:12 +0000 (UTC)
Authentication-Results: dcvr.yhbt.net;
	dkim=pass (2048-bit key; unprotected) header.d=smrk.net header.i=@smrk.net header.a=rsa-sha256 header.s=20221002 header.b=Pu03dpjk;
	dkim-atps=neutral
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smrk.net; s=20221002;
	t=1727375590;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Q4N1Jr4DzC2AvbdI3OVaQLBMgKI6cJG/t98GP4vC1Sc=;
	b=Pu03dpjkeuH0AHl8SC+2tnCj6WmyjJMOey8iG4WbvL5TmHdpSWDUU3/1j750896pXD8yif
	c/8d2F0n56mf0Xcg1vWvG/bc/j0HJnsPodVmoTSAE8uUdVfDQ8ni8OKep4djXzSPWpQBC6
	aT7mb7keMuTM09ETzOscLT47qlwRfK/ZCk6Buu5maRHYygq6Ja/NLzDBFIyomC9049zi0p
	dK7gsdOwiwQGrgcd2nqxKCK+E5d6UlXTbySL7aPsZ+XhUiIC0miW3+o9pBQxn+Qg/4wJL9
	2/z+oe9+ICJ1teNqqWFiKar1/o3nyam5kmp891pj5iQXskku2JLBc9MgO4ENng==
Received: from localhost (<unknown> [192.168.5.2])
	by smrk (OpenSMTPD) with ESMTPSA id 66bd6595 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO);
	Thu, 26 Sep 2024 20:33:09 +0200 (CEST)
From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= <stepnem@smrk.net>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org,  "Robin H. Johnson" <robbat2@gentoo.org>
Subject: Re: [PATCH 4/5] www: allow specifying CSS @import or <link> tags
In-Reply-To: <20240926005506.3703216-5-e@80x24.org> (Eric Wong's message of
	"Thu, 26 Sep 2024 00:55:04 +0000")
References: <robbat2-20240901T045635-169490258Z@orbis-terrarum.net>
	<20240926005506.3703216-1-e@80x24.org>
	<20240926005506.3703216-5-e@80x24.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
Date: Thu, 26 Sep 2024 20:34:02 +0200
Message-ID: <20240926183402Z.161922298-stepnem@smrk.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <meta.public-inbox.org>

On Thu, 26 Sep 2024 00:55:04 +0000
Eric Wong wrote:

[...]

> diff --git a/Documentation/public-inbox-config.pod b/Documentation/public=
-inbox-config.pod
> index 50746b21..e968bc49 100644
> --- a/Documentation/public-inbox-config.pod
> +++ b/Documentation/public-inbox-config.pod
> @@ -255,13 +255,21 @@ Default: :all
>=20=20
>  =3Ditem publicinbox.css
>=20=20
> -The local path name of a CSS file for the PSGI web interface.
> -May contain the attributes "media", "title" and "href" which match
> -the associated attributes of the HTML <style> tag.
> -"href" may be specified to point to the URL of a remote CSS file
> +The local path name of a CSS file for the PSGI web interface.  May
> +contain the attributes C<media>, C<title> and C<href> which match the
> +associated attributes of the HTML C<E<lt>styleE<gt>> tag.
> +
> +As of public-inbox 2.0+, C<load> may be C<link> or C<import>;
> +C<link> forces the use of a C<E<lt>linkE<gt>> tag and disable inlining
                                                         ^^^^^^^
disables

I admit that reading this I had no idea what this was
talking about at first, as in, local path name "may contain
attributes"?  Looking at the code, it seems somewhat in the
style of gitattributes(5), plus you handle single-quoted
string values (i.e., embedded spaces), unlike git (looking
at attr.c:parse_attr).

I wonder if a bit of hand-holding (AKA documentation)
could/should be provided here?

Perhaps, if I understand the behavior correctly:

  The local path name of a CSS file for the PSGI web interface.
  Space-separated attributes (C<key=3Dval> or C<key=3D'val with spaces'>)
  may be specified after the path on the same line; C<media>, C<title>
  and C<href> are currently supported, and match the associated attributes
  of the HTML C<E<lt>styleE<gt>> tag.
=20=20
  public-inbox 2.0+ also supports a C<load> attribute with values
  C<link> or C<import>; C<link> forces the use of a C<E<lt>linkE<gt>> tag
  and disables inlining [...]

> +CSS into the C<E<lt>styleE<gt>> tag while C<import> puts CSS C<@import>
> +statements into the C<E<lt>styleE<gt>> tag.  C<import> appears necessary
> +for some browser and C<media> query combinations.
> +C<href> may be specified to point to the URL of a remote CSS file
>  and the path may be "/dev/null" or any empty file.
> +
>  Multiple files may be specified and will be included in the
> -order specified.
> +order specified, but files specified via C<load=3Dimport> are
> +always handled first.

[...]

--=20
=C5=A0t=C4=9Bp=C3=A1n